You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/05/30 07:10:42 UTC
[GitHub] flink pull request #6101: [FLINK-9458] Unable to recover from job failure on...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6101
[FLINK-9458] Unable to recover from job failure on YARN with NPE
## What is the purpose of the change
*This pull request fixed a NPE when recover job on YARN*
## Brief change log
- *Add non-null judge in the expression *
## Verifying this change
This change is already covered by existing tests, such as *CoLocationConstraintTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9458
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6101
----
commit fa9f1e95aa9b38d243021d330859007f25acaddf
Author: yanghua <ya...@...>
Date: 2018-05-30T07:06:58Z
[FLINK-9458] Unable to recover from job failure on YARN with NPE
----
---
[GitHub] flink pull request #6101: [FLINK-9458] Unable to recover from job failure on...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6101
---
[GitHub] flink issue #6101: [FLINK-9458] Unable to recover from job failure on YARN w...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6101
@tillrohrmann OK, closing...
---
[GitHub] flink issue #6101: [FLINK-9458] Unable to recover from job failure on YARN w...
Posted by kkrugler <gi...@git.apache.org>.
Github user kkrugler commented on the issue:
https://github.com/apache/flink/pull/6101
I'm wondering why, now, we're encountering cases where the `sharedSlot` value is null? Seems like this could be caused by a deeper problem somewhere, so just adding the null check is masking something else that should be fixed.
Also, seems like we'd want a test case to verify the failure (pre-fix) and then appropriate behavior with the fix.
---
[GitHub] flink issue #6101: [FLINK-9458] Unable to recover from job failure on YARN w...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6101
cc @zentol
---
[GitHub] flink issue #6101: [FLINK-9458] Unable to recover from job failure on YARN w...
Posted by kkrugler <gi...@git.apache.org>.
Github user kkrugler commented on the issue:
https://github.com/apache/flink/pull/6101
One other note - I ran into this problem, but it wasn't on YARN. It was running locally (via unit test triggered in Eclipse).
---
[GitHub] flink issue #6101: [FLINK-9458] Unable to recover from job failure on YARN w...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6101
Could you please close this PR @yanghua. It is now subsumed by #6119.
---