You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2015/12/02 10:45:59 UTC
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 9:45 a.m.)
Review request for Falcon.
Changes
-------
Realized that the effective time was not getting set right.
Bugs: FALCON-1512
https://issues.apache.org/jira/browse/FALCON-1512
Repository: falcon-git
Description
-------
Touch feature was not implemented for native scheduler. Adding it now.
Diffs (updated)
-----
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
Diff: https://reviews.apache.org/r/40698/diff/
Testing
-------
Manual testing done. Couldn't add UTs are there are interactions with Oozie.
Thanks,
Pallavi Rao
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Dec. 14, 2015, 9:38 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, line 353
> > <https://reviews.apache.org/r/40698/diff/3/?file=1153803#file1153803line353>
> >
> > What if process is already ended by that time ? Aren't we giving wrong message ?
>
> Pallavi Rao wrote:
> There might be a small window when the a new instance can be scheduled when we are doing the touch. In such a case, the message will show effective time just before touch takes effect. Agreed. But, I don't know if it is worth trying to figure the exact time and add the additional complexity.
>
> Pallavi Rao wrote:
> Sorry. Misunderstood your comment. Added an additional check.
Thanks pallavi
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review110183
-----------------------------------------------------------
On Dec. 15, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/DateUtil.java b70fa20
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 91230b2
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 2a2589e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Dec. 14, 2015, 9:38 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, line 353
> > <https://reviews.apache.org/r/40698/diff/3/?file=1153803#file1153803line353>
> >
> > What if process is already ended by that time ? Aren't we giving wrong message ?
There might be a small window when the a new instance can be scheduled when we are doing the touch. In such a case, the message will show effective time just before touch takes effect. Agreed. But, I don't know if it is worth trying to figure the exact time and add the additional complexity.
> On Dec. 14, 2015, 9:38 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java, line 393
> > <https://reviews.apache.org/r/40698/diff/3/?file=1153804#file1153804line393>
> >
> > Nit: Missed to correct here
Right. Will correct.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review110183
-----------------------------------------------------------
On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:06 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Dec. 14, 2015, 9:38 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, line 353
> > <https://reviews.apache.org/r/40698/diff/3/?file=1153803#file1153803line353>
> >
> > What if process is already ended by that time ? Aren't we giving wrong message ?
>
> Pallavi Rao wrote:
> There might be a small window when the a new instance can be scheduled when we are doing the touch. In such a case, the message will show effective time just before touch takes effect. Agreed. But, I don't know if it is worth trying to figure the exact time and add the additional complexity.
Sorry. Misunderstood your comment. Added an additional check.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review110183
-----------------------------------------------------------
On Dec. 15, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/DateUtil.java b70fa20
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 91230b2
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 2a2589e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review110183
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 353)
<https://reviews.apache.org/r/40698/#comment169959>
What if process is already ended by that time ? Aren't we giving wrong message ?
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java (line 382)
<https://reviews.apache.org/r/40698/#comment169960>
Nit: Missed to correct here
- pavan kumar kolamuri
On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:06 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review110454
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Dec. 15, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/DateUtil.java b70fa20
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 91230b2
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 2a2589e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review110439
-----------------------------------------------------------
Ship it!
Ship It!
- pavan kumar kolamuri
On Dec. 15, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/util/DateUtil.java b70fa20
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 91230b2
> scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 2a2589e
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 6:21 a.m.)
Review request for Falcon.
Changes
-------
Addressed review comments
Bugs: FALCON-1512
https://issues.apache.org/jira/browse/FALCON-1512
Repository: falcon-git
Description
-------
Touch feature was not implemented for native scheduler. Adding it now.
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/util/DateUtil.java b70fa20
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 91230b2
scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java 2a2589e
scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
Diff: https://reviews.apache.org/r/40698/diff/
Testing
-------
Manual testing done. Couldn't add UTs are there are interactions with Oozie.
Thanks,
Pallavi Rao
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review109721
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 387)
<https://reviews.apache.org/r/40698/#comment169338>
It will be useful to provide this as a utility method in DateUtil class.
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 394)
<https://reviews.apache.org/r/40698/#comment170198>
Will it make sense to put this also in DateUtil. This is often used whenever someone uses ```EntityUtil.getNextStartTime```.
- Ajay Yadava
On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:06 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Dec. 9, 2015, 9:58 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java, line 122
> > <https://reviews.apache.org/r/40698/diff/3/?file=1153802#file1153802line122>
> >
> > Pallavi can you add description in jira what touch will do in native scheduler
touch with native scheduler will do the same thing that it does now. Ensures any updates to libraries are picked up (without any change to entity).
> On Dec. 9, 2015, 9:58 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, line 346
> > <https://reviews.apache.org/r/40698/diff/3/?file=1153803#file1153803line346>
> >
> > I didn't get what exactly touch is doing. We are just creating staging path. Will it be useful when effective time come into picture ?
It just builds the entity againin a new staging path. This copies over the libraries to the new staging path afresh. That way, when the next instance is run, the latest libs get picked up.
When effective time comes into picture, we'll have to re-run older instances. Will cross that bridge when we get to it. :-)
> On Dec. 9, 2015, 9:58 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, line 363
> > <https://reviews.apache.org/r/40698/diff/3/?file=1153803#file1153803line363>
> >
> > As of now effective time is always in future (now + 3 mins). Won't it break backward compatability ?
now + 3 is more of a limitation because scheduling on Oozie takes time. With native scheduler, the very next instance that is run, will pick up the changes.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review109478
-----------------------------------------------------------
On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:06 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/#review109478
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java (line 122)
<https://reviews.apache.org/r/40698/#comment169057>
Pallavi can you add description in jira what touch will do in native scheduler
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 346)
<https://reviews.apache.org/r/40698/#comment169055>
I didn't get what exactly touch is doing. We are just creating staging path. Will it be useful when effective time come into picture ?
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 363)
<https://reviews.apache.org/r/40698/#comment169052>
As of now effective time is always in future (now + 3 mins). Won't it break backward compatability ?
- pavan kumar kolamuri
On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40698/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 12:06 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1512
> https://issues.apache.org/jira/browse/FALCON-1512
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Touch feature was not implemented for native scheduler. Adding it now.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
> scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
> scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
>
> Diff: https://reviews.apache.org/r/40698/diff/
>
>
> Testing
> -------
>
> Manual testing done. Couldn't add UTs are there are interactions with Oozie.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 40698: FALCON-1512 Implement touch feature for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40698/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 12:06 p.m.)
Review request for Falcon.
Changes
-------
Wrong patch was attached.
Bugs: FALCON-1512
https://issues.apache.org/jira/browse/FALCON-1512
Repository: falcon-git
Description
-------
Touch feature was not implemented for native scheduler. Adding it now.
Diffs (updated)
-----
scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java ebc05ec
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java ac7cde8
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 70c8353
scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java 087114f
Diff: https://reviews.apache.org/r/40698/diff/
Testing
-------
Manual testing done. Couldn't add UTs are there are interactions with Oozie.
Thanks,
Pallavi Rao