[GitHub] [solr] epugh commented on a change in pull request #288: SOLR-6910: A deleteById request without _route_ param for implicit router could be sent to all shard leaders

[GitBox <gi...@apache.org>]

epugh commented on a change in pull request #288:
URL: https://github.com/apache/solr/pull/288#discussion_r704607164



##########
File path: solr/core/src/test/org/apache/solr/cloud/FullSolrCloudDistribCmdsTest.java
##########
@@ -298,6 +303,29 @@ public void testDeleteByIdCompositeRouterWithRouterField() throws Exception {
         docCountsAfrica.decrementAndGet();
       }
       checkShardCounts.run();
+
+      // Tests for distributing delete by id when route is missing from the request
+
+      { // Send a delete request with no route to shard1 for document on shard2, should be distributed

Review comment:
       This is a "unique" technique, that I haven't seen before in our code base.   I can't really evaluate if it's good or not...   Do we do this elsewhere in the Solr code base?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org