You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Marshall Shi <sh...@cn.ibm.com> on 2012/08/01 09:41:42 UTC

Re: Review Request: Absence of an error code in case of wrong gadget URL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6202/
-----------------------------------------------------------

(Updated Aug. 1, 2012, 7:41 a.m.)


Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.


Changes
-------

Re-create the patch base on latest Shindig code.


Description
-------

Currently, when you specify wrong gadget URL - in SystemOut.log you would get:

[5/1/12 16:53:33:409 IST] 0000005e AbstractSpecF I org.apache.shindig.gadgets.AbstractSpecFactory SpecUpdater An error occurred when updating XXXXX. A cached version is being used instead.

It should report 404 code in that error message, with the exception message, and also the message is warning level not info level. 


This addresses bug shindig-1832.
    https://issues.apache.org/jira/browse/shindig-1832


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties 1351249 
  http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties 1351249 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1362303 

Diff: https://reviews.apache.org/r/6202/diff/


Testing
-------

Fixed a compile error of Anonymous security token as well.


Thanks,

Marshall Shi

Re: Review Request: Absence of an error code in case of wrong gadget URL

Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6202/#review9701
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Dumont


On Aug. 1, 2012, 7:41 a.m., Marshall Shi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6202/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 7:41 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> Currently, when you specify wrong gadget URL - in SystemOut.log you would get:
> 
> [5/1/12 16:53:33:409 IST] 0000005e AbstractSpecF I org.apache.shindig.gadgets.AbstractSpecFactory SpecUpdater An error occurred when updating XXXXX. A cached version is being used instead.
> 
> It should report 404 code in that error message, with the exception message, and also the message is warning level not info level. 
> 
> 
> This addresses bug shindig-1832.
>     https://issues.apache.org/jira/browse/shindig-1832
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties 1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties 1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1362303 
> 
> Diff: https://reviews.apache.org/r/6202/diff/
> 
> 
> Testing
> -------
> 
> Fixed a compile error of Anonymous security token as well.
> 
> 
> Thanks,
> 
> Marshall Shi
> 
>

Re: Review Request: Absence of an error code in case of wrong gadget URL

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6202/#review9685
-----------------------------------------------------------

Ship it!


Ship It!

- Ryan Baxter


On Aug. 1, 2012, 7:41 a.m., Marshall Shi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6202/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 7:41 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> Currently, when you specify wrong gadget URL - in SystemOut.log you would get:
> 
> [5/1/12 16:53:33:409 IST] 0000005e AbstractSpecF I org.apache.shindig.gadgets.AbstractSpecFactory SpecUpdater An error occurred when updating XXXXX. A cached version is being used instead.
> 
> It should report 404 code in that error message, with the exception message, and also the message is warning level not info level. 
> 
> 
> This addresses bug shindig-1832.
>     https://issues.apache.org/jira/browse/shindig-1832
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties 1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties 1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1362303 
> 
> Diff: https://reviews.apache.org/r/6202/diff/
> 
> 
> Testing
> -------
> 
> Fixed a compile error of Anonymous security token as well.
> 
> 
> Thanks,
> 
> Marshall Shi
> 
>

Re: Review Request: Absence of an error code in case of wrong gadget URL

Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6202/#review9982
-----------------------------------------------------------

Ship it!


Committed r1370424 with minor tweaks to some whitespace and long lines.  Please close the review.


- Dan Dumont


On Aug. 1, 2012, 7:41 a.m., Marshall Shi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6202/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 7:41 a.m.)
> 
> 
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
> 
> 
> Description
> -------
> 
> Currently, when you specify wrong gadget URL - in SystemOut.log you would get:
> 
> [5/1/12 16:53:33:409 IST] 0000005e AbstractSpecF I org.apache.shindig.gadgets.AbstractSpecFactory SpecUpdater An error occurred when updating XXXXX. A cached version is being used instead.
> 
> It should report 404 code in that error message, with the exception message, and also the message is warning level not info level. 
> 
> 
> This addresses bug shindig-1832.
>     https://issues.apache.org/jira/browse/shindig-1832
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties 1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties 1351249 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1362303 
> 
> Diff: https://reviews.apache.org/r/6202/diff/
> 
> 
> Testing
> -------
> 
> Fixed a compile error of Anonymous security token as well.
> 
> 
> Thanks,
> 
> Marshall Shi
> 
>