You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/04 11:41:55 UTC
[GitHub] [kylin] yanghua commented on a change in pull request #1596: [KYLIN-4780] support dingtalk notify
yanghua commented on a change in pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#discussion_r587396384
##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -933,7 +933,7 @@ public String getHiveDependencyFilterList() {
+ "[^,]*hive-metastore[^,]*?\\.jar" + "|" + "[^,]*hive-hcatalog-core[^,]*?\\.jar");
}
- public boolean isMailEnabled() {
+ public boolean isNotifyEnabled() {
Review comment:
IMO, `isNotificationEnabled` looks better?
##########
File path: core-common/src/main/java/org/apache/kylin/common/notify/MailService.java
##########
@@ -40,8 +42,9 @@
private String password;
private String sender;
+
Review comment:
Revert these changes.
##########
File path: core-common/src/main/java/org/apache/kylin/common/notify/MailService.java
##########
@@ -6,30 +6,32 @@
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
- *
Review comment:
Please do not change the unnecessary lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org