[jira] [Commented] (MBUILDCACHE-71) buildinfo.xml should be stored after storing the project's artifacts

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MBUILDCACHE-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835163#comment-17835163 ] 

ASF GitHub Bot commented on MBUILDCACHE-71:
-------------------------------------------

amirhadadi commented on PR #138:
URL: https://github.com/apache/maven-build-cache-extension/pull/138#issuecomment-2044228334

   @olamy would it be possible to create a new release?




> buildinfo.xml should be stored after storing the project's artifacts
> --------------------------------------------------------------------
>
>                 Key: MBUILDCACHE-71
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-71
>             Project: Maven Build Cache Extension
>          Issue Type: Improvement
>    Affects Versions: 1.0.1
>            Reporter: Amir Hadadi
>            Assignee: Olivier Lamy
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.2.0
>
>
> In certain failure cases it's possible that only part of a module artifacts get stored in the local and remote storage. In that case if buildinfo.xml got stored, the extension will later incorrectly attempt to restore the partially cached build.
> Because buildinfo.xml is used as an indication that the cached artifacts exist, I propose to reorder the logic in 
> {code:java}
> CacheControllerImpl.save(){code}
>  so that 
> {code:java}
> localCache.saveBuildInfo(cacheResult, build);{code}
> will happen after the project's artifacts are stored.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)