You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wzhfy <gi...@git.apache.org> on 2017/03/11 03:11:35 UTC

[GitHub] spark issue #17240: [SPARK-19915][SQL] Improve join reorder: simplify cost e...

Github user wzhfy commented on the issue:

    https://github.com/apache/spark/pull/17240
  
    @hvanhovell why simplifying the cost function:
    1. Simplify cost by removing size, then we don't have to care about column pruning while building new join nodes,  because otherwise columm pruning will influence the size of intermediate output and thus the cost of plan. This makes the code much conciser. And I think ordering join first and then pruning columns is easier and more natural.
    2. Cardinality is often much more important than size in join reorder. BTW, Postgresql also uses cardinality (and physical costs) in join reorder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org