You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ma...@apache.org on 2015/11/26 00:45:58 UTC
incubator-reef git commit: [REEF-858] Enable
StyleCop.CSharp.MaintainabilityRules and fix violations
Repository: incubator-reef
Updated Branches:
refs/heads/master 56287fc8a -> dc5efb9ad
[REEF-858] Enable StyleCop.CSharp.MaintainabilityRules and fix violations
This enables the followings MaintainablilityRules and fixes their violations:
* CodeAnalysisSuppressionMustHaveJustification
* DebugAssertMustProvideMessageText
* DebugFailMustProvideMessageText
* FileMayOnlyContainASingleNamespace
* StatementMustNotUseUnnecessaryParenthesis
* ArithmeticExpressionsMustDeclarePrecedence
* ConditionalExpressionsMustDeclarePrecedence
* RemoveDelegateParenthesisWhenPossible
* AttributeConstructorMustNotUseUnnecessaryParenthesis
* RemoveUnnecessaryCode
JIRA:
[REEF-858](https://issues.apache.org/jira/browse/REEF-858)
Pull Request:
This closes #673
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/dc5efb9a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/dc5efb9a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/dc5efb9a
Branch: refs/heads/master
Commit: dc5efb9ad9fb47ffa2c6943e60b56b22200bd5bc
Parents: 56287fc
Author: Dongjoon Hyun <do...@apache.org>
Authored: Sat Nov 21 23:27:57 2015 +0900
Committer: Mariia Mykhailova <ma...@apache.org>
Committed: Wed Nov 25 15:44:35 2015 -0800
----------------------------------------------------------------------
.../Common/JobSubmissionResult.cs | 4 ++--
.../Runtime/Evaluator/Context/ContextManager.cs | 2 +-
.../Evaluator/EvaluatorDescriptorImpl.cs | 2 +-
.../DriverRestart/HelloRestartDriver.cs | 2 +-
.../MachineLearning/KMeans/PartialMean.cs | 2 +-
.../InProcess/IMRURunner.cs | 2 +-
.../InProcess/InProcessIMRUClient.cs | 2 +-
.../Random/RandomInputPartition.cs | 6 +++---
.../Run.cs | 2 +-
.../GroupCommunicationTests.cs | 2 +-
.../NamedParameterConstructors.cs | 2 +-
.../ClassHierarchy/TestAvroSerialization.cs | 4 ++--
.../ClassHierarchy/TestClassHierarchy.cs | 4 ++--
.../ClassHierarchy/TestSerilization.cs | 4 ++--
.../Format/TestConfigurationModule.cs | 4 ++--
.../Format/TestConfigurationModuleForList.cs | 2 +-
.../Injection/TestForkInjection.cs | 4 ++--
.../Injection/TestInjection.cs | 4 ++--
.../Injection/TestSetInjection.cs | 2 +-
.../ScenarioTest/JettyHandler.cs | 2 +-
.../SmokeTest/TestConfigurationModuleBuilder.cs | 14 +++++++-------
.../Tang/TestExternalConstructors.cs | 2 +-
.../Tang/TestLegacyConstructors.cs | 2 +-
.../Org.Apache.REEF.Tang.Tests/Tang/TestTang.cs | 14 +++++++-------
.../ClassHierarchy/NodeFactory.cs | 2 +-
.../Configuration/ConfigurationBuilderImpl.cs | 6 +++---
.../Configuration/Configurations.cs | 2 +-
.../InjectionPlan/InjectorImpl.cs | 4 ++--
.../Util/AbstractMonotonicMultiMap.cs | 2 +-
.../Functional/Bridge/TestBridgeClient.cs | 2 +-
.../Bridge/TestSimpleEventHandlers.cs | 2 +-
.../Functional/Driver/TestDriver.cs | 2 +-
.../Functional/ML/KMeans/TestKMeans.cs | 2 +-
.../Functional/Messaging/TestTaskMessage.cs | 2 +-
.../Diagnostics/Exceptions.cs | 4 ++--
lang/cs/Org.Apache.REEF.Utilities/Optional.cs | 2 +-
.../Remote/Impl/DefaultRemoteMessage.cs | 2 +-
.../Remote/Impl/StreamDataReader.cs | 2 +-
.../Util/FixedThreadPoolTaskService.cs | 6 +++---
lang/cs/Settings.StyleCop | 20 ++++++++++----------
40 files changed, 76 insertions(+), 76 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Client/Common/JobSubmissionResult.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Client/Common/JobSubmissionResult.cs b/lang/cs/Org.Apache.REEF.Client/Common/JobSubmissionResult.cs
index 45ff252..114d0cd 100644
--- a/lang/cs/Org.Apache.REEF.Client/Common/JobSubmissionResult.cs
+++ b/lang/cs/Org.Apache.REEF.Client/Common/JobSubmissionResult.cs
@@ -151,8 +151,8 @@ namespace Org.Apache.REEF.Client.Common
private static bool ShouldRetry(HttpRequestException httpRequestException)
{
var shouldRetry = false;
- if (httpRequestException.Message.IndexOf(((int)(HttpStatusCode.NotFound)).ToString(), StringComparison.Ordinal) != -1 ||
- httpRequestException.Message.IndexOf(((int)(HttpStatusCode.BadGateway)).ToString(), StringComparison.Ordinal) != -1)
+ if (httpRequestException.Message.IndexOf(((int)HttpStatusCode.NotFound).ToString(), StringComparison.Ordinal) != -1 ||
+ httpRequestException.Message.IndexOf(((int)HttpStatusCode.BadGateway).ToString(), StringComparison.Ordinal) != -1)
{
shouldRetry = true;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/Context/ContextManager.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/Context/ContextManager.cs b/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/Context/ContextManager.cs
index 47301aa..ac27723 100644
--- a/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/Context/ContextManager.cs
+++ b/lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/Context/ContextManager.cs
@@ -81,7 +81,7 @@ namespace Org.Apache.REEF.Common.Runtime.Evaluator.Context
{
lock (_contextStack)
{
- return (_contextStack.Count == 0);
+ return _contextStack.Count == 0;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Driver/Evaluator/EvaluatorDescriptorImpl.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Evaluator/EvaluatorDescriptorImpl.cs b/lang/cs/Org.Apache.REEF.Driver/Evaluator/EvaluatorDescriptorImpl.cs
index 0ddee20..9d86cb3 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Evaluator/EvaluatorDescriptorImpl.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Evaluator/EvaluatorDescriptorImpl.cs
@@ -160,7 +160,7 @@ namespace Org.Apache.REEF.Driver.Evaluator
: ClrHandlerHelper.MemoryGranularity;
var m1 = (Memory - 1) / granularity;
var m2 = (other.Memory - 1) / granularity;
- return (m1 == m2);
+ return m1 == m2;
}
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Examples/DriverRestart/HelloRestartDriver.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Examples/DriverRestart/HelloRestartDriver.cs b/lang/cs/Org.Apache.REEF.Examples/DriverRestart/HelloRestartDriver.cs
index 2ad662a..16fa0d3 100644
--- a/lang/cs/Org.Apache.REEF.Examples/DriverRestart/HelloRestartDriver.cs
+++ b/lang/cs/Org.Apache.REEF.Examples/DriverRestart/HelloRestartDriver.cs
@@ -176,7 +176,7 @@ namespace Org.Apache.REEF.Examples.DriverRestart
public void OnNext(IDriverRestartCompleted value)
{
- var timedOutStr = (value.IsTimedOut ? " due to timeout" : string.Empty);
+ var timedOutStr = value.IsTimedOut ? " due to timeout" : string.Empty;
Logger.Log(Level.Info, "Driver restart has completed" + timedOutStr + ".");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/PartialMean.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/PartialMean.cs b/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/PartialMean.cs
index 3a6ece0..26075b5 100644
--- a/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/PartialMean.cs
+++ b/lang/cs/Org.Apache.REEF.Examples/MachineLearning/KMeans/PartialMean.cs
@@ -117,7 +117,7 @@ namespace Org.Apache.REEF.Examples.MachineLearning.KMeans
throw new ArgumentException("cannot combine partial means with different labels");
}
aggreatedMean.Size = Size + other.Size;
- aggreatedMean.Mean = (Mean.MultiplyScalar(Size).Add(other.Mean.MultiplyScalar(other.Size))).Normalize(aggreatedMean.Size);
+ aggreatedMean.Mean = Mean.MultiplyScalar(Size).Add(other.Mean.MultiplyScalar(other.Size)).Normalize(aggreatedMean.Size);
return aggreatedMean;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.IMRU/InProcess/IMRURunner.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IMRU/InProcess/IMRURunner.cs b/lang/cs/Org.Apache.REEF.IMRU/InProcess/IMRURunner.cs
index d7ca55d..20d6930 100644
--- a/lang/cs/Org.Apache.REEF.IMRU/InProcess/IMRURunner.cs
+++ b/lang/cs/Org.Apache.REEF.IMRU/InProcess/IMRURunner.cs
@@ -68,7 +68,7 @@ namespace Org.Apache.REEF.IMRU.InProcess
results.Add(updateResult.Result);
}
- Debug.Assert(updateResult.HasMapInput);
+ Debug.Assert(updateResult.HasMapInput, "MapInput is needed.");
var mapinput = updateResult.MapInput;
var mapOutputs = new List<TMapOutput>();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs b/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
index 844c00a..5ad89f5 100644
--- a/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
+++ b/lang/cs/Org.Apache.REEF.IMRU/InProcess/InProcessIMRUClient.cs
@@ -56,7 +56,7 @@ namespace Org.Apache.REEF.IMRU.InProcess
[Inject]
private InProcessIMRUClient([Parameter(typeof(NumberOfMappers))] int numberOfMappers)
{
- Debug.Assert(numberOfMappers > 0);
+ Debug.Assert(numberOfMappers > 0, "Number of mappers should be greater than zero.");
_numberOfMappers = numberOfMappers;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomInputPartition.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomInputPartition.cs b/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomInputPartition.cs
index 9583529..7b0e0f3 100644
--- a/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomInputPartition.cs
+++ b/lang/cs/Org.Apache.REEF.IO/PartitionedData/Random/RandomInputPartition.cs
@@ -45,11 +45,11 @@ namespace Org.Apache.REEF.IO.PartitionedData.Random
{
var randomDouble = random.NextDouble();
var randomDoubleAsBytes = BitConverter.GetBytes(randomDouble);
- Debug.Assert(randomDoubleAsBytes.Length == 8);
+ Debug.Assert(randomDoubleAsBytes.Length == 8, "randomDoubleAsBytes.Length should be 8.");
for (var j = 0; j < 8; ++j)
{
- var index = i * 8 + j;
- Debug.Assert(index < _randomData.Length);
+ var index = (i * 8) + j;
+ Debug.Assert(index < _randomData.Length, "Index should be less than _randomData.Length.");
_randomData[index] = randomDoubleAsBytes[j];
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Network.Examples.Client/Run.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Network.Examples.Client/Run.cs b/lang/cs/Org.Apache.REEF.Network.Examples.Client/Run.cs
index 639335b..8218aa7 100644
--- a/lang/cs/Org.Apache.REEF.Network.Examples.Client/Run.cs
+++ b/lang/cs/Org.Apache.REEF.Network.Examples.Client/Run.cs
@@ -26,7 +26,7 @@ namespace Org.Apache.REEF.Network.Examples.Client
{
public class Run
{
- static void Main(string[] args)
+ public static void Main(string[] args)
{
Console.WriteLine("start running client: " + DateTime.Now);
bool runOnYarn = false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs b/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs
index f726402..ce48343 100644
--- a/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs
+++ b/lang/cs/Org.Apache.REEF.Network.Tests/GroupCommunication/GroupCommunicationTests.cs
@@ -830,7 +830,7 @@ namespace Org.Apache.REEF.Network.Tests.GroupCommunication
.BindNamedParameter(typeof(NamingConfigurationOptions.NameServerPort),
nameServerEndpoint.Port.ToString())
.BindNamedParameter(typeof(NetworkServiceOptions.NetworkServicePort),
- (0).ToString(CultureInfo.InvariantCulture))
+ 0.ToString(CultureInfo.InvariantCulture))
.BindImplementation(GenericType<INameClient>.Class, GenericType<NameClient>.Class)
.Build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Examples/NamedParameterConstructors.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Examples/NamedParameterConstructors.cs b/lang/cs/Org.Apache.REEF.Tang.Examples/NamedParameterConstructors.cs
index e7aeb5a..ef2955c 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Examples/NamedParameterConstructors.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Examples/NamedParameterConstructors.cs
@@ -24,7 +24,7 @@ namespace Org.Apache.REEF.Tang.Examples
{
public class NamedParameterConstructors
{
- [NamedParameter()]
+ [NamedParameter]
public class X : Name<String>
{
};
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestAvroSerialization.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestAvroSerialization.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestAvroSerialization.cs
index ad3d8a8..ea6a112 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestAvroSerialization.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestAvroSerialization.cs
@@ -47,12 +47,12 @@ namespace Org.Apache.REEF.Tang.Tests.ClassHierarchy
{
}
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
}
- [TestCleanup()]
+ [TestCleanup]
public void TestCleanup()
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestClassHierarchy.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestClassHierarchy.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestClassHierarchy.cs
index a543aa5..788d756 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestClassHierarchy.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestClassHierarchy.cs
@@ -37,7 +37,7 @@ namespace Org.Apache.REEF.Tang.Tests.ClassHierarchy
{
public IClassHierarchy ns = null;
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
if (ns == null)
@@ -47,7 +47,7 @@ namespace Org.Apache.REEF.Tang.Tests.ClassHierarchy
}
}
- [TestCleanup()]
+ [TestCleanup]
public void TestCleanup()
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestSerilization.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestSerilization.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestSerilization.cs
index 6d698a0..02aed35 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestSerilization.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/ClassHierarchy/TestSerilization.cs
@@ -50,12 +50,12 @@ namespace Org.Apache.REEF.Tang.Tests.ClassHierarchy
{
}
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
}
- [TestCleanup()]
+ [TestCleanup]
public void TestCleanup()
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModule.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModule.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModule.cs
index dfa6805..15f2d7c 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModule.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModule.cs
@@ -51,12 +51,12 @@ namespace Org.Apache.REEF.Tang.Tests.Format
{
}
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
}
- [TestCleanup()]
+ [TestCleanup]
public void TestCleanup()
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModuleForList.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModuleForList.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModuleForList.cs
index 1132868..d5fb873 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModuleForList.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Format/TestConfigurationModuleForList.cs
@@ -139,7 +139,7 @@ namespace Org.Apache.REEF.Tang.Tests.Format
class ListIntConfigurationModule : ConfigurationModuleBuilder
{
public static readonly ConfigurationModule CONF = new ListIntConfigurationModule()
- .BindList<ListIntName, int>(GenericType<ListIntName>.Class, (new List<string>(new string[] { "1", "2" })))
+ .BindList<ListIntName, int>(GenericType<ListIntName>.Class, new List<string>(new string[] { "1", "2" }))
.Build();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestForkInjection.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestForkInjection.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestForkInjection.cs
index 3b49eab..3a28d66 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestForkInjection.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestForkInjection.cs
@@ -43,12 +43,12 @@ namespace Org.Apache.REEF.Tang.Tests.Injection
{
}
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
}
- [TestCleanup()]
+ [TestCleanup]
public void TestCleanup()
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestInjection.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestInjection.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestInjection.cs
index c87187a..f0cd980 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestInjection.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestInjection.cs
@@ -53,12 +53,12 @@ namespace Org.Apache.REEF.Tang.Tests.Injection
{
}
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
}
- [TestCleanup()]
+ [TestCleanup]
public void TestCleanup()
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestSetInjection.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestSetInjection.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestSetInjection.cs
index 633e20f..a1e92fc 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestSetInjection.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Injection/TestSetInjection.cs
@@ -347,7 +347,7 @@ namespace Org.Apache.REEF.Tang.Tests.Injection
{
}
- [NamedParameter()]
+ [NamedParameter]
public class SetOfNumbersNoDefault : Name<ISet<string>>
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/ScenarioTest/JettyHandler.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/ScenarioTest/JettyHandler.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/ScenarioTest/JettyHandler.cs
index ca663c6..8bd95da 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/ScenarioTest/JettyHandler.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/ScenarioTest/JettyHandler.cs
@@ -22,7 +22,7 @@ using Org.Apache.REEF.Tang.Annotations;
namespace Org.Apache.REEF.Tang.Tests.ScenarioTest
{
- [NamedParameter()]
+ [NamedParameter]
public class HttpEventHandlers : Name<ISet<IHttpHandler>>
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/SmokeTest/TestConfigurationModuleBuilder.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/SmokeTest/TestConfigurationModuleBuilder.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/SmokeTest/TestConfigurationModuleBuilder.cs
index c553fe1..9493c7b 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/SmokeTest/TestConfigurationModuleBuilder.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/SmokeTest/TestConfigurationModuleBuilder.cs
@@ -60,9 +60,9 @@ namespace Org.Apache.REEF.Tang.Tests.SmokeTest
.BindSetEntry<SetOfBaseTypes.Strings, string>(GenericType<SetOfBaseTypes.Strings>.Class, "1")
.BindSetEntry<SetOfBaseTypes.Strings, string>(GenericType<SetOfBaseTypes.Strings>.Class, "2")
.BindSetEntry<SetOfBaseTypes.Strings, string>(GenericType<SetOfBaseTypes.Strings>.Class, "3")
- .BindList<ListOfBaseTypes.Integers, int>(GenericType<ListOfBaseTypes.Integers>.Class, (new List<string>(new string[] { "1", "2", "3" })))
- .BindList<ListOfBaseTypes.Doubles, double>(GenericType<ListOfBaseTypes.Doubles>.Class, (new List<string>(new string[] { "1", "2", "3" })))
- .BindList<ListOfBaseTypes.Strings, string>(GenericType<ListOfBaseTypes.Strings>.Class, (new List<string>(new string[] { "1", "2", "3" })))
+ .BindList<ListOfBaseTypes.Integers, int>(GenericType<ListOfBaseTypes.Integers>.Class, new List<string>(new string[] { "1", "2", "3" }))
+ .BindList<ListOfBaseTypes.Doubles, double>(GenericType<ListOfBaseTypes.Doubles>.Class, new List<string>(new string[] { "1", "2", "3" }))
+ .BindList<ListOfBaseTypes.Strings, string>(GenericType<ListOfBaseTypes.Strings>.Class, new List<string>(new string[] { "1", "2", "3" }))
.Build();
}
}
@@ -77,22 +77,22 @@ namespace Org.Apache.REEF.Tang.Tests.SmokeTest
{
}
- [NamedParameter()]
+ [NamedParameter]
public class NamedParameterDouble : Name<double>
{
}
- [NamedParameter()]
+ [NamedParameter]
public class IntegerHandler : Name<IHandler<int>>
{
}
- [NamedParameter()]
+ [NamedParameter]
public class StringHandler : Name<IHandler<string>>
{
}
- [NamedParameter()]
+ [NamedParameter]
public class NamedParameterInteger : Name<int>
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestExternalConstructors.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestExternalConstructors.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestExternalConstructors.cs
index d1abe31..6e8f4a0 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestExternalConstructors.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestExternalConstructors.cs
@@ -30,7 +30,7 @@ namespace Org.Apache.REEF.Tang.Tests.Tang
{
static ITang tang;
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
tang = TangFactory.GetTang();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestLegacyConstructors.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestLegacyConstructors.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestLegacyConstructors.cs
index bbadb8a..ab6f7d0 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestLegacyConstructors.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestLegacyConstructors.cs
@@ -30,7 +30,7 @@ namespace Org.Apache.REEF.Tang.Tests.Tang
{
static ITang tang;
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
tang = TangFactory.GetTang();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestTang.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestTang.cs b/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestTang.cs
index c0b7a39..e749380 100644
--- a/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestTang.cs
+++ b/lang/cs/Org.Apache.REEF.Tang.Tests/Tang/TestTang.cs
@@ -50,14 +50,14 @@ namespace Org.Apache.REEF.Tang.Tests.Tang
{
}
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
MustBeSingleton.alreadyInstantiated = false;
tang = TangFactory.GetTang();
}
- [TestCleanup()]
+ [TestCleanup]
public void TestCleanup()
{
}
@@ -615,7 +615,7 @@ namespace Org.Apache.REEF.Tang.Tests.Tang
{
}
- [NamedParameter()]
+ [NamedParameter]
public class B : Name<Int32>
{
}
@@ -628,12 +628,12 @@ namespace Org.Apache.REEF.Tang.Tests.Tang
internal class RepeatedNamedSingletonArgs
{
- [NamedParameter()]
+ [NamedParameter]
public class A : Name<MustBeSingleton>
{
}
- [NamedParameter()]
+ [NamedParameter]
public class B : Name<MustBeSingleton>
{
}
@@ -647,12 +647,12 @@ namespace Org.Apache.REEF.Tang.Tests.Tang
internal class OneNamedSingletonArgs
{
- [NamedParameter()]
+ [NamedParameter]
public class A : Name<MustBeSingleton>
{
}
- [NamedParameter()]
+ [NamedParameter]
public class B : Name<MustBeSingleton>
{
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang/Implementations/ClassHierarchy/NodeFactory.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang/Implementations/ClassHierarchy/NodeFactory.cs b/lang/cs/Org.Apache.REEF.Tang/Implementations/ClassHierarchy/NodeFactory.cs
index b3810b3..bfb2a79 100644
--- a/lang/cs/Org.Apache.REEF.Tang/Implementations/ClassHierarchy/NodeFactory.cs
+++ b/lang/cs/Org.Apache.REEF.Tang/Implementations/ClassHierarchy/NodeFactory.cs
@@ -305,7 +305,7 @@ namespace Org.Apache.REEF.Tang.Implementations.ClassHierarchy
isSubclass = true;
}
}
- if (!(isSubclass))
+ if (!isSubclass)
{
var e = new ClassHierarchyException(namedparameter + " defines a default class "
+ ReflectionUtilities.GetName(defaultclass) + " with a type that does not extend of its target's type " + argClass);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/ConfigurationBuilderImpl.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/ConfigurationBuilderImpl.cs b/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/ConfigurationBuilderImpl.cs
index 8bb1a02..e64118e 100644
--- a/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/ConfigurationBuilderImpl.cs
+++ b/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/ConfigurationBuilderImpl.cs
@@ -61,7 +61,7 @@ namespace Org.Apache.REEF.Tang.Implementations.Configuration
this.ClassHierarchy = TangFactory.GetTang().GetDefaultClassHierarchy(assemblies, parsers);
foreach (IConfiguration tc in confs)
{
- AddConfiguration(((ConfigurationImpl)tc));
+ AddConfiguration((ConfigurationImpl)tc);
}
}
@@ -95,9 +95,9 @@ namespace Org.Apache.REEF.Tang.Implementations.Configuration
{
this.ClassHierarchy = this.ClassHierarchy.Merge(ns);
- if ((ClassHierarchy is ClassHierarchyImpl || builder.ClassHierarchy is ClassHierarchyImpl))
+ if (ClassHierarchy is ClassHierarchyImpl || builder.ClassHierarchy is ClassHierarchyImpl)
{
- if ((ClassHierarchy is ClassHierarchyImpl && builder.ClassHierarchy is ClassHierarchyImpl))
+ if (ClassHierarchy is ClassHierarchyImpl && builder.ClassHierarchy is ClassHierarchyImpl)
{
((ClassHierarchyImpl)ClassHierarchy).Parameterparser.MergeIn(((ClassHierarchyImpl)builder.ClassHierarchy).Parameterparser);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/Configurations.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/Configurations.cs b/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/Configurations.cs
index 1c27d21..ada0793 100644
--- a/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/Configurations.cs
+++ b/lang/cs/Org.Apache.REEF.Tang/Implementations/Configuration/Configurations.cs
@@ -47,7 +47,7 @@ namespace Org.Apache.REEF.Tang.Implementations.Configuration
foreach (IConfiguration tc in configurations)
{
- cb.AddConfiguration(((ConfigurationImpl)tc));
+ cb.AddConfiguration((ConfigurationImpl)tc);
}
return cb.Build();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang/Implementations/InjectionPlan/InjectorImpl.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang/Implementations/InjectionPlan/InjectorImpl.cs b/lang/cs/Org.Apache.REEF.Tang/Implementations/InjectionPlan/InjectorImpl.cs
index cfd179e..30c9cdf 100644
--- a/lang/cs/Org.Apache.REEF.Tang/Implementations/InjectionPlan/InjectorImpl.cs
+++ b/lang/cs/Org.Apache.REEF.Tang/Implementations/InjectionPlan/InjectorImpl.cs
@@ -596,8 +596,8 @@ namespace Org.Apache.REEF.Tang.Implementations.InjectionPlan
{
for (int j = i + 1; j < liveIndices.Count; j++)
{
- IConstructorDef ci = ((Constructor)constructors[(liveIndices[i])]).GetConstructorDef();
- IConstructorDef cj = ((Constructor)constructors[(liveIndices[j])]).GetConstructorDef();
+ IConstructorDef ci = ((Constructor)constructors[liveIndices[i]]).GetConstructorDef();
+ IConstructorDef cj = ((Constructor)constructors[liveIndices[j]]).GetConstructorDef();
if (ci.IsMoreSpecificThan(cj)) // ci's arguments is a superset of cj's
{
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tang/Util/AbstractMonotonicMultiMap.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tang/Util/AbstractMonotonicMultiMap.cs b/lang/cs/Org.Apache.REEF.Tang/Util/AbstractMonotonicMultiMap.cs
index 0a525eb..d5e167a 100644
--- a/lang/cs/Org.Apache.REEF.Tang/Util/AbstractMonotonicMultiMap.cs
+++ b/lang/cs/Org.Apache.REEF.Tang/Util/AbstractMonotonicMultiMap.cs
@@ -205,7 +205,7 @@ namespace Org.Apache.REEF.Tang.Util
{
if (map.ContainsKey(k))
{
- return (GetValuesForKey(k).Count != 0);
+ return GetValuesForKey(k).Count != 0;
}
return false;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestBridgeClient.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestBridgeClient.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestBridgeClient.cs
index b520b5d..97529b0 100644
--- a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestBridgeClient.cs
+++ b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestBridgeClient.cs
@@ -30,7 +30,7 @@ namespace Org.Apache.REEF.Tests.Functional.Bridge
{
private static readonly Logger LOGGER = Logger.GetLogger(typeof(TestBridgeClient));
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
Init();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestSimpleEventHandlers.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestSimpleEventHandlers.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestSimpleEventHandlers.cs
index 8b3207c..ec7c0b2 100644
--- a/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestSimpleEventHandlers.cs
+++ b/lang/cs/Org.Apache.REEF.Tests/Functional/Bridge/TestSimpleEventHandlers.cs
@@ -36,7 +36,7 @@ namespace Org.Apache.REEF.Tests.Functional.Bridge
[TestClass]
public class TestSimpleEventHandlers : ReefFunctionalTest
{
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
Init();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tests/Functional/Driver/TestDriver.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/Driver/TestDriver.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/Driver/TestDriver.cs
index 8af9d6f..35c04b7 100644
--- a/lang/cs/Org.Apache.REEF.Tests/Functional/Driver/TestDriver.cs
+++ b/lang/cs/Org.Apache.REEF.Tests/Functional/Driver/TestDriver.cs
@@ -31,7 +31,7 @@ namespace Org.Apache.REEF.Tests.Functional.Driver
[TestClass]
public class TestDriver : ReefFunctionalTest
{
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
CleanUp();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
index 9045e6a..d0a8199 100644
--- a/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
+++ b/lang/cs/Org.Apache.REEF.Tests/Functional/ML/KMeans/TestKMeans.cs
@@ -48,7 +48,7 @@ namespace Org.Apache.REEF.Tests.Functional.ML.KMeans
private readonly bool _useSmallDataSet = false;
private string _dataFile = MouseDataFile;
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
if (_useSmallDataSet)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Tests/Functional/Messaging/TestTaskMessage.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Tests/Functional/Messaging/TestTaskMessage.cs b/lang/cs/Org.Apache.REEF.Tests/Functional/Messaging/TestTaskMessage.cs
index 154fb8e..5fa24bc 100644
--- a/lang/cs/Org.Apache.REEF.Tests/Functional/Messaging/TestTaskMessage.cs
+++ b/lang/cs/Org.Apache.REEF.Tests/Functional/Messaging/TestTaskMessage.cs
@@ -33,7 +33,7 @@ namespace Org.Apache.REEF.Tests.Functional.Messaging
[TestClass]
public class TestTaskMessage : ReefFunctionalTest
{
- [TestInitialize()]
+ [TestInitialize]
public void TestSetup()
{
CleanUp();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs b/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
index 2332bd3..627f239 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/Diagnostics/Exceptions.cs
@@ -182,8 +182,8 @@ namespace Org.Apache.REEF.Utilities.Diagnostics
/// <returns>True if the exceptions is critical one and should not be caught and false otherwise.</returns>
public static bool MustRethrow(Exception exception)
{
- return (exception is OutOfMemoryException ||
- exception is StackOverflowException);
+ return exception is OutOfMemoryException ||
+ exception is StackOverflowException;
}
/// <summary>
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Utilities/Optional.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/Optional.cs b/lang/cs/Org.Apache.REEF.Utilities/Optional.cs
index 11d95fa..d283815 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/Optional.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/Optional.cs
@@ -82,7 +82,7 @@ namespace Org.Apache.REEF.Utilities
public bool IsPresent()
{
- return (_value != null);
+ return _value != null;
}
public override bool Equals(object obj)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/DefaultRemoteMessage.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/DefaultRemoteMessage.cs b/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/DefaultRemoteMessage.cs
index 225db30..2b8c214 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/DefaultRemoteMessage.cs
+++ b/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/DefaultRemoteMessage.cs
@@ -19,7 +19,7 @@
namespace Org.Apache.REEF.Wake.Remote.Impl
{
- class DefaultRemoteMessage<T> : IRemoteMessage<T>
+ internal class DefaultRemoteMessage<T> : IRemoteMessage<T>
{
public DefaultRemoteMessage(IRemoteIdentifier id, T message)
{
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/StreamDataReader.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/StreamDataReader.cs b/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/StreamDataReader.cs
index 5a3c6c2..8fb2b46 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/StreamDataReader.cs
+++ b/lang/cs/Org.Apache.REEF.Wake/Remote/Impl/StreamDataReader.cs
@@ -31,7 +31,7 @@ namespace Org.Apache.REEF.Wake.Remote.Impl
/// </summary>
public class StreamDataReader : IDataReader
{
- Logger Logger = Logger.GetLogger(typeof(StreamDataReader));
+ private static readonly Logger Logger = Logger.GetLogger(typeof(StreamDataReader));
/// <summary>
/// Stream from which to read
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Org.Apache.REEF.Wake/Util/FixedThreadPoolTaskService.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Wake/Util/FixedThreadPoolTaskService.cs b/lang/cs/Org.Apache.REEF.Wake/Util/FixedThreadPoolTaskService.cs
index f797858..a79d543 100644
--- a/lang/cs/Org.Apache.REEF.Wake/Util/FixedThreadPoolTaskService.cs
+++ b/lang/cs/Org.Apache.REEF.Wake/Util/FixedThreadPoolTaskService.cs
@@ -30,10 +30,10 @@ namespace Org.Apache.REEF.Wake.Util
{
private static readonly Logger LOGGER = Logger.GetLogger(typeof(FixedThreadPoolTaskService));
- readonly TaskFactory factory;
+ private readonly TaskFactory factory;
- readonly List<Task> tasks = new List<Task>();
- bool shuttingDown;
+ private readonly List<Task> tasks = new List<Task>();
+ private bool shuttingDown;
internal FixedThreadPoolTaskService(int maxDegreeOfParallelism)
{
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/dc5efb9a/lang/cs/Settings.StyleCop
----------------------------------------------------------------------
diff --git a/lang/cs/Settings.StyleCop b/lang/cs/Settings.StyleCop
index a1f105d..a1cb243 100644
--- a/lang/cs/Settings.StyleCop
+++ b/lang/cs/Settings.StyleCop
@@ -347,17 +347,17 @@ under the License.
</Rule>
<Rule Name="CodeAnalysisSuppressionMustHaveJustification">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="DebugAssertMustProvideMessageText">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="DebugFailMustProvideMessageText">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="FileMayOnlyContainASingleClass">
@@ -367,37 +367,37 @@ under the License.
</Rule>
<Rule Name="FileMayOnlyContainASingleNamespace">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="StatementMustNotUseUnnecessaryParenthesis">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="ArithmeticExpressionsMustDeclarePrecedence">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="ConditionalExpressionsMustDeclarePrecedence">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="RemoveDelegateParenthesisWhenPossible">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="AttributeConstructorMustNotUseUnnecessaryParenthesis">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
<Rule Name="RemoveUnnecessaryCode">
<RuleSettings>
- <BooleanProperty Name="Enabled">False</BooleanProperty>
+ <BooleanProperty Name="Enabled">True</BooleanProperty>
</RuleSettings>
</Rule>
</Rules>