You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "daeho-ro (via GitHub)" <gi...@apache.org> on 2026/09/25 13:23:06 UTC

[PR] fix(cmake): allow linking a shared flatccrt [arrow-nanoarrow]

daeho-ro opened a new pull request, #949:
URL: https://github.com/apache/arrow-nanoarrow/pull/949

   When flatcc is provided via NANOARROW_FLATCC_ROOT_DIR or NANOARROW_FLATCC_LIB_DIR, prefer a static flatccrt as before but fall back to a shared one when no static library is available.
   
   Closes #922.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: allow linking a shared flatccrt [arrow-nanoarrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #949:
URL: https://github.com/apache/arrow-nanoarrow/pull/949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(cmake): allow linking a shared flatccrt [arrow-nanoarrow]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #949:
URL: https://github.com/apache/arrow-nanoarrow/pull/949#issuecomment-5833857044

   ## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/949?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 78.19%. Comparing base ([`ec8a58c`](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/ec8a58cae18beaa241c7fea7cb26816ac27c280f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4c8bedd`](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/4c8bedd1db791914068cb19e17a98c5e6ef70582?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##             main     #949   +/-   ##
   =======================================
     Coverage   78.19%   78.19%           
   =======================================
     Files         106      106           
     Lines       16843    16843           
     Branches     1985     1985           
   =======================================
     Hits        13170    13170           
     Misses       2439     2439           
     Partials     1234     1234           
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/949?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org