You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/10 09:49:38 UTC
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI
martinzink opened a new pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI
Posted by GitBox <gi...@apache.org>.
martinzink commented on a change in pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000#discussion_r573643357
##########
File path: extensions/http-curl/tests/ThreadPoolAdjust.cpp
##########
@@ -31,9 +31,11 @@
#include "processors/LogAttribute.h"
#include "utils/IntegrationTestUtils.h"
+constexpr uint64_t INCREASED_WAITTIME_MSECS = DEFAULT_WAITTIME_MSECS * 1.5;
+
class HttpTestHarness : public IntegrationBase {
public:
- HttpTestHarness() {
+ HttpTestHarness() : IntegrationBase(INCREASED_WAITTIME_MSECS) {
Review comment:
Changed it to be hard-coded 5000 ms, instead of the previously calculated 4500 ms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI
Posted by GitBox <gi...@apache.org>.
martinzink commented on a change in pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000#discussion_r573587229
##########
File path: extensions/http-curl/tests/ThreadPoolAdjust.cpp
##########
@@ -31,9 +31,11 @@
#include "processors/LogAttribute.h"
#include "utils/IntegrationTestUtils.h"
+constexpr uint64_t INCREASED_WAITTIME_MSECS = DEFAULT_WAITTIME_MSECS * 1.5;
+
class HttpTestHarness : public IntegrationBase {
public:
- HttpTestHarness() {
+ HttpTestHarness() : IntegrationBase(INCREASED_WAITTIME_MSECS) {
Review comment:
Looking at the available logs on github, this issue is fairly regular (happened 7 times in the last 90 days, only on windows)
The strange thing is, usually by the time the assertion message appears the required log lines are already present.
So I suspected that the given wait time for these log messages are too low to be consistent for the windows CI. (I wasn't able to reproduce the issue on my windows machine)
I've tested the fix with a custom CI that's tries to run this test 200 times on windows2017 and windows2019.
Without the fix it wasn't able to run the 200 test run without failure 4 times out of 4. (Failures happened after the 1st, 11th, 12th, 103rd test run)
https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551019180
https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551315036
With the increased wait time it passed 6 times out of 6. (1200 successful test run)
https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551722774
https://github.com/martinzink/nifi-minifi-cpp/actions/runs/552033701
https://github.com/martinzink/nifi-minifi-cpp/actions/runs/552535235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000#discussion_r573610053
##########
File path: extensions/http-curl/tests/ThreadPoolAdjust.cpp
##########
@@ -31,9 +31,11 @@
#include "processors/LogAttribute.h"
#include "utils/IntegrationTestUtils.h"
+constexpr uint64_t INCREASED_WAITTIME_MSECS = DEFAULT_WAITTIME_MSECS * 1.5;
+
class HttpTestHarness : public IntegrationBase {
public:
- HttpTestHarness() {
+ HttpTestHarness() : IntegrationBase(INCREASED_WAITTIME_MSECS) {
Review comment:
I would hard-code the wait time value here instead of defining it as `DEFAULT_WAITTIME_MSECS * 1.5`, because I don't think we want this wait time to change if we change the default later.
Also, since `wait_time_` is only used as a parameter to `verifyLogLinePresenceInPollTime()`, ie. it will stop waiting earlier if the log line is found earlier, we could make it longer, eg. 5 seconds or even 10 seconds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1000: MINIFICPP-1451: ThreadPoolAdjust test transiently failed on Windows CI
Posted by GitBox <gi...@apache.org>.
martinzink commented on a change in pull request #1000:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1000#discussion_r573587229
##########
File path: extensions/http-curl/tests/ThreadPoolAdjust.cpp
##########
@@ -31,9 +31,11 @@
#include "processors/LogAttribute.h"
#include "utils/IntegrationTestUtils.h"
+constexpr uint64_t INCREASED_WAITTIME_MSECS = DEFAULT_WAITTIME_MSECS * 1.5;
+
class HttpTestHarness : public IntegrationBase {
public:
- HttpTestHarness() {
+ HttpTestHarness() : IntegrationBase(INCREASED_WAITTIME_MSECS) {
Review comment:
Looking at the available logs on github, this issue is fairly regular (happened 7 times in the last 90 days, only on windows)
The strange thing is, usually by the time the assertion message appears the required log lines are already present.
So I suspected that the given wait time for these log messages are too low to be consistent for the windows CI. (I wasn't able to reproduce the issue on my windows machine)
I've tested the fix with a custom CI that's tries to run this test 200 times on windows2017 and windows2019.
Without the fix it wasn't able to run the 200 test run without failure 4 times out of 4. (Failures happened after the 1st, 11th, 12th, 103rd test run)
* https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551019180
* https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551315036
With the increased wait time it passed 6 times out of 6. (1200 successful test run)
* https://github.com/martinzink/nifi-minifi-cpp/actions/runs/551722774
* https://github.com/martinzink/nifi-minifi-cpp/actions/runs/552033701
* https://github.com/martinzink/nifi-minifi-cpp/actions/runs/552535235
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org