You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Mark Struberg <st...@yahoo.de.INVALID> on 2018/05/01 09:06:56 UTC

[DISCUSS] run a 2.4.3 release?

Hi folks!

Do we want to release 2.4.3 in the next few days?
I'm currently running all the tests. 

If nobody speaks out against it then I gonna run the release somewhen over the next few days.

txs and LieGrue,
strub

Re: [DISCUSS] run a 2.4.3 release?

Posted by Mark Struberg <st...@yahoo.de.INVALID>.
yes, will tackle in the next few days.

LieGrue,
strub

> Am 15.05.2018 um 07:59 schrieb Francesco Chicchiriccò <il...@apache.org>:
> 
> Hi Mark,
> now that OPENJPA-2646 is solved, would you resume the 2.4.3 release process?
> 
> Regards.
> 
> On 09/05/2018 08:43, Francesco Chicchiriccò wrote:
>> On 08/05/2018 20:52, Mark Struberg wrote:
>>> was just an error between keyboard and chair ;)
>>> 
>>> I found a small local modification on my notebook which caused the glitch.
>>> All works fine now.
>>> 
>>> So wdyt? Run the release or is there anything closing in which we should wait for?
>> 
>> Maybe OPENJPA-2646? (see my comment there).
>> 
>> Thanks for your availability to cut a release!
>> Regards.
>> 
>>>> Am 01.05.2018 um 19:54 schrieb Mark Struberg <st...@yahoo.de.INVALID>:
>>>> 
>>>> We have a few broken tests.
>>>> 
>>>> Failed tests:
>>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectObjectArray:320->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result class java.lang.Object[]
>>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTuple:336->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple
>>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTupleArray:344->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple[]
>>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testUserResultQueryWithExplictProjectionOfConstructorArguments:117->assertResult:405->assertResult:414 class java.lang.String does not match actual result class org.apache.openjpa.persistence.criteria.Person
>>>> Tests in error:
>>>> TestEdit>AbstractCriteriaTestCase.runBare:347->testEditedToAddMultiselectionTerm:139 » IllegalState
>>>> 
>>>> Tests run: 3088, Failures: 4, Errors: 1, Skipped: 0
>>>> 
>>>> 
>>>> So we need to fix those first.
>>>> 
>>>> LieGrue,
>>>> strub
>>>> 
>>>>> Am 01.05.2018 um 12:19 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>>>>> 
>>>>> It is not regressions so guess it is ok
>>>>> 
>>>>> +1
>>>>> 
>>>>> Le 1 mai 2018 11:18, "Jonathan Gallimore" <jo...@gmail.com> a
>>>>> écrit :
>>>>> 
>>>>>> That would be amazing if we could. There were a few issues in JIRA that I
>>>>>> didn't manage to look at that Francesco mentioned:
>>>>>> 
>>>>>> OPENJPA-2581 <https://issues.apache.org/jira/browse/OPENJPA-2581>
>>>>>> openjpa-maven-plugin:
>>>>>> drop and create schema regardless of the current database state
>>>>>> OPENJPA-2691 <https://issues.apache.org/jira/browse/OPENJPA-2691>
>>>>>> OracleDictionary
>>>>>> should use non Deprecated method of empty_lob
>>>>>> OPENJPA-2694 <https://issues.apache.org/jira/browse/OPENJPA-2694> Creating
>>>>>> count(distinct x.field) fails when using CriteriaBuilder
>>>>>> 
>>>>>> Are any of those blockers?
>>>>>> 
>>>>>> Jon
>>>>>> 
>>>>>> On Tue, May 1, 2018 at 10:06 AM, Mark Struberg <st...@yahoo.de.invalid>
>>>>>> wrote:
>>>>>> 
>>>>>>> Hi folks!
>>>>>>> 
>>>>>>> Do we want to release 2.4.3 in the next few days?
>>>>>>> I'm currently running all the tests.
>>>>>>> 
>>>>>>> If nobody speaks out against it then I gonna run the release somewhen
>>>>>> over
>>>>>>> the next few days.
>>>>>>> 
>>>>>>> txs and LieGrue,
>>>>>>> strub
>> 
>> 
> 
> -- 
> Francesco Chicchiriccò
> 
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
> 
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>

Re: [DISCUSS] run a 2.4.3 release?

Posted by Francesco Chicchiriccò <il...@apache.org>.
Hi Mark,
now that OPENJPA-2646 is solved, would you resume the 2.4.3 release process?

Regards.

On 09/05/2018 08:43, Francesco Chicchiriccò wrote:
> On 08/05/2018 20:52, Mark Struberg wrote:
>> was just an error between keyboard and chair ;)
>>
>> I found a small local modification on my notebook which caused the 
>> glitch.
>> All works fine now.
>>
>> So wdyt? Run the release or is there anything closing in which we 
>> should wait for?
>
> Maybe OPENJPA-2646? (see my comment there).
>
> Thanks for your availability to cut a release!
> Regards.
>
>>> Am 01.05.2018 um 19:54 schrieb Mark Struberg 
>>> <st...@yahoo.de.INVALID>:
>>>
>>> We have a few broken tests.
>>>
>>> Failed tests:
>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectObjectArray:320->assertResult:414 
>>> class org.apache.openjpa.persistence.criteria.results.Foo does not 
>>> match actual result class java.lang.Object[]
>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTuple:336->assertResult:414 
>>> class org.apache.openjpa.persistence.criteria.results.Foo does not 
>>> match actual result interface javax.persistence.Tuple
>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTupleArray:344->assertResult:414 
>>> class org.apache.openjpa.persistence.criteria.results.Foo does not 
>>> match actual result interface javax.persistence.Tuple[]
>>> TestMultiselect>AbstractCriteriaTestCase.runBare:347->testUserResultQueryWithExplictProjectionOfConstructorArguments:117->assertResult:405->assertResult:414 
>>> class java.lang.String does not match actual result class 
>>> org.apache.openjpa.persistence.criteria.Person
>>> Tests in error:
>>> TestEdit>AbstractCriteriaTestCase.runBare:347->testEditedToAddMultiselectionTerm:139 
>>> » IllegalState
>>>
>>> Tests run: 3088, Failures: 4, Errors: 1, Skipped: 0
>>>
>>>
>>> So we need to fix those first.
>>>
>>> LieGrue,
>>> strub
>>>
>>>> Am 01.05.2018 um 12:19 schrieb Romain Manni-Bucau 
>>>> <rm...@gmail.com>:
>>>>
>>>> It is not regressions so guess it is ok
>>>>
>>>> +1
>>>>
>>>> Le 1 mai 2018 11:18, "Jonathan Gallimore" 
>>>> <jo...@gmail.com> a
>>>> écrit :
>>>>
>>>>> That would be amazing if we could. There were a few issues in JIRA 
>>>>> that I
>>>>> didn't manage to look at that Francesco mentioned:
>>>>>
>>>>> OPENJPA-2581 <https://issues.apache.org/jira/browse/OPENJPA-2581>
>>>>> openjpa-maven-plugin:
>>>>> drop and create schema regardless of the current database state
>>>>> OPENJPA-2691 <https://issues.apache.org/jira/browse/OPENJPA-2691>
>>>>> OracleDictionary
>>>>> should use non Deprecated method of empty_lob
>>>>> OPENJPA-2694 <https://issues.apache.org/jira/browse/OPENJPA-2694> 
>>>>> Creating
>>>>> count(distinct x.field) fails when using CriteriaBuilder
>>>>>
>>>>> Are any of those blockers?
>>>>>
>>>>> Jon
>>>>>
>>>>> On Tue, May 1, 2018 at 10:06 AM, Mark Struberg 
>>>>> <st...@yahoo.de.invalid>
>>>>> wrote:
>>>>>
>>>>>> Hi folks!
>>>>>>
>>>>>> Do we want to release 2.4.3 in the next few days?
>>>>>> I'm currently running all the tests.
>>>>>>
>>>>>> If nobody speaks out against it then I gonna run the release 
>>>>>> somewhen
>>>>> over
>>>>>> the next few days.
>>>>>>
>>>>>> txs and LieGrue,
>>>>>> strub
>
>

-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] run a 2.4.3 release?

Posted by Francesco Chicchiriccò <il...@apache.org>.
On 08/05/2018 20:52, Mark Struberg wrote:
> was just an error between keyboard and chair ;)
>
> I found a small local modification on my notebook which caused the glitch.
> All works fine now.
>
> So wdyt? Run the release or is there anything closing in which we should wait for?

Maybe OPENJPA-2646? (see my comment there).

Thanks for your availability to cut a release!
Regards.

>> Am 01.05.2018 um 19:54 schrieb Mark Struberg <st...@yahoo.de.INVALID>:
>>
>> We have a few broken tests.
>>
>> Failed tests:
>>   TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectObjectArray:320->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result class java.lang.Object[]
>>   TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTuple:336->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple
>>   TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTupleArray:344->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple[]
>>   TestMultiselect>AbstractCriteriaTestCase.runBare:347->testUserResultQueryWithExplictProjectionOfConstructorArguments:117->assertResult:405->assertResult:414 class java.lang.String does not match actual result class org.apache.openjpa.persistence.criteria.Person
>> Tests in error:
>>   TestEdit>AbstractCriteriaTestCase.runBare:347->testEditedToAddMultiselectionTerm:139 » IllegalState
>>
>> Tests run: 3088, Failures: 4, Errors: 1, Skipped: 0
>>
>>
>> So we need to fix those first.
>>
>> LieGrue,
>> strub
>>
>>> Am 01.05.2018 um 12:19 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>>>
>>> It is not regressions so guess it is ok
>>>
>>> +1
>>>
>>> Le 1 mai 2018 11:18, "Jonathan Gallimore" <jo...@gmail.com> a
>>> écrit :
>>>
>>>> That would be amazing if we could. There were a few issues in JIRA that I
>>>> didn't manage to look at that Francesco mentioned:
>>>>
>>>> OPENJPA-2581 <https://issues.apache.org/jira/browse/OPENJPA-2581>
>>>> openjpa-maven-plugin:
>>>> drop and create schema regardless of the current database state
>>>> OPENJPA-2691 <https://issues.apache.org/jira/browse/OPENJPA-2691>
>>>> OracleDictionary
>>>> should use non Deprecated method of empty_lob
>>>> OPENJPA-2694 <https://issues.apache.org/jira/browse/OPENJPA-2694> Creating
>>>> count(distinct x.field) fails when using CriteriaBuilder
>>>>
>>>> Are any of those blockers?
>>>>
>>>> Jon
>>>>
>>>> On Tue, May 1, 2018 at 10:06 AM, Mark Struberg <st...@yahoo.de.invalid>
>>>> wrote:
>>>>
>>>>> Hi folks!
>>>>>
>>>>> Do we want to release 2.4.3 in the next few days?
>>>>> I'm currently running all the tests.
>>>>>
>>>>> If nobody speaks out against it then I gonna run the release somewhen
>>>> over
>>>>> the next few days.
>>>>>
>>>>> txs and LieGrue,
>>>>> strub


-- 
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

Re: [DISCUSS] run a 2.4.3 release?

Posted by Mark Struberg <st...@yahoo.de.INVALID>.
was just an error between keyboard and chair ;)

I found a small local modification on my notebook which caused the glitch.
All works fine now.

So wdyt? Run the release or is there anything closing in which we should wait for?

LieGrue,
strub


> Am 01.05.2018 um 19:54 schrieb Mark Struberg <st...@yahoo.de.INVALID>:
> 
> We have a few broken tests.
> 
> Failed tests:
>  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectObjectArray:320->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result class java.lang.Object[]
>  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTuple:336->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple
>  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTupleArray:344->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple[]
>  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testUserResultQueryWithExplictProjectionOfConstructorArguments:117->assertResult:405->assertResult:414 class java.lang.String does not match actual result class org.apache.openjpa.persistence.criteria.Person
> Tests in error:
>  TestEdit>AbstractCriteriaTestCase.runBare:347->testEditedToAddMultiselectionTerm:139 » IllegalState
> 
> Tests run: 3088, Failures: 4, Errors: 1, Skipped: 0
> 
> 
> So we need to fix those first.
> 
> LieGrue,
> strub
> 
>> Am 01.05.2018 um 12:19 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>> 
>> It is not regressions so guess it is ok
>> 
>> +1
>> 
>> Le 1 mai 2018 11:18, "Jonathan Gallimore" <jo...@gmail.com> a
>> écrit :
>> 
>>> That would be amazing if we could. There were a few issues in JIRA that I
>>> didn't manage to look at that Francesco mentioned:
>>> 
>>> OPENJPA-2581 <https://issues.apache.org/jira/browse/OPENJPA-2581>
>>> openjpa-maven-plugin:
>>> drop and create schema regardless of the current database state
>>> OPENJPA-2691 <https://issues.apache.org/jira/browse/OPENJPA-2691>
>>> OracleDictionary
>>> should use non Deprecated method of empty_lob
>>> OPENJPA-2694 <https://issues.apache.org/jira/browse/OPENJPA-2694> Creating
>>> count(distinct x.field) fails when using CriteriaBuilder
>>> 
>>> Are any of those blockers?
>>> 
>>> Jon
>>> 
>>> On Tue, May 1, 2018 at 10:06 AM, Mark Struberg <st...@yahoo.de.invalid>
>>> wrote:
>>> 
>>>> Hi folks!
>>>> 
>>>> Do we want to release 2.4.3 in the next few days?
>>>> I'm currently running all the tests.
>>>> 
>>>> If nobody speaks out against it then I gonna run the release somewhen
>>> over
>>>> the next few days.
>>>> 
>>>> txs and LieGrue,
>>>> strub
>>> 
>

Re: [DISCUSS] run a 2.4.3 release?

Posted by Mark Struberg <st...@yahoo.de.INVALID>.
We have a few broken tests.

Failed tests:
  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectObjectArray:320->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result class java.lang.Object[]
  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTuple:336->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple
  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testSelectSingleTermWithMultiselectTupleArray:344->assertResult:414 class org.apache.openjpa.persistence.criteria.results.Foo does not match actual result interface javax.persistence.Tuple[]
  TestMultiselect>AbstractCriteriaTestCase.runBare:347->testUserResultQueryWithExplictProjectionOfConstructorArguments:117->assertResult:405->assertResult:414 class java.lang.String does not match actual result class org.apache.openjpa.persistence.criteria.Person
Tests in error:
  TestEdit>AbstractCriteriaTestCase.runBare:347->testEditedToAddMultiselectionTerm:139 » IllegalState

Tests run: 3088, Failures: 4, Errors: 1, Skipped: 0


So we need to fix those first.

LieGrue,
strub

> Am 01.05.2018 um 12:19 schrieb Romain Manni-Bucau <rm...@gmail.com>:
> 
> It is not regressions so guess it is ok
> 
> +1
> 
> Le 1 mai 2018 11:18, "Jonathan Gallimore" <jo...@gmail.com> a
> écrit :
> 
>> That would be amazing if we could. There were a few issues in JIRA that I
>> didn't manage to look at that Francesco mentioned:
>> 
>> OPENJPA-2581 <https://issues.apache.org/jira/browse/OPENJPA-2581>
>> openjpa-maven-plugin:
>> drop and create schema regardless of the current database state
>> OPENJPA-2691 <https://issues.apache.org/jira/browse/OPENJPA-2691>
>> OracleDictionary
>> should use non Deprecated method of empty_lob
>> OPENJPA-2694 <https://issues.apache.org/jira/browse/OPENJPA-2694> Creating
>> count(distinct x.field) fails when using CriteriaBuilder
>> 
>> Are any of those blockers?
>> 
>> Jon
>> 
>> On Tue, May 1, 2018 at 10:06 AM, Mark Struberg <st...@yahoo.de.invalid>
>> wrote:
>> 
>>> Hi folks!
>>> 
>>> Do we want to release 2.4.3 in the next few days?
>>> I'm currently running all the tests.
>>> 
>>> If nobody speaks out against it then I gonna run the release somewhen
>> over
>>> the next few days.
>>> 
>>> txs and LieGrue,
>>> strub
>>

Re: [DISCUSS] run a 2.4.3 release?

Posted by Romain Manni-Bucau <rm...@gmail.com>.
It is not regressions so guess it is ok

+1

Le 1 mai 2018 11:18, "Jonathan Gallimore" <jo...@gmail.com> a
écrit :

> That would be amazing if we could. There were a few issues in JIRA that I
> didn't manage to look at that Francesco mentioned:
>
> OPENJPA-2581 <https://issues.apache.org/jira/browse/OPENJPA-2581>
> openjpa-maven-plugin:
> drop and create schema regardless of the current database state
> OPENJPA-2691 <https://issues.apache.org/jira/browse/OPENJPA-2691>
> OracleDictionary
> should use non Deprecated method of empty_lob
> OPENJPA-2694 <https://issues.apache.org/jira/browse/OPENJPA-2694> Creating
> count(distinct x.field) fails when using CriteriaBuilder
>
> Are any of those blockers?
>
> Jon
>
> On Tue, May 1, 2018 at 10:06 AM, Mark Struberg <st...@yahoo.de.invalid>
> wrote:
>
> > Hi folks!
> >
> > Do we want to release 2.4.3 in the next few days?
> > I'm currently running all the tests.
> >
> > If nobody speaks out against it then I gonna run the release somewhen
> over
> > the next few days.
> >
> > txs and LieGrue,
> > strub
>

Re: [DISCUSS] run a 2.4.3 release?

Posted by Jonathan Gallimore <jo...@gmail.com>.
That would be amazing if we could. There were a few issues in JIRA that I
didn't manage to look at that Francesco mentioned:

OPENJPA-2581 <https://issues.apache.org/jira/browse/OPENJPA-2581>
openjpa-maven-plugin:
drop and create schema regardless of the current database state
OPENJPA-2691 <https://issues.apache.org/jira/browse/OPENJPA-2691>
OracleDictionary
should use non Deprecated method of empty_lob
OPENJPA-2694 <https://issues.apache.org/jira/browse/OPENJPA-2694> Creating
count(distinct x.field) fails when using CriteriaBuilder

Are any of those blockers?

Jon

On Tue, May 1, 2018 at 10:06 AM, Mark Struberg <st...@yahoo.de.invalid>
wrote:

> Hi folks!
>
> Do we want to release 2.4.3 in the next few days?
> I'm currently running all the tests.
>
> If nobody speaks out against it then I gonna run the release somewhen over
> the next few days.
>
> txs and LieGrue,
> strub