You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2015/04/10 02:08:20 UTC

[GitHub] incubator-twill pull request: (TWILL-120) Make Twill Java8 compati...

GitHub user chtyim opened a pull request:

    https://github.com/apache/incubator-twill/pull/30

    (TWILL-120) Make Twill Java8 compatible

    - Make Dependencies to use ASM5 visitor to find class dependencies
    - Update MethodVisitor to use the right visitMethodInsn instead of the deprecated one
      - The deprecated one will miss static initializer <clinit>, hence causing missing runtime dependencies
    - Also fixed the tracing to includes all Annotation classes that are visible at runtime
    - Added an unit-test in a separate java8-test to test Java8 compatibility

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtyim/incubator-twill feature/twill-120

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-twill/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 04a0965eeec15bdc73e99239e3652caf5162b423
Author: Terence Yim <ch...@apache.org>
Date:   2015-04-10T00:03:18Z

    (TWILL-120) Make Twill Java8 compatible
    
    - Make Dependencies to use ASM5 visitor to find class dependencies
    - Update MethodVisitor to use the right visitMethodInsn instead of the deprecated one
      - The deprecated one will miss static initializer <clinit>, hence causing missing runtime dependencies
    - Also fixed the tracing to includes all Annotation classes that are visible at runtime
    - Added an unit-test in a separate java8-test to test Java8 compatibility

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-120) Make Twill Java8 compati...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-twill/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-120) Make Twill Java8 compati...

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:

    https://github.com/apache/incubator-twill/pull/30#issuecomment-91896497
  
    Applied patch to container with Java8 and source compiled and passed tests.
    
    +1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---