You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yukkit (via GitHub)" <gi...@apache.org> on 2023/02/08 05:24:48 UTC
[GitHub] [arrow-datafusion] yukkit opened a new pull request, #5219: bugfix: fix propagating empty_relation generates an illegal plan
yukkit opened a new pull request, #5219:
URL: https://github.com/apache/arrow-datafusion/pull/5219
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5218 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5219: bugfix: fix propagating empty_relation generates an illegal plan
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5219:
URL: https://github.com/apache/arrow-datafusion/pull/5219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5219: bugfix: fix propagating empty_relation generates an illegal plan
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5219:
URL: https://github.com/apache/arrow-datafusion/pull/5219#issuecomment-1422144936
> Can you help merge the pr, I'm going to use this commit @jackwener
I can understand what you want.
BUT, even if I merge this PR, you also can't use it right away because it doesn't in release version.
If you want to use `master branch` to get this PR (after this PR was merged), I don't recommend you this method, because `master branch` isn't stable branch, which may cause other problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5219: bugfix: fix propagating empty_relation generates an illegal plan
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5219:
URL: https://github.com/apache/arrow-datafusion/pull/5219#issuecomment-1423078636
Thank you @yukkit and @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5219: bugfix: fix propagating empty_relation generates an illegal plan
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5219:
URL: https://github.com/apache/arrow-datafusion/pull/5219#issuecomment-1423089217
Benchmark runs are scheduled for baseline = b4cf60acb00294baeed6574b6b08a4963204c23f and contender = e16650073320dec3b0517aba12c6ce738eb4a503. e16650073320dec3b0517aba12c6ce738eb4a503 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0199adc487cd4593b9341c9ab8da0db7...cf3742e6981a4af5ae66351ad7a2e4d4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9c9d71d6b3934357a9d9439d48fbdba9...fa6bd3729c964e19a186ff61d9f5c551/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/31d53adc6f1046469d497505edc67960...dbce847abd2e4bd5831fa695486049f8/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6367ae34bbc445b8ac1bc4be9876a475...4e70146050f9458eb8d46831ae41b9c7/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5219: bugfix: fix propagating empty_relation generates an illegal plan
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5219:
URL: https://github.com/apache/arrow-datafusion/pull/5219#issuecomment-1423080635
BTW if you do want to try out DataFusion directly from master you can use something like this in your `Cargo.toml`
[patch.crates-io]
datafusion = { git = "https://github.com/apache/arrow-rs.git", branch="master" }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yukkit commented on pull request #5219: bugfix: fix propagating empty_relation generates an illegal plan
Posted by "yukkit (via GitHub)" <gi...@apache.org>.
yukkit commented on PR #5219:
URL: https://github.com/apache/arrow-datafusion/pull/5219#issuecomment-1422116990
Can you help merge the pr, I'm going to use this commit @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org