[GitHub] [lucenenet] NightOwl888 opened a new pull request #483: BREAKING: Changed GetFilePointer() methods into Position properties

[GitBox <gi...@apache.org>]

NightOwl888 opened a new pull request #483:
URL: https://github.com/apache/lucenenet/pull/483


   This changes `GetFilePointer()` methods to properties named `Position`, which matches the convention used by [System.IO.FileStream.Position](https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.position). Affected types:
   
   - `Lucene.Net.Store.IndexInput` (and subclasses)
   - `Lucene.Net.Store.IndexOutput` (and subclasses)
   
   Extension methods were also added in the `Lucene.Net.Store` namespace for backward compatibility. These extension methods are hidden from Intellisense and marked obsolete. They will be removed in the first 4.8.0 release candidate. 
   
   > NOTE: These are meant to be a best effort to reduce breaking changes, but of course the `Lucene.Net.Store` namespace may not be imported in your code. It is recommended to utilize the property rather than importing the `Lucene.Net.Store` namespace.
   
   This also changes a call in `ReadersAndUpdates` from the obsolete `BinaryDocValuesField.fType` to `BinaryDocValuesField.TYPE` (which was missed in #482).
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 merged pull request #483: BREAKING: Changed GetFilePointer() methods into Position properties

[GitBox <gi...@apache.org>]

NightOwl888 merged pull request #483:
URL: https://github.com/apache/lucenenet/pull/483


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org