You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/22 08:26:02 UTC

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

SPRESENSE opened a new pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443


   ## Summary
   
   Add flags argument to sendto/recvfrom interface in usrsock.
   
   ## Impact
   
   ## Testing
   
   Tested by spresense:wifi


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#discussion_r458696187



##########
File path: net/usrsock/usrsock_sendto.c
##########
@@ -376,9 +377,13 @@ ssize_t usrsock_sendto(FAR struct socket *psock, FAR const void *buf,
           goto errout_unlock;
         }
 
+      /* MSG_DONTWAIT is only use in usrsock. */
+
+       flags &= ~MSG_DONTWAIT;

Review comment:
       Should we need handle DONTWAIT like NONBLOCK flag?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] SPRESENSE commented on pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#issuecomment-665394053


   @jerpelea I added the commit message. Could you please review this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#issuecomment-665472696


   @SPRESENSE Please send the complementary patches to the apps git 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#issuecomment-664116533


   please add comiit message with the commit description


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#issuecomment-665472696


   @SPRESENSE Thanks for adding the commit message
   
    Please send the complementary patches to the apps git 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] SPRESENSE commented on a change in pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on a change in pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#discussion_r460641478



##########
File path: net/usrsock/usrsock_sendto.c
##########
@@ -172,6 +172,7 @@ static int do_sendto_request(FAR struct usrsock_conn_s *conn,
 
   req.head.reqid = USRSOCK_REQUEST_SENDTO;
   req.usockid = conn->usockid;
+  req.flags = flags;

Review comment:
       Okay, I'll push them later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#discussion_r458695100



##########
File path: net/usrsock/usrsock_sendto.c
##########
@@ -172,6 +172,7 @@ static int do_sendto_request(FAR struct usrsock_conn_s *conn,
 
   req.head.reqid = USRSOCK_REQUEST_SENDTO;
   req.usockid = conn->usockid;
+  req.flags = flags;

Review comment:
       Please submit the related patch to:
   apps/examples/usrsocktest/
   apps/wireless/gs2200m/
   apps/netutils/usrsock_rpmsg/
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] SPRESENSE commented on a change in pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on a change in pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#discussion_r460641543



##########
File path: net/usrsock/usrsock_sendto.c
##########
@@ -376,9 +377,13 @@ ssize_t usrsock_sendto(FAR struct socket *psock, FAR const void *buf,
           goto errout_unlock;
         }
 
+      /* MSG_DONTWAIT is only use in usrsock. */
+
+       flags &= ~MSG_DONTWAIT;

Review comment:
       yes, we need it.

##########
File path: net/usrsock/usrsock_recvfrom.c
##########
@@ -397,9 +399,13 @@ ssize_t usrsock_recvfrom(FAR struct socket *psock, FAR void *buf, size_t len,
 
       usrsock_setup_datain(conn, inbufs, ARRAY_SIZE(inbufs));
 
+      /* MSG_DONTWAIT is only use in usrsock. */
+
+      flags &= ~MSG_DONTWAIT;

Review comment:
       Yes, we need it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1443: net/usrsock: Add flags to sendto/recvfrom in usrsock

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1443:
URL: https://github.com/apache/incubator-nuttx/pull/1443#discussion_r458696236



##########
File path: net/usrsock/usrsock_recvfrom.c
##########
@@ -397,9 +399,13 @@ ssize_t usrsock_recvfrom(FAR struct socket *psock, FAR void *buf, size_t len,
 
       usrsock_setup_datain(conn, inbufs, ARRAY_SIZE(inbufs));
 
+      /* MSG_DONTWAIT is only use in usrsock. */
+
+      flags &= ~MSG_DONTWAIT;

Review comment:
       Should we need handle DONTWAIT like NONBLOCK flag?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org