You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anurag Singh <an...@gmail.com> on 2016/04/04 19:07:45 UTC
Re: Review Request 44287: Added MasterContender and MasterDetector
abstract classes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/
-----------------------------------------------------------
(Updated April 4, 2016, 5:07 p.m.)
Review request for mesos, Benjamin Hindman and Kapil Arya.
Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610
Repository: mesos
Description
-------
MasterContender and MasterDetector abstract classes can be subclassed by
user-provided classes to allow for arbitrary contender/detector implementations.
Diffs (updated)
-----
include/mesos/master/contender.hpp PRE-CREATION
include/mesos/master/detector.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/44287/diff/
Testing
-------
See https://reviews.apache.org/r/44670/.
Thanks,
Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector
abstract classes.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/#review127499
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On April 6, 2016, 12:02 p.m., Anurag Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44287/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 12:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kapil Arya.
>
>
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MasterContender and MasterDetector abstract classes can be subclassed by
> user-provided classes to allow for arbitrary contender/detector implementations.
>
>
> Diffs
> -----
>
> include/mesos/master/contender.hpp PRE-CREATION
> include/mesos/master/detector.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44287/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/44670/.
>
>
> Thanks,
>
> Anurag Singh
>
>
Re: Review Request 44287: Added MasterContender and MasterDetector
abstract classes.
Posted by Anurag Singh <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/
-----------------------------------------------------------
(Updated April 6, 2016, 4:02 p.m.)
Review request for mesos, Benjamin Hindman and Kapil Arya.
Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610
Repository: mesos
Description
-------
MasterContender and MasterDetector abstract classes can be subclassed by
user-provided classes to allow for arbitrary contender/detector implementations.
Diffs (updated)
-----
include/mesos/master/contender.hpp PRE-CREATION
include/mesos/master/detector.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/44287/diff/
Testing
-------
See https://reviews.apache.org/r/44670/.
Thanks,
Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector
abstract classes.
Posted by Anurag Singh <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/
-----------------------------------------------------------
(Updated April 6, 2016, 3:13 p.m.)
Review request for mesos, Benjamin Hindman and Kapil Arya.
Bugs: MESOS-4610
https://issues.apache.org/jira/browse/MESOS-4610
Repository: mesos
Description
-------
MasterContender and MasterDetector abstract classes can be subclassed by
user-provided classes to allow for arbitrary contender/detector implementations.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 96d395d37cdad706c2f23fdd9caeefc2a33e0541
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp ef365e4d714a2c25d358a702722c5f1216869382
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 232588c46c8207c6a002f60d00aa675f9e505083
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 46e3ec25cbf379fb2b82297849216b0866baf333
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458
3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 89dedec0c818263f17f220a2e71ed470bf75a42f
3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp d634491b301632ce6468f86d04f21fa25afbbaaa
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc
3rdparty/libprocess/include/process/network.hpp 2bc940fb3ba2bc6b2fed281a3920d13fdb1277e9
3rdparty/libprocess/src/encoder.hpp 69163830eaa9f77132a16fc14351b309144827bf
3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9
3rdparty/libprocess/src/time.cpp a6c3f3de69e056544406f4416c2d0aea06adc34d
CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e
docs/app-framework-development-guide.md c5badd00121e7d1752dd2a4b471f97b80ef07926
docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c
docs/fetcher.md fd6d8a78bd35c5644dceff7005dd7dfd9f5f2171
include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481
include/mesos/master/contender.hpp PRE-CREATION
include/mesos/master/detector.hpp PRE-CREATION
include/mesos/scheduler.hpp 5b153d2acb705cc54fcca86914af72d8b2e3fb55
src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0
src/docker/docker.hpp da6e9a25b99079940958001128ee949cdb9b931b
src/docker/docker.cpp bb9ddde27464aa4d9215e3ca673fa87c6e00e326
src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d
src/java/src/org/apache/mesos/SchedulerDriver.java 3f03e91b8d65bca725f8063eca54e362a640e298
src/launcher/executor.cpp 4658b9e5bb48b09e403991c8bdfdbf4d4dae0416
src/linux/cgroups.hpp 5f4010734ed9e3295dcc3a4390123e4f4ce99c16
src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f
src/python/interface/src/mesos/interface/__init__.py 1da76ebe577639e8161b16a48a503aa76d568789
src/slave/containerizer/docker.cpp 0576eab65a1f3556644472d5c9baba4ea9c34346
src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 703e49f86ae41c11ae350ae51107eda00d0d5b7e
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 654137c552a7c416f394365e43ea80770fe1ef8d
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f43ab071de42de16d330cfd2a3b76563bcb173c9
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 21a86e3087bea46a2d2125e53292251243086554
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6545a6d29cb91d6cf8919c7796c283084178e499
src/slave/flags.hpp 69e1b01e09d2a15bee5e0745b751f47aaefe3fbe
src/slave/flags.cpp 315cf47d268bce0a0255a061d64e414c736c8125
src/tests/containerizer/docker_spec_tests.cpp 796b020f58f8451362bc1357ab6d7ceb4e946b3c
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5565227bc0b18f1891265e6eff0c5a22a0c4ab86
src/tests/containerizer/port_mapping_tests.cpp ce985f44cffd74a853154309397b8ee596934f78
src/tests/environment.cpp acadb5bb0a1b1a9b0cee0345035b93147bf7164c
src/tests/mesos.hpp 3b565b45f45c84aba42aa6fb29b21f8306c49861
src/tests/mesos.cpp cf38dbb05908800b3a771318fa6922548c86c1f2
support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf
Diff: https://reviews.apache.org/r/44287/diff/
Testing
-------
See https://reviews.apache.org/r/44670/.
Thanks,
Anurag Singh