You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhuangchong (via GitHub)" <gi...@apache.org> on 2024/11/13 10:44:28 UTC

[PR] [hive] Improve paimon format table conversion hive table in hive catalog. [paimon]

zhuangchong opened a new pull request, #4522:
URL: https://github.com/apache/paimon/pull/4522

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Improve paimon format table conversion hive table in hive catalog.
   
   1.Remove duplicate codes, such as the setting of serdeParamters of csv
   2.Put paimon formate table conversion hive table and hive table conversion paimon formate table into a class. They are related and will be easier to find and modify at the same time in subsequent code changes.
   3.Extract public tool class HiveFormat
   
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hive] Improve paimon format table conversion hive table in hive catalog. [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #4522:
URL: https://github.com/apache/paimon/pull/4522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hive] Improve paimon format table conversion hive table in hive catalog. [paimon]

Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on PR #4522:
URL: https://github.com/apache/paimon/pull/4522#issuecomment-2496606451

   > Thanks @zhuangchong for the contribution, but I think this actually increases complexity, as can be seen from the number of lines of code. This may increase the risk of some bugs.
   
   @JingsongLi 
   I optimized the code and used the FormatTable.Format enumeration class instead of strings. Please help with code review.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org