Re: [PR] [HUDI-8367] Fix log file marker creation in file group initialization in metadata table writer [hudi]

["linliu-code (via GitHub)" <gi...@apache.org>]

linliu-code commented on code in PR #12102:
URL: https://github.com/apache/hudi/pull/12102#discussion_r1840582579


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -921,6 +930,26 @@ private void initializeFileGroups(HoodieTableMetaClient dataMetaClient, Metadata
     }, fileGroupFileIds.size());
   }
 
+  /**
+   * Returns a log creation hook impl.
+   */
+  private LogFileCreationCallback getLogCreationCallback(HoodieStorage storage,
+                                                         String instantTime,
+                                                         String partitionPath,
+                                                         String fileId) {
+    return new LogFileCreationCallback() {
+      @Override
+      public boolean preFileCreation(HoodieLogFile logFile) {
+        WriteMarkers writeMarkers = new DirectWriteMarkers(

Review Comment:
   @danny0405 , is the PR mergable, or you insist on creating the utility method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org