Re: [PR] skip invalid json string rather than throwing error during json indexing [pinot]

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on code in PR #12238:
URL: https://github.com/apache/pinot/pull/12238#discussion_r1482203477


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##########
@@ -719,4 +721,19 @@ private static void addFieldToPinotSchema(Schema pinotSchema, DataType dataType,
       }
     }
   }
+
+  public static List<Map<String, String>> flatten(String jsonString, JsonIndexConfig jsonIndexConfig)

Review Comment:
   @wirybeaver : what about the other `JsonUtils#flatten` methods? Are they still being used? I see them only being used in tests (on a different branch). If so let's make them protected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org