You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/03 06:56:00 UTC
[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
lhotari opened a new pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192
### Motivation
Currently k8s 1.14 version is used in CI to verify the Helm chart changes.
k8s 1.14 became end-of-life [2019-12-11 , over 2 years ago](https://kubernetes.io/releases/patch-releases/#non-active-branch-history).
k8s 1.18 has also reached end-of-life on 2021-06-18 . The upgrade from 1.18 to a newer version can happen in another PR.
### Modifications
- upgrade k8s kubectl to v1.18.20
- upgrade kindest/node to v1.18.19 (newest 1.18 for kind)
- upgrade kind to v0.11.1
- upgrade helm to 3.7.2
- upgrade chart releaser to 1.3.0
- upgrade chart apiVersion to v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192#issuecomment-1004658284
Mailing list discussion: https://lists.apache.org/thread/jwhb980svfm8rfbd7grswzb1dzf964ny
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192#discussion_r777659034
##########
File path: .gitignore
##########
@@ -16,3 +16,6 @@ charts/**/*.lock
PRIVATEKEY
PUBLICKEY
+.vagrant/
+pulsarctl-amd64-linux.tar.gz
+pulsarctl-amd64-linux/
Review comment:
I looked at my clone of the project, and I can see that I have `pulsarctl-amd64-darwin/` and `pulsarctl-amd64-darwin.tar.gz`. These names must be arch dependent.
Why do we need these files/directories though? From what I can tell, it is because the tests use it to generate tokens/keys. It seems like we could use a more standard tool, like `openssl`, for token generation and then drop this dependency.
If we want to worry about the dependency in another PR/thread, I think you could update this to `pulsarctl-**` for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari merged pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] Anonymitaet commented on a change in pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192#discussion_r780866433
##########
File path: README.md
##########
@@ -72,9 +72,9 @@ It includes support for:
In order to use this chart to deploy Apache Pulsar on Kubernetes, the followings are required.
-1. kubectl 1.14 or higher, compatible with your cluster ([+/- 1 minor release from your cluster](https://kubernetes.io/docs/tasks/tools/install-kubectl/#before-you-begin))
+1. kubectl 1.18 or higher, compatible with your cluster ([+/- 1 minor release from your cluster](https://kubernetes.io/docs/tasks/tools/install-kubectl/#before-you-begin))
Review comment:
Thanks for updating docs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192#issuecomment-1003979521
> Build failed:
>
> : INSTALLATION FAILED: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "DaemonSet" in version "extensions/v1beta1
@eolivelli This problem is fixed now. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on a change in pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192#discussion_r777846937
##########
File path: .gitignore
##########
@@ -16,3 +16,6 @@ charts/**/*.lock
PRIVATEKEY
PUBLICKEY
+.vagrant/
+pulsarctl-amd64-linux.tar.gz
+pulsarctl-amd64-linux/
Review comment:
I updated .gitignore to cover pulsartcl-amd64-darwin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari commented on a change in pull request #192: [CI] Upgrade k8s to 1.18 and also upgrade helm, kind & chart releaser versions
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #192:
URL: https://github.com/apache/pulsar-helm-chart/pull/192#discussion_r777888049
##########
File path: .gitignore
##########
@@ -16,3 +16,6 @@ charts/**/*.lock
PRIVATEKEY
PUBLICKEY
+.vagrant/
+pulsarctl-amd64-linux.tar.gz
+pulsarctl-amd64-linux/
Review comment:
@michaeljmarshall I think it's better to handle the possible removal of pulsarctl in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org