You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/28 01:18:00 UTC
[jira] [Work logged] (BEAM-4775) JobService should support
returning metrics
[ https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=190676&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190676 ]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 01:17
Start Date: 28/Jan/19 01:17
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7641: [DO NOT MERGE] [BEAM-4775] Portable metrics over the job-server API
URL: https://github.com/apache/beam/pull/7641
(also fixes [BEAM-4776](https://issues.apache.org/jira/browse/BEAM-4776) (Java) and [BEAM-4777](https://issues.apache.org/jira/browse/BEAM-4777) (Python)
This currently sits on top of https://github.com/ajamato/beam/pull/1 (which adds a couple of tweaks to #7624), #7621, #7637, #7638, and #7639.
[The last 13 commits](https://github.com/ryan-williams/beam/compare/job-metrics-base...ryan-williams:job-api-portable-metrics) are hopefully well-differentiated, and represent the actual new functionality not covered by the PRs it's based on.
With this merged:
- python portable wordcount receives and prints metrics
- portable VR Flink test cases covering "attempted metrics" can be enabled (see last commit)
Submitting now to start CI-debugging, and also to seed some design discussions.
CC: @ajamato @mxm @robertwb @angoenka @tweise
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 190676)
Time Spent: 10m
Remaining Estimate: 0h
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto] currently doesn't appear to have a way for JobService to return metrics to a user, even though [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto] includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because PAssert needs to validate that the assertions succeeded. However, this statement should be double-checked: perhaps it's possible to somehow work with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)