You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sheetal Shah <sh...@freestoneinfotech.com> on 2024/04/04 05:14:28 UTC
Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
-----------------------------------------------------------
(Updated April 4, 2024, 10:44 a.m.)
Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad Pawar, Radhika Kundam, and Sidharth Mishra.
Changes
-------
corrected operator case sensitivity logic
Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797
Repository: atlas
Description (updated)
-------
Currently, Atlas has to persist all audit events without any constraints which can make audit data grow exponentially after some time.
This feature is specifically to reduce Atlas audit storage where generation of audit events can be controlled based on the user's use-case/criteria
Note: Audit data mentioned here is exclusive of Admin Audit Data which persists in atlas_janus table. Filtering will be applicable to the entity audit data which persists in ATLAS_ENTITY_AUDIT_EVENTS table.
Precommit details :
Latest PC build (PASSED) : build:https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1592/
Diffs (updated)
-----
addons/hbase-bridge/pom.xml 278b6c6d3
addons/hbase-testing-util/pom.xml c4f3a99ee
addons/hive-bridge-shim/pom.xml 39f16ceee
addons/hive-bridge/pom.xml 356ac9542
addons/kafka-bridge/pom.xml 093db7229
addons/models/0000-Area0/0010-base_model.json a4a9248ec
addons/sqoop-bridge/pom.xml 4b6eac98f
authorization/pom.xml 7a1108487
distro/src/conf/atlas-application.properties b5734d7a8
graphdb/api/pom.xml 4ba89b20f
graphdb/janus-hbase2/pom.xml 9ec087dbb
intg/pom.xml 43a172c1b
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 3afd27e7d
repository/pom.xml 8fd744b44
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 9b011ab06
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java b7f0dd5e2
repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java e63152475
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java PRE-CREATION
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java PRE-CREATION
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java PRE-CREATION
repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java PRE-CREATION
server-api/pom.xml de311c329
test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16
webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java e19beccb1
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0025276bb
webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 268fca717
Diff: https://reviews.apache.org/r/74608/diff/13/
Changes: https://reviews.apache.org/r/74608/diff/12-13/
Testing
-------
Manual testing done
Thanks,
Sheetal Shah
Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas
Posted by Sheetal Shah <sh...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/
-----------------------------------------------------------
(Updated Dec. 12, 2024, 5:36 p.m.)
Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad Pawar, Radhika Kundam, and Sidharth Mishra.
Changes
-------
The updated patch addresses review comments from Madhan and also includes test cases
Bugs: ATLAS-4797
https://issues.apache.org/jira/browse/ATLAS-4797
Repository: atlas
Description (updated)
-------
Currently, Atlas has to persist all audit events without any constraints which can make audit data grow exponentially after some time.
This feature is specifically to reduce Atlas audit storage where generation of audit events can be controlled based on the user's use-case/criteria
Note: Audit data mentioned here is exclusive of Admin Audit Data which persists in atlas_janus table. Filtering will be applicable to the entity audit data which persists in ATLAS_ENTITY_AUDIT_EVENTS table.
Precommit details :
Latest PC build (PASSED) 12-12-2024 : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1757/
Diffs (updated)
-----
addons/hbase-bridge/pom.xml 968d8039c
addons/hbase-testing-util/pom.xml 05ed88401
addons/hive-bridge-shim/pom.xml 08a9ee7c4
addons/hive-bridge/pom.xml aa32e033f
addons/kafka-bridge/pom.xml a1dd3a666
addons/models/0000-Area0/0010-base_model.json a4a9248ec
addons/sqoop-bridge/pom.xml 9ddd4efcd
authorization/pom.xml 0e7d75a46
client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 6477b4091
distro/src/conf/atlas-application.properties b5734d7a8
graphdb/api/pom.xml a01668b64
intg/pom.xml 0fa19b605
intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 6c39ee406
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 61b8155b9
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 3afd27e7d
intg/src/main/java/org/apache/atlas/model/instance/AtlasRule.java PRE-CREATION
repository/pom.xml 24dee7e30
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 9b011ab06
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java e0ecacc6d
repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java e63152475
repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java PRE-CREATION
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java PRE-CREATION
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java PRE-CREATION
repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java PRE-CREATION
server-api/pom.xml 3ecef5df7
test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16
webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java e264fa30f
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 475756981
webapp/src/test/java/org/apache/atlas/web/filters/CAFTests.java PRE-CREATION
webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 268fca717
webapp/src/test/resources/atlas-application.properties b5c707ed1
Diff: https://reviews.apache.org/r/74608/diff/14/
Changes: https://reviews.apache.org/r/74608/diff/13-14/
Testing
-------
Manual testing done
Thanks,
Sheetal Shah
Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas
Posted by Sheetal Shah <sh...@freestoneinfotech.com>.
> On April 25, 2024, 11:19 a.m., Madhan Neethiraj wrote:
> > Consider adding few samples and test cases, to make it easier to understand audit filter functioanlity.
this patch includes a few tests which will help demonstrate the following usages of rules:
control audits based on single or multiple criteria/conditions
control audits with same criteria for multiple types : CSV of type-names is supported
control audits for all types under a hook type : using Regex support for wildcard character '*'
control audits using same rule for a type and all its subtypes
> On April 25, 2024, 11:19 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
> > Lines 462 (patched)
> > <https://reviews.apache.org/r/74608/diff/13/?file=2286898#file2286898line462>
> >
> > prepareDataObject() seems expensive - especially given it will be executed for each entity operation in Atlas. Are all fields of AtlasEntity used in rules?
currently only basic metadata fields with primitive data types are being supported.
> On April 25, 2024, 11:19 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java
> > Lines 83 (patched)
> > <https://reviews.apache.org/r/74608/diff/13/?file=2286905#file2286905line83>
> >
> > This conversion seems expensive. Is this conversion necessary for every evalation of a rule?
yes, currently we do not have any caching mechanism for rules to store expressions of all rules in memory. Hence, we are currently fetching all the rules from the database everytime just before applying them on the incoming event and using this conversion to execute the pertaining rule evaluation in the flow
> On April 25, 2024, 11:19 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/74608/diff/13/?file=2286905#file2286905line97>
> >
> > Rule evaluation continues even after ACCEPT result from a rule; is this necessary?
yes. The evaluation continues for all the rules one after the other or until a matching rule with action DISCARD is encountered. Once a rule matches to DISCARD, no rules will be executed further and the audit event will be discarded. In case if no rules match, the default action is taken.
> On April 25, 2024, 11:19 a.m., Madhan Neethiraj wrote:
> > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
> > Lines 1327 (patched)
> > <https://reviews.apache.org/r/74608/diff/13/?file=2286910#file2286910line1327>
> >
> > Doesn't "/audits/rules/all" conflict with "/audits/rules/{ruleGuid}" (line #1269 above)?
No, the API paths "/audits/rules/all" and "/audits/rules/{ruleGuid}" do not conflict because they are distinct routes that the framework should be able to differentiate.
If a request is sent to "/audits/rules/all", the static route is matched, and the dynamic route is not evaluated.
For a request like "/audits/rules/1234", the dynamic route matches because no static route corresponds.
I have still made changes to the path definition to avoid any understanding conflicts
- Sheetal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/#review226400
-----------------------------------------------------------
On Dec. 12, 2024, 5:36 p.m., Sheetal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74608/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2024, 5:36 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad Pawar, Radhika Kundam, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4797
> https://issues.apache.org/jira/browse/ATLAS-4797
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently, Atlas has to persist all audit events without any constraints which can make audit data grow exponentially after some time.
>
> This feature is specifically to reduce Atlas audit storage where generation of audit events can be controlled based on the user's use-case/criteria
>
> Note: Audit data mentioned here is exclusive of Admin Audit Data which persists in atlas_janus table. Filtering will be applicable to the entity audit data which persists in ATLAS_ENTITY_AUDIT_EVENTS table.
>
> Precommit details :
> Latest PC build (PASSED) 12-12-2024 : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1757/
>
>
> Diffs
> -----
>
> addons/hbase-bridge/pom.xml 968d8039c
> addons/hbase-testing-util/pom.xml 05ed88401
> addons/hive-bridge-shim/pom.xml 08a9ee7c4
> addons/hive-bridge/pom.xml aa32e033f
> addons/kafka-bridge/pom.xml a1dd3a666
> addons/models/0000-Area0/0010-base_model.json a4a9248ec
> addons/sqoop-bridge/pom.xml 9ddd4efcd
> authorization/pom.xml 0e7d75a46
> client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 6477b4091
> distro/src/conf/atlas-application.properties b5734d7a8
> graphdb/api/pom.xml a01668b64
> intg/pom.xml 0fa19b605
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 6c39ee406
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 61b8155b9
> intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 3afd27e7d
> intg/src/main/java/org/apache/atlas/model/instance/AtlasRule.java PRE-CREATION
> repository/pom.xml 24dee7e30
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 9b011ab06
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java e0ecacc6d
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java e63152475
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java PRE-CREATION
> server-api/pom.xml 3ecef5df7
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java e264fa30f
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 475756981
> webapp/src/test/java/org/apache/atlas/web/filters/CAFTests.java PRE-CREATION
> webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 268fca717
> webapp/src/test/resources/atlas-application.properties b5c707ed1
>
>
> Diff: https://reviews.apache.org/r/74608/diff/14/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Sheetal Shah
>
>
Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/#review226400
-----------------------------------------------------------
Consider adding few samples and test cases, to make it easier to understand audit filter functioanlity.
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java
Lines 221 (patched)
<https://reviews.apache.org/r/74608/#comment314614>
Consider annotating isDiscarded() and setDiscarded() with @JsonIgnore.
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
Lines 462 (patched)
<https://reviews.apache.org/r/74608/#comment314615>
prepareDataObject() seems expensive - especially given it will be executed for each entity operation in Atlas. Are all fields of AtlasEntity used in rules?
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java
Lines 74 (patched)
<https://reviews.apache.org/r/74608/#comment314611>
this.rules could be updated between #74 and #81, with the call to setRules() (#41). Consider adding the following line before #74:
final List<AtlasRule> rules = this.rules;
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java
Lines 83 (patched)
<https://reviews.apache.org/r/74608/#comment314612>
This conversion seems expensive. Is this conversion necessary for every evalation of a rule?
repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java
Lines 97 (patched)
<https://reviews.apache.org/r/74608/#comment314613>
Rule evaluation continues even after ACCEPT result from a rule; is this necessary?
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 1327 (patched)
<https://reviews.apache.org/r/74608/#comment314610>
Doesn't "/audits/rules/all" conflict with "/audits/rules/{ruleGuid}" (line #1269 above)?
- Madhan Neethiraj
On April 4, 2024, 5:14 a.m., Sheetal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74608/
> -----------------------------------------------------------
>
> (Updated April 4, 2024, 5:14 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad Pawar, Radhika Kundam, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4797
> https://issues.apache.org/jira/browse/ATLAS-4797
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently, Atlas has to persist all audit events without any constraints which can make audit data grow exponentially after some time.
>
> This feature is specifically to reduce Atlas audit storage where generation of audit events can be controlled based on the user's use-case/criteria
>
> Note: Audit data mentioned here is exclusive of Admin Audit Data which persists in atlas_janus table. Filtering will be applicable to the entity audit data which persists in ATLAS_ENTITY_AUDIT_EVENTS table.
>
> Precommit details :
> Latest PC build (PASSED) : build:https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1592/
>
>
> Diffs
> -----
>
> addons/hbase-bridge/pom.xml 278b6c6d3
> addons/hbase-testing-util/pom.xml c4f3a99ee
> addons/hive-bridge-shim/pom.xml 39f16ceee
> addons/hive-bridge/pom.xml 356ac9542
> addons/kafka-bridge/pom.xml 093db7229
> addons/models/0000-Area0/0010-base_model.json a4a9248ec
> addons/sqoop-bridge/pom.xml 4b6eac98f
> authorization/pom.xml 7a1108487
> distro/src/conf/atlas-application.properties b5734d7a8
> graphdb/api/pom.xml 4ba89b20f
> graphdb/janus-hbase2/pom.xml 9ec087dbb
> intg/pom.xml 43a172c1b
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3
> intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 3afd27e7d
> repository/pom.xml 8fd744b44
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 9b011ab06
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java b7f0dd5e2
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java e63152475
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java PRE-CREATION
> server-api/pom.xml de311c329
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java e19beccb1
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0025276bb
> webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 268fca717
>
>
> Diff: https://reviews.apache.org/r/74608/diff/13/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Sheetal Shah
>
>
Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas
Posted by Radhika Kundam via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/#review226398
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika Kundam
On April 3, 2024, 10:14 p.m., Sheetal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74608/
> -----------------------------------------------------------
>
> (Updated April 3, 2024, 10:14 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad Pawar, Radhika Kundam, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4797
> https://issues.apache.org/jira/browse/ATLAS-4797
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently, Atlas has to persist all audit events without any constraints which can make audit data grow exponentially after some time.
>
> This feature is specifically to reduce Atlas audit storage where generation of audit events can be controlled based on the user's use-case/criteria
>
> Note: Audit data mentioned here is exclusive of Admin Audit Data which persists in atlas_janus table. Filtering will be applicable to the entity audit data which persists in ATLAS_ENTITY_AUDIT_EVENTS table.
>
> Precommit details :
> Latest PC build (PASSED) : build:https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1592/
>
>
> Diffs
> -----
>
> addons/hbase-bridge/pom.xml 278b6c6d3
> addons/hbase-testing-util/pom.xml c4f3a99ee
> addons/hive-bridge-shim/pom.xml 39f16ceee
> addons/hive-bridge/pom.xml 356ac9542
> addons/kafka-bridge/pom.xml 093db7229
> addons/models/0000-Area0/0010-base_model.json a4a9248ec
> addons/sqoop-bridge/pom.xml 4b6eac98f
> authorization/pom.xml 7a1108487
> distro/src/conf/atlas-application.properties b5734d7a8
> graphdb/api/pom.xml 4ba89b20f
> graphdb/janus-hbase2/pom.xml 9ec087dbb
> intg/pom.xml 43a172c1b
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3
> intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 3afd27e7d
> repository/pom.xml 8fd744b44
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 9b011ab06
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java b7f0dd5e2
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java e63152475
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java PRE-CREATION
> server-api/pom.xml de311c329
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java e19beccb1
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0025276bb
> webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 268fca717
>
>
> Diff: https://reviews.apache.org/r/74608/diff/13/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Sheetal Shah
>
>
Re: Review Request 74608: ATLAS-4797 : Implement custom audit filters in Atlas
Posted by Jayendra Parab <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74608/#review226399
-----------------------------------------------------------
Ship it!
Ship It!
- Jayendra Parab
On April 4, 2024, 5:14 a.m., Sheetal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74608/
> -----------------------------------------------------------
>
> (Updated April 4, 2024, 5:14 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, Prasad Pawar, Radhika Kundam, and Sidharth Mishra.
>
>
> Bugs: ATLAS-4797
> https://issues.apache.org/jira/browse/ATLAS-4797
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently, Atlas has to persist all audit events without any constraints which can make audit data grow exponentially after some time.
>
> This feature is specifically to reduce Atlas audit storage where generation of audit events can be controlled based on the user's use-case/criteria
>
> Note: Audit data mentioned here is exclusive of Admin Audit Data which persists in atlas_janus table. Filtering will be applicable to the entity audit data which persists in ATLAS_ENTITY_AUDIT_EVENTS table.
>
> Precommit details :
> Latest PC build (PASSED) : build:https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1592/
>
>
> Diffs
> -----
>
> addons/hbase-bridge/pom.xml 278b6c6d3
> addons/hbase-testing-util/pom.xml c4f3a99ee
> addons/hive-bridge-shim/pom.xml 39f16ceee
> addons/hive-bridge/pom.xml 356ac9542
> addons/kafka-bridge/pom.xml 093db7229
> addons/models/0000-Area0/0010-base_model.json a4a9248ec
> addons/sqoop-bridge/pom.xml 4b6eac98f
> authorization/pom.xml 7a1108487
> distro/src/conf/atlas-application.properties b5734d7a8
> graphdb/api/pom.xml 4ba89b20f
> graphdb/janus-hbase2/pom.xml 9ec087dbb
> intg/pom.xml 43a172c1b
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3
> intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 3afd27e7d
> repository/pom.xml 8fd744b44
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java 9b011ab06
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java b7f0dd5e2
> repository/src/main/java/org/apache/atlas/repository/ogm/AtlasRuleDTO.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java e63152475
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasEntityAuditFilterService.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRule.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRuleUtils.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/AtlasRulesEngine.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/rulesengine/RuleAction.java PRE-CREATION
> server-api/pom.xml de311c329
> test-tools/src/main/resources/solr/core-template/solrconfig.xml 7a0e8dd16
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java e19beccb1
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 0025276bb
> webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 268fca717
>
>
> Diff: https://reviews.apache.org/r/74608/diff/13/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Sheetal Shah
>
>