You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Rodrigo Schmidt (JIRA)" <ji...@apache.org> on 2009/03/03 00:39:56 UTC
[jira] Created: (HADOOP-5379) Throw exception instead of writing to
System.err when there is a CRC error on CBZip2InputStream
Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
-----------------------------------------------------------------------------------------------
Key: HADOOP-5379
URL: https://issues.apache.org/jira/browse/HADOOP-5379
Project: Hadoop Core
Issue Type: Improvement
Components: io
Affects Versions: 0.19.1, 0.19.0, 0.19.2, 0.20.0, 0.21.0
Reporter: Rodrigo Schmidt
Assignee: Rodrigo Schmidt
Priority: Minor
>From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
private static void reportCRCError() throws IOException {
// The clean way would be to throw an exception.
// throw new IOException("crc error");
// Just print a message, like the previous versions of this class did
System.err.println("BZip2 CRC error");
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5379) Throw exception instead of writing to
System.err when there is a CRC error on CBZip2InputStream
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-5379:
------------------------------------
Attachment: HADOOP-5379.patch
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5379) Throw exception instead of writing
to System.err when there is a CRC error on CBZip2InputStream
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681161#action_12681161 ]
Zheng Shao commented on HADOOP-5379:
------------------------------------
+1
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5379) Throw exception instead of writing
to System.err when there is a CRC error on CBZip2InputStream
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680543#action_12680543 ]
Hadoop QA commented on HADOOP-5379:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401785/HADOOP-5379.patch
against trunk revision 752073.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/43/console
This message is automatically generated.
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5379) Throw exception instead of writing to
System.err when there is a CRC error on CBZip2InputStream
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HADOOP-5379:
-------------------------------
Resolution: Fixed
Release Note: HADOOP-5379. CBZip2InputStream to throw IOException on data crc error. (Rodrigo Schmidt via zshao) (was: Throws exception if CRC verification fails during decompression of Bzip2-compressed data.)
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Rodrigo!
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5379) Throw exception instead of writing
to System.err when there is a CRC error on CBZip2InputStream
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681117#action_12681117 ]
Rodrigo Schmidt commented on HADOOP-5379:
-----------------------------------------
The patch simply throws an exception instead of writing to System.err. It's a simple change on the way errors are reported and doesn't require extra tests.
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5379) Throw exception instead of writing to
System.err when there is a CRC error on CBZip2InputStream
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-5379:
------------------------------------
Fix Version/s: 0.21.0
0.20.0
0.19.2
Release Note: Throws exception if CRC verification fails during decompression of Bzip2-compressed data.
Status: Patch Available (was: Open)
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1, 0.19.0, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5379) Throw exception instead of writing to
System.err when there is a CRC error on CBZip2InputStream
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-5379:
------------------------------------
Release Note: (was: Edit release notes for publication.)
Edit release notes for publication.
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5379) Throw exception instead of writing
to System.err when there is a CRC error on CBZip2InputStream
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681744#action_12681744 ]
Hudson commented on HADOOP-5379:
--------------------------------
Integrated in Hadoop-trunk #778 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/778/])
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5379) Throw exception instead of writing to
System.err when there is a CRC error on CBZip2InputStream
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-5379:
------------------------------------
Description:
>From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
{code}
private static void reportCRCError() throws IOException {
// The clean way would be to throw an exception.
// throw new IOException("crc error");
// Just print a message, like the previous versions of this class did
System.err.println("BZip2 CRC error");
}
{code}
was:
>From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
private static void reportCRCError() throws IOException {
// The clean way would be to throw an exception.
// throw new IOException("crc error");
// Just print a message, like the previous versions of this class did
System.err.println("BZip2 CRC error");
}
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5379) Throw exception instead of writing to
System.err when there is a CRC error on CBZip2InputStream
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-5379:
------------------------------------
Release Note: Edit release notes for publication. (was: HADOOP-5379. CBZip2InputStream to throw IOException on data crc error. (Rodrigo Schmidt via zshao))
> Throw exception instead of writing to System.err when there is a CRC error on CBZip2InputStream
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-5379
> URL: https://issues.apache.org/jira/browse/HADOOP-5379
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.0, 0.19.1, 0.19.2, 0.20.0, 0.21.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Priority: Minor
> Fix For: 0.19.2, 0.20.0, 0.21.0
>
> Attachments: HADOOP-5379.patch
>
>
> From org.apache.hadoop.io.compress.bzip2.CBZip2InputStream.java:
> {code}
> private static void reportCRCError() throws IOException {
> // The clean way would be to throw an exception.
> // throw new IOException("crc error");
> // Just print a message, like the previous versions of this class did
> System.err.println("BZip2 CRC error");
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.