You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/04/15 17:06:26 UTC
[I] Refactor duplicate function-evaluation paths in ExpressionTransformer and CustomFunctionEnricher [pinot]
xiangfu0 opened a new issue, #18216:
URL: https://github.com/apache/pinot/issues/18216
### Motivation
`pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ExpressionTransformer.java` and `pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/enricher/function/CustomFunctionEnricher.java` still carry reciprocal TODOs to merge the two implementations.
Both code paths evaluate function-based transformations during ingestion, but they live behind different extension points (`RecordTransformer` vs `RecordEnricher`). That makes behavior drift and duplicate maintenance more likely.
### Scope
- Document the overlap and intended ownership between the two implementations.
- Consolidate shared evaluation logic behind one path or a shared abstraction.
- Preserve current ingestion behavior for transform configs and enricher configs.
- Add or update focused tests for parity and backward compatibility.
### Notes
Observed on `upstream/master` on April 15, 2026.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Refactor duplicate function-evaluation paths in ExpressionTransformer and CustomFunctionEnricher [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #18216:
URL: https://github.com/apache/pinot/issues/18216#issuecomment-6205101288
This issue has been closed because it has been inactive for 180 days. If you believe this issue is still relevant, please feel free to reopen it or create a new issue. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Refactor duplicate function-evaluation paths in ExpressionTransformer and CustomFunctionEnricher [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #18216:
URL: https://github.com/apache/pinot/issues/18216#issuecomment-5672770976
This issue has been automatically marked as stale because it has not had any activity in the last 150 days. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please leave a comment to keep it open. Thank you for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Refactor duplicate function-evaluation paths in ExpressionTransformer and CustomFunctionEnricher [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #18216: Refactor duplicate function-evaluation paths in ExpressionTransformer and CustomFunctionEnricher
URL: https://github.com/apache/pinot/issues/18216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org