You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2007/08/13 11:45:43 UTC

[jira] Created: (DERBY-3003) ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput

ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput
--------------------------------------------------------------------------------------------

                 Key: DERBY-3003
                 URL: https://issues.apache.org/jira/browse/DERBY-3003
             Project: Derby
          Issue Type: Bug
          Components: Services
    Affects Versions: 10.4.0.0
            Reporter: Knut Anders Hatlen
            Priority: Minor


The javadoc for java.io.DataInput.skipBytes(int) says (<URL:http://java.sun.com/javase/6/docs/api/java/io/DataInput.html#skipBytes(int)>):
>  This method never throws an EOFException.

The implementation of this method in org.apache.derby.iapi.services.io.ArrayInputStream says:
		if ((position + n) > end) {

			throw new EOFException();
		}

The method in ArrayInputStream should be changed so that it skips as many bytes as possible (max n) and returns the actual number of bytes skipped, even when EOF is reached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-3003) ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen closed DERBY-3003.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.4.0.0
       Derby Info:   (was: [Patch Available])

Thanks Jørgen. The patch looks good to me.
Committed revision 584773.

> ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3003
>                 URL: https://issues.apache.org/jira/browse/DERBY-3003
>             Project: Derby
>          Issue Type: Bug
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Jørgen Løland
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3003-1.diff, derby-3003-1.stat
>
>
> The javadoc for java.io.DataInput.skipBytes(int) says (<URL:http://java.sun.com/javase/6/docs/api/java/io/DataInput.html#skipBytes(int)>):
> >  This method never throws an EOFException.
> The implementation of this method in org.apache.derby.iapi.services.io.ArrayInputStream says:
> 		if ((position + n) > end) {
> 			throw new EOFException();
> 		}
> The method in ArrayInputStream should be changed so that it skips as many bytes as possible (max n) and returns the actual number of bytes skipped, even when EOF is reached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3003) ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-3003:
---------------------------------

    Attachment: derby-3003-1.diff
                derby-3003-1.stat

Attached a very simple fix for this issue. All tests pass.

> ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3003
>                 URL: https://issues.apache.org/jira/browse/DERBY-3003
>             Project: Derby
>          Issue Type: Bug
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-3003-1.diff, derby-3003-1.stat
>
>
> The javadoc for java.io.DataInput.skipBytes(int) says (<URL:http://java.sun.com/javase/6/docs/api/java/io/DataInput.html#skipBytes(int)>):
> >  This method never throws an EOFException.
> The implementation of this method in org.apache.derby.iapi.services.io.ArrayInputStream says:
> 		if ((position + n) > end) {
> 			throw new EOFException();
> 		}
> The method in ArrayInputStream should be changed so that it skips as many bytes as possible (max n) and returns the actual number of bytes skipped, even when EOF is reached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3003) ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-3003:
---------------------------------

    Derby Info: [Patch Available]

> ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3003
>                 URL: https://issues.apache.org/jira/browse/DERBY-3003
>             Project: Derby
>          Issue Type: Bug
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Jørgen Løland
>            Priority: Minor
>         Attachments: derby-3003-1.diff, derby-3003-1.stat
>
>
> The javadoc for java.io.DataInput.skipBytes(int) says (<URL:http://java.sun.com/javase/6/docs/api/java/io/DataInput.html#skipBytes(int)>):
> >  This method never throws an EOFException.
> The implementation of this method in org.apache.derby.iapi.services.io.ArrayInputStream says:
> 		if ((position + n) > end) {
> 			throw new EOFException();
> 		}
> The method in ArrayInputStream should be changed so that it skips as many bytes as possible (max n) and returns the actual number of bytes skipped, even when EOF is reached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (DERBY-3003) ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland reassigned DERBY-3003:
------------------------------------

    Assignee: Jørgen Løland

> ArrayInputStream.skipBytes() may throw EOFException which is disallowed by java.io.DataInput
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3003
>                 URL: https://issues.apache.org/jira/browse/DERBY-3003
>             Project: Derby
>          Issue Type: Bug
>          Components: Services
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Jørgen Løland
>            Priority: Minor
>
> The javadoc for java.io.DataInput.skipBytes(int) says (<URL:http://java.sun.com/javase/6/docs/api/java/io/DataInput.html#skipBytes(int)>):
> >  This method never throws an EOFException.
> The implementation of this method in org.apache.derby.iapi.services.io.ArrayInputStream says:
> 		if ((position + n) > end) {
> 			throw new EOFException();
> 		}
> The method in ArrayInputStream should be changed so that it skips as many bytes as possible (max n) and returns the actual number of bytes skipped, even when EOF is reached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.