You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/11/29 12:02:43 UTC
[commons-numbers] branch master updated (f473b68 -> 5791e5b)
This is an automated email from the ASF dual-hosted git repository.
erans pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git.
from f473b68 Common constants for angles in radians.
new 017e038 Order of arguments in Junit assertions.
new fc1291e Javadoc.
new 5791e5b Alias should call "primary" method.
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../numbers/angle/PlaneAngleRadiansTest.java | 42 +++++++++++-----------
.../commons/numbers/fraction/BigFraction.java | 7 ++--
.../commons/numbers/quaternion/Quaternion.java | 2 +-
3 files changed, 24 insertions(+), 27 deletions(-)
[commons-numbers] 03/03: Alias should call "primary" method.
Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 5791e5b0ff2c2056b22481ef513ddef86de6ddad
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Fri Nov 29 13:01:38 2019 +0100
Alias should call "primary" method.
Reported by "sonarcloud.io".
---
.../src/main/java/org/apache/commons/numbers/quaternion/Quaternion.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Quaternion.java b/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Quaternion.java
index 5087881..1bfbc46 100644
--- a/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Quaternion.java
+++ b/commons-numbers-quaternion/src/main/java/org/apache/commons/numbers/quaternion/Quaternion.java
@@ -598,7 +598,7 @@ public final class Quaternion implements Serializable {
* @see #getW()
*/
public double getScalarPart() {
- return w;
+ return getW();
}
/**
[commons-numbers] 02/03: Javadoc.
Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit fc1291e1adb97705d1100cff43f8a8e3a32bad86
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Fri Nov 29 12:52:09 2019 +0100
Javadoc.
---
.../main/java/org/apache/commons/numbers/fraction/BigFraction.java | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
index fafa8c7..6484611 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
@@ -41,13 +41,10 @@ public final class BigFraction
/** Serializable version identifier. */
private static final long serialVersionUID = 20190701L;
- /**
- * The numerator of this fraction reduced to lowest terms. Negative if this
- * fraction's value is negative.
- */
+ /** The numerator of this fraction reduced to lowest terms. */
private final BigInteger numerator;
- /** The denominator of this fraction reduced to lowest terms. Always positive. */
+ /** The denominator of this fraction reduced to lowest terms. */
private final BigInteger denominator;
/**
[commons-numbers] 01/03: Order of arguments in Junit assertions.
Posted by er...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 017e03819b61b00ec702ede9264892b849b8b9a9
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Fri Nov 29 12:44:11 2019 +0100
Order of arguments in Junit assertions.
Reported by "sonarcloud.io".
---
.../numbers/angle/PlaneAngleRadiansTest.java | 42 +++++++++++-----------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
index 73c3168..8840a3b 100644
--- a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
+++ b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleRadiansTest.java
@@ -27,16 +27,16 @@ public class PlaneAngleRadiansTest {
public void testConstants() {
final double eps = 0;
- Assertions.assertEquals(PlaneAngleRadians.PI, Math.PI, eps);
- Assertions.assertEquals(PlaneAngleRadians.MINUS_PI, -Math.PI, eps);
+ Assertions.assertEquals(Math.PI, PlaneAngleRadians.PI, eps);
+ Assertions.assertEquals(-Math.PI, PlaneAngleRadians.MINUS_PI, eps);
- Assertions.assertEquals(PlaneAngleRadians.TWO_PI, 2 * Math.PI, eps);
- Assertions.assertEquals(PlaneAngleRadians.MINUS_TWO_PI, -2 * Math.PI, eps);
+ Assertions.assertEquals(2 * Math.PI, PlaneAngleRadians.TWO_PI, eps);
+ Assertions.assertEquals(-2 * Math.PI, PlaneAngleRadians.MINUS_TWO_PI, eps);
- Assertions.assertEquals(PlaneAngleRadians.PI_OVER_TWO, Math.PI / 2, eps);
- Assertions.assertEquals(PlaneAngleRadians.MINUS_PI_OVER_TWO, -Math.PI / 2, eps);
+ Assertions.assertEquals(Math.PI / 2, PlaneAngleRadians.PI_OVER_TWO, eps);
+ Assertions.assertEquals(-Math.PI / 2, PlaneAngleRadians.MINUS_PI_OVER_TWO, eps);
- Assertions.assertEquals(PlaneAngleRadians.THREE_PI_OVER_TWO, 3 * Math.PI / 2, eps);
+ Assertions.assertEquals(3 * Math.PI / 2, PlaneAngleRadians.THREE_PI_OVER_TWO, eps);
}
// Test constants using "sin" and "cos".
@@ -44,26 +44,26 @@ public class PlaneAngleRadiansTest {
public void testConstants2() {
final double eps = Math.ulp(1d);
- Assertions.assertEquals(Math.sin(PlaneAngleRadians.PI), 0d, eps);
- Assertions.assertEquals(Math.cos(PlaneAngleRadians.PI), -1d, eps);
+ Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.PI), eps);
+ Assertions.assertEquals(-1d, Math.cos(PlaneAngleRadians.PI), eps);
- Assertions.assertEquals(Math.sin(PlaneAngleRadians.MINUS_PI), 0d, eps);
- Assertions.assertEquals(Math.cos(PlaneAngleRadians.MINUS_PI), -1d, eps);
+ Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.MINUS_PI), eps);
+ Assertions.assertEquals(-1d, Math.cos(PlaneAngleRadians.MINUS_PI), eps);
- Assertions.assertEquals(Math.sin(PlaneAngleRadians.TWO_PI), 0d, 2 * eps);
- Assertions.assertEquals(Math.cos(PlaneAngleRadians.TWO_PI), 1d, eps);
+ Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.TWO_PI), 2 * eps);
+ Assertions.assertEquals(1d, Math.cos(PlaneAngleRadians.TWO_PI), eps);
- Assertions.assertEquals(Math.sin(PlaneAngleRadians.MINUS_TWO_PI), 0d, 2 * eps);
- Assertions.assertEquals(Math.cos(PlaneAngleRadians.MINUS_TWO_PI), 1d, eps);
+ Assertions.assertEquals(0d, Math.sin(PlaneAngleRadians.MINUS_TWO_PI), 2 * eps);
+ Assertions.assertEquals(1d, Math.cos(PlaneAngleRadians.MINUS_TWO_PI), eps);
- Assertions.assertEquals(Math.sin(PlaneAngleRadians.PI_OVER_TWO), 1d, eps);
- Assertions.assertEquals(Math.cos(PlaneAngleRadians.PI_OVER_TWO), 0d, eps);
+ Assertions.assertEquals(1d, Math.sin(PlaneAngleRadians.PI_OVER_TWO), eps);
+ Assertions.assertEquals(0d, Math.cos(PlaneAngleRadians.PI_OVER_TWO), eps);
- Assertions.assertEquals(Math.sin(PlaneAngleRadians.MINUS_PI_OVER_TWO), -1d, eps);
- Assertions.assertEquals(Math.cos(PlaneAngleRadians.MINUS_PI_OVER_TWO), 0d, eps);
+ Assertions.assertEquals(-1d, Math.sin(PlaneAngleRadians.MINUS_PI_OVER_TWO), eps);
+ Assertions.assertEquals(0d, Math.cos(PlaneAngleRadians.MINUS_PI_OVER_TWO), eps);
- Assertions.assertEquals(Math.sin(PlaneAngleRadians.THREE_PI_OVER_TWO), -1d, eps);
- Assertions.assertEquals(Math.cos(PlaneAngleRadians.THREE_PI_OVER_TWO), 0d, eps);
+ Assertions.assertEquals(-1d, Math.sin(PlaneAngleRadians.THREE_PI_OVER_TWO), eps);
+ Assertions.assertEquals(0d, Math.cos(PlaneAngleRadians.THREE_PI_OVER_TWO), eps);
}
@Test