You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2023/02/09 22:51:26 UTC
[GitHub] [spark] ueshin opened a new pull request, #39957: [SPARK-42338][CONNECT] Add details to non-fatal errors to raise a proper exception in the Python client
ueshin opened a new pull request, #39957:
URL: https://github.com/apache/spark/pull/39957
### What changes were proposed in this pull request?
Adds details to non-fatal errors to raise a proper exception in the Python client, which makes `df.sample` raise `IllegalArgumentException` as same as PySpark, except for the timing that is delayed to call actions.
### Why are the changes needed?
Currently `SparkConnectService` does not add details for `NonFatal` exceptions to the `PRCStatus`, so the Python client can't detect the exception properly and raises `SparkConnectGrpcException` instead.
It also should have the details for the Python client.
### Does this PR introduce _any_ user-facing change?
Users will see a proper exception when they call `df.sample` with illegal arguments, but in a different timing.
### How was this patch tested?
Enabled `DataFrameParityTests.test_sample`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39957: [SPARK-42338][CONNECT] Add details to non-fatal errors to raise a proper exception in the Python client
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #39957:
URL: https://github.com/apache/spark/pull/39957#issuecomment-1424987255
Connect tests passed. Let me merge this one (so I can update my Pr).
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on pull request #39957: [SPARK-42338][CONNECT] Add details to non-fatal errors to raise a proper exception in the Python client
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #39957:
URL: https://github.com/apache/spark/pull/39957#issuecomment-1424947407
cc @itholic @HyukjinKwon @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39957: [SPARK-42338][CONNECT] Add details to non-fatal errors to raise a proper exception in the Python client
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #39957: [SPARK-42338][CONNECT] Add details to non-fatal errors to raise a proper exception in the Python client
URL: https://github.com/apache/spark/pull/39957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org