[jira] [Commented] (HBASE-23707) Add IntelliJ check style plugin configuration

["Mingliang Liu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097167#comment-17097167 ] 

Mingliang Liu commented on HBASE-23707:
---------------------------------------

[~ndimiduk]
{quote}
What happens when you select the root pom.xml instead of just the folder? Does it detect the maven model type?
{quote}
I tried this as well, no it does not work. I also run 'mvn clean package -DskipTests' first before open/import, and still does not help. So it seems this ".idea" directory just makes import (directory or {{pom.xml}}) stop working correctly. I would believe this is IntelliJ version dependent, since it's IntelliJ who makes the decision how to initializes a new project from source with existent ".idea" director.

{quote}
Maybe we need to commit another file from .idea directory, one that specifies the project type?
{quote}
This seems a good idea, but I do not know what this could be. Also, this could still be IntelliJ version dependent? On my current IntelliJ, I have following files in ".idea"
{code}
$ ls -l .idea
-rw-r--r--    1 mingliang.liu  wheel   159B Apr 25 16:15 $CACHE_FILE$
-rw-r--r--    1 mingliang.liu  wheel   917B Apr 26 21:44 checkstyle-idea.xml
-rw-r--r--    1 mingliang.liu  wheel   6.6K Apr 25 16:16 compiler.xml
-rw-r--r--    1 mingliang.liu  wheel   3.4K Apr 25 16:16 encodings.xml
-rw-r--r--    1 mingliang.liu  wheel   874B Apr 25 16:16 jarRepositories.xml
drwxr-xr-x  234 mingliang.liu  wheel   7.3K Apr 25 16:16 libraries/
-rw-r--r--    1 mingliang.liu  wheel   384B Apr 25 16:15 misc.xml
-rw-r--r--    1 mingliang.liu  wheel   6.8K Apr 25 16:16 modules.xml
-rw-r--r--    1 mingliang.liu  wheel   180B Apr 25 16:15 vcs.xml
-rw-r--r--    1 mingliang.liu  wheel    14K Apr 27 02:27 workspace.xml
{code}

The last resort is to keep this file, but we put this plugin setting file into the "dev-support/ " directory. And we can kindly ask developer to replace the ".idea/checkstyle-idea.xml" with "dev-support/idea/checkstyle-idea.xml" file manually after importing project. This can be written in the book.

> Add IntelliJ check style plugin configuration
> ---------------------------------------------
>
>                 Key: HBASE-23707
>                 URL: https://issues.apache.org/jira/browse/HBASE-23707
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.3.0, 1.6.0
>
>
> IntelliJ defines project configuration across a number of files, specifically so that some configurations can be committed with the source repository. The checkstyle plugin configuration is one such config file; add it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)