You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Denis Balazuc (JIRA)" <no...@atlassian.com> on 2007/05/18 00:10:55 UTC
[Roller-JIRA] Created: (ROL-1429) Enabled flag passed in the
UserData constructor is ignored
Enabled flag passed in the UserData constructor is ignored
----------------------------------------------------------
Key: ROL-1429
URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1429
Project: Roller
Issue Type: Bug
Reporter: Denis Balazuc
Assignee: Roller Unassigned
Priority: Minor
org.apache.roller.pojos.UserData contains a minor typo in its constructor which causes the Boolean isEnabled parameter to be ignored.
The member variable "enabled" is affected to itself, which defaults to TRUE.
public UserData( String id, String userName,
String password, String fullName,
String emailAddress,
String locale, String timeZone,
Date dateCreated,
Boolean isEnabled) {
[SNIP]
this.enabled = enabled;
}
It is suspected that this is a bug, although, analyzing the usage of this constructor shows that only UserData.SYSTEM_USER and UserData.ANONYMOUS_USER seem to be using it, so it seems that this bug has no functional impact.
A small patch is attached to solve this error.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Roller-JIRA] Commented: (ROL-1429) Enabled flag passed in the
UserData constructor is ignored
Posted by "Allen Gilliland (JIRA)" <no...@atlassian.com>.
[ http://opensource.atlassian.com/projects/roller/browse/ROL-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_13770 ]
Allen Gilliland commented on ROL-1429:
--------------------------------------
i am looking at revision 540742 of the trunk and this bug doesn't exist, so it won't show up in a future release.
> Enabled flag passed in the UserData constructor is ignored
> ----------------------------------------------------------
>
> Key: ROL-1429
> URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1429
> Project: Roller
> Issue Type: Bug
> Reporter: Denis Balazuc
> Assignee: Roller Unassigned
> Priority: Minor
> Attachments: UserData-constructor-enabled-patch-3.1.txt
>
>
> org.apache.roller.pojos.UserData contains a minor typo in its constructor which causes the Boolean isEnabled parameter to be ignored.
> The member variable "enabled" is affected to itself, which defaults to TRUE.
> public UserData( String id, String userName,
> String password, String fullName,
> String emailAddress,
> String locale, String timeZone,
> Date dateCreated,
> Boolean isEnabled) {
> [SNIP]
> this.enabled = enabled;
> }
> It is suspected that this is a bug, although, analyzing the usage of this constructor shows that only UserData.SYSTEM_USER and UserData.ANONYMOUS_USER seem to be using it, so it seems that this bug has no functional impact.
> A small patch is attached to solve this error.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Roller-JIRA] Updated: (ROL-1429) Enabled flag passed in the
UserData constructor is ignored
Posted by "Denis Balazuc (JIRA)" <no...@atlassian.com>.
[ http://opensource.atlassian.com/projects/roller/browse/ROL-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Balazuc updated ROL-1429:
-------------------------------
Attachment: UserData-constructor-enabled-patch-3.1.txt
Replaces
"this.enabled = enabled"
by
"this.enabled = isEnabled"
in the constructor of UserData.java
isEnabled is the parameter passed to the constructor and was ignored, causing "this.enabled" to always be set to TRUE when using this constructor.
> Enabled flag passed in the UserData constructor is ignored
> ----------------------------------------------------------
>
> Key: ROL-1429
> URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1429
> Project: Roller
> Issue Type: Bug
> Reporter: Denis Balazuc
> Assignee: Roller Unassigned
> Priority: Minor
> Attachments: UserData-constructor-enabled-patch-3.1.txt
>
>
> org.apache.roller.pojos.UserData contains a minor typo in its constructor which causes the Boolean isEnabled parameter to be ignored.
> The member variable "enabled" is affected to itself, which defaults to TRUE.
> public UserData( String id, String userName,
> String password, String fullName,
> String emailAddress,
> String locale, String timeZone,
> Date dateCreated,
> Boolean isEnabled) {
> [SNIP]
> this.enabled = enabled;
> }
> It is suspected that this is a bug, although, analyzing the usage of this constructor shows that only UserData.SYSTEM_USER and UserData.ANONYMOUS_USER seem to be using it, so it seems that this bug has no functional impact.
> A small patch is attached to solve this error.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Roller-JIRA] Commented: (ROL-1429) Enabled flag passed in the
UserData constructor is ignored
Posted by "Denis Balazuc (JIRA)" <no...@atlassian.com>.
[ http://opensource.atlassian.com/projects/roller/browse/ROL-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_13754 ]
Denis Balazuc commented on ROL-1429:
------------------------------------
I forgot to mention that this is for the current 3.1 version. The affected file can be found at
https://svn.apache.org/repos/asf/roller/branches/roller_3.1/src/org/apache/roller/pojos/UserData.java
> Enabled flag passed in the UserData constructor is ignored
> ----------------------------------------------------------
>
> Key: ROL-1429
> URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1429
> Project: Roller
> Issue Type: Bug
> Reporter: Denis Balazuc
> Assignee: Roller Unassigned
> Priority: Minor
> Attachments: UserData-constructor-enabled-patch-3.1.txt
>
>
> org.apache.roller.pojos.UserData contains a minor typo in its constructor which causes the Boolean isEnabled parameter to be ignored.
> The member variable "enabled" is affected to itself, which defaults to TRUE.
> public UserData( String id, String userName,
> String password, String fullName,
> String emailAddress,
> String locale, String timeZone,
> Date dateCreated,
> Boolean isEnabled) {
> [SNIP]
> this.enabled = enabled;
> }
> It is suspected that this is a bug, although, analyzing the usage of this constructor shows that only UserData.SYSTEM_USER and UserData.ANONYMOUS_USER seem to be using it, so it seems that this bug has no functional impact.
> A small patch is attached to solve this error.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira