You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/02 18:37:22 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9943: style(mypy): Enforcing typing for superset module
codecov-commenter edited a comment on pull request #9943:
URL: https://github.com/apache/incubator-superset/pull/9943#issuecomment-635801592
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=h1) Report
> Merging [#9943](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b296a0f250979bf70e9cb2a2a2b48fd10038a363&el=desc) will **decrease** coverage by `4.99%`.
> The diff coverage is `83.08%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9943/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9943 +/- ##
==========================================
- Coverage 71.31% 66.31% -5.00%
==========================================
Files 585 585
Lines 30887 30851 -36
Branches 3236 3246 +10
==========================================
- Hits 22027 20460 -1567
- Misses 8750 10212 +1462
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.02%)` | :arrow_down: |
| #python | `71.20% <83.08%> (-0.34%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.00% <40.00%> (-1.74%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <79.33%> (-0.03%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.51% <80.76%> (+0.15%)` | :arrow_up: |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `95.45% <87.50%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.06% <95.00%> (+0.20%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.75% <100.00%> (+0.08%)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | `95.45% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.35% <100.00%> (+0.09%)` | :arrow_up: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9943/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=footer). Last update [b296a0f...6bcbf55](https://codecov.io/gh/apache/incubator-superset/pull/9943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org