[GitHub] [apisix-ingress-controller] navendu-pottekkat commented on a diff in pull request #1399: docs: update annotations page

[GitBox <gi...@apache.org>]

navendu-pottekkat commented on code in PR #1399:
URL: https://github.com/apache/apisix-ingress-controller/pull/1399#discussion_r1002662646


##########
docs/en/latest/config.json:
##########
@@ -60,10 +60,13 @@
         "concepts/apisix_route",
         "concepts/apisix_upstream",
         "concepts/apisix_tls",
-        "concepts/apisix_cluster_config",
-        "concepts/annotations"
+        "concepts/apisix_cluster_config"
       ]
     },
+    {
+      "type": "doc",
+      "id": "annotations"
+    },

Review Comment:
   Annotations are used in Kubernetes native Ingress resource while rest of the concepts is specific to APISIX's CRDs. IMO, annotations are a different entity. And it does not belong together with the concepts. I'm just thinking this out loud. Would like to hear your thoughts on this as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org