You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by sh...@apache.org on 2009/04/14 09:15:16 UTC

svn commit: r764691 - /lucene/solr/trunk/contrib/dataimporthandler/src/extras/main/java/org/apache/solr/handler/dataimport/MailEntityProcessor.java

Author: shalin
Date: Tue Apr 14 07:15:16 2009
New Revision: 764691

URL: http://svn.apache.org/viewvc?rev=764691&view=rev
Log:
SOLR-934 followup -- Make CustomFilter static, remove extra logging code, check log level before logging

Modified:
    lucene/solr/trunk/contrib/dataimporthandler/src/extras/main/java/org/apache/solr/handler/dataimport/MailEntityProcessor.java

Modified: lucene/solr/trunk/contrib/dataimporthandler/src/extras/main/java/org/apache/solr/handler/dataimport/MailEntityProcessor.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/contrib/dataimporthandler/src/extras/main/java/org/apache/solr/handler/dataimport/MailEntityProcessor.java?rev=764691&r1=764690&r2=764691&view=diff
==============================================================================
--- lucene/solr/trunk/contrib/dataimporthandler/src/extras/main/java/org/apache/solr/handler/dataimport/MailEntityProcessor.java (original)
+++ lucene/solr/trunk/contrib/dataimporthandler/src/extras/main/java/org/apache/solr/handler/dataimport/MailEntityProcessor.java Tue Apr 14 07:15:16 2009
@@ -46,7 +46,7 @@
  */
 public class MailEntityProcessor extends EntityProcessorBase {
 
-  public interface CustomFilter {
+  public static interface CustomFilter {
     public SearchTerm getCustomSearch(Folder folder);
   }
 
@@ -107,7 +107,6 @@
     while (row == null && mail != null);
     if (row != null) {
       row = super.applyTransformer(row);
-      logRow(row);
     }
     return row;
   }
@@ -287,6 +286,7 @@
   }
 
   private void logConfig() {
+    if (!LOG.isInfoEnabled()) return;
     StringBuffer config = new StringBuffer();
     config.append("user : ").append(user).append(System.getProperty("line.separator"));
     config.append("pwd : ").append(password).append(System.getProperty("line.separator"));
@@ -305,15 +305,6 @@
     LOG.info(config.toString());
   }
 
-  private void logRow(Map<String, Object> row) {
-    StringBuffer config = new StringBuffer();
-    String from = row.get(FROM) == null ? "" : row.get(FROM).toString();
-    String to = row.get(TO_CC_BCC) == null ? "" : row.get(TO_CC_BCC).toString();
-    String subject = row.get(SUBJECT) == null ? "" : row.get(SUBJECT).toString();
-    config.append("From: ").append(from).append("To: ").append(to).append(" " + "Subject: ").append(subject);
-    LOG.debug("ROW " + (rowCount++) + ": " + config.toString());
-  }
-
   class FolderIterator implements Iterator<Folder> {
     private Store mailbox;
     private List<String> topLevelFolders;