You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Andy Gumbrecht <ag...@tomitribe.com> on 2016/03/11 18:48:40 UTC
Mass cleanup
I would like to run a project wide intellij driven cleanup. No fixes,
just a big cleanup across the board.
It'll be one big commit.
Any objections?
--
Andy Gumbrecht
https://twitter.com/AndyGeeDe
http://www.tomitribe.com
Re: Mass cleanup
Posted by Andy <an...@gmx.de>.
Yep, this works for me. Something that sets a baseline for everyone to
work towards together is cool.
On 14/03/2016 17:28, Mark Struberg wrote:
> https://issues.apache.org/jira/browse/INFRA-11460
>
>
> LieGrue,
> strub
>
--
Andy Gumbrecht
https://twitter.com/AndyGeeDe
Re: Mass cleanup
Posted by Mark Struberg <st...@yahoo.de>.
https://issues.apache.org/jira/browse/INFRA-11460
LieGrue,
strub
Re: Mass cleanup
Posted by Mark Struberg <st...@yahoo.de>.
I'll try to get a sonar job for us.
LieGrue,strub
On Saturday, 12 March 2016, 23:24, Jean-Louis Monteiro <jl...@tomitribe.com> wrote:
+1 let's have the analysis tool set and have a base line. Then as Mark
mentioned work on the rule set and fix.
Intellij warnings are sometimes totally irrelevant. Or just I don't like
the code style. Obviously totally personal but just to mention that I'm not
convinced by a massive changes.
Le 12 mars 2016 20:49, "Mark Struberg" <st...@yahoo.de> a écrit :
> yes, fear so as well.
> What _would_ help is to enable sonar for TomEE?
>
> https://analysis.apache.org/dashboard/index/12686
>
> And then go through the rules which make the most sense and clean that
> parts up?
>
> LieGrue,
> strub
>
>
> > Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau <rmannibucau@gmail.com
> >:
> >
> > Then -1 for code "guess" of Idea. A lot of false positives so it pollutes
> > code and when you read it then you wonder how it can happen where it
> can't
> > in reality.
> >
> > For final and variable inits I don't like commits with that cause it
> moves
> > the code in general and make comparisons between versions/revisions hard
> > (don't care much about inline "final" addition but care if you need to
> > change line numbers for that).
> >
> >
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
> > 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> >
> >> Nothing to do with formatting. The goal is to get the intellij green
> tick
> >> on files rather than red or orange. Trivial global things like finals,
> 'may
> >> produce nullpointer' and variable inits etc.
> >>
> >>
> >> On 11/03/2016 18:53, Romain Manni-Bucau wrote:
> >>
> >> Hi Andy,
> >>
> >> what's the goal? Thought we finished with any cleanup and decided to not
> >> do it anymore last year.
> >>
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >> <http://rmannibucau.wordpress.com> | Github
> >> <https://github.com/rmannibucau> | LinkedIn
> >> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> >> <http://www.tomitribe.com>
> >>
> >> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> >>
> >>> I would like to run a project wide intellij driven cleanup. No fixes,
> >>> just a big cleanup across the board.
> >>> It'll be one big commit.
> >>>
> >>> Any objections?
> >>>
> >>> --
> >>> Andy Gumbrecht
> >>> https://twitter.com/AndyGeeDe
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>
> >> --
> >> Andy Gumbrecht
> >> https://twitter.com/AndyGeeDe
> >> http://www.tomitribe.com
> >>
> >>
>
>
Re: Mass cleanup
Posted by Jean-Louis Monteiro <jl...@tomitribe.com>.
+1 let's have the analysis tool set and have a base line. Then as Mark
mentioned work on the rule set and fix.
Intellij warnings are sometimes totally irrelevant. Or just I don't like
the code style. Obviously totally personal but just to mention that I'm not
convinced by a massive changes.
Le 12 mars 2016 20:49, "Mark Struberg" <st...@yahoo.de> a écrit :
> yes, fear so as well.
> What _would_ help is to enable sonar for TomEE?
>
> https://analysis.apache.org/dashboard/index/12686
>
> And then go through the rules which make the most sense and clean that
> parts up?
>
> LieGrue,
> strub
>
>
> > Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau <rmannibucau@gmail.com
> >:
> >
> > Then -1 for code "guess" of Idea. A lot of false positives so it pollutes
> > code and when you read it then you wonder how it can happen where it
> can't
> > in reality.
> >
> > For final and variable inits I don't like commits with that cause it
> moves
> > the code in general and make comparisons between versions/revisions hard
> > (don't care much about inline "final" addition but care if you need to
> > change line numbers for that).
> >
> >
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
> > 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> >
> >> Nothing to do with formatting. The goal is to get the intellij green
> tick
> >> on files rather than red or orange. Trivial global things like finals,
> 'may
> >> produce nullpointer' and variable inits etc.
> >>
> >>
> >> On 11/03/2016 18:53, Romain Manni-Bucau wrote:
> >>
> >> Hi Andy,
> >>
> >> what's the goal? Thought we finished with any cleanup and decided to not
> >> do it anymore last year.
> >>
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >> <http://rmannibucau.wordpress.com> | Github
> >> <https://github.com/rmannibucau> | LinkedIn
> >> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> >> <http://www.tomitribe.com>
> >>
> >> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> >>
> >>> I would like to run a project wide intellij driven cleanup. No fixes,
> >>> just a big cleanup across the board.
> >>> It'll be one big commit.
> >>>
> >>> Any objections?
> >>>
> >>> --
> >>> Andy Gumbrecht
> >>> https://twitter.com/AndyGeeDe
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>
> >> --
> >> Andy Gumbrecht
> >> https://twitter.com/AndyGeeDe
> >> http://www.tomitribe.com
> >>
> >>
>
>
Re: Mass cleanup
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+0 if anything is justified and motivated. -1 to only run after making
tools green
Le 12 mars 2016 20:56, "Raquel Pau Fernández" <ra...@gmail.com> a
écrit :
> Hi,
>
> In case of using Sonar, walkmod (walkmod.com - an open source tool) could
> help you to automatically fix some sonar violations. The Github url of the
> sonar plugin is https://github.com/walkmod/walkmod-sonar-plugin
>
> Raquel
>
> 2016-03-12 20:49 GMT+01:00 Mark Struberg <st...@yahoo.de>:
>
> > yes, fear so as well.
> > What _would_ help is to enable sonar for TomEE?
> >
> > https://analysis.apache.org/dashboard/index/12686
> >
> > And then go through the rules which make the most sense and clean that
> > parts up?
> >
> > LieGrue,
> > strub
> >
> >
> > > Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau <
> rmannibucau@gmail.com
> > >:
> > >
> > > Then -1 for code "guess" of Idea. A lot of false positives so it
> pollutes
> > > code and when you read it then you wonder how it can happen where it
> > can't
> > > in reality.
> > >
> > > For final and variable inits I don't like commits with that cause it
> > moves
> > > the code in general and make comparisons between versions/revisions
> hard
> > > (don't care much about inline "final" addition but care if you need to
> > > change line numbers for that).
> > >
> > >
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > <http://www.tomitribe.com>
> > >
> > > 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> > >
> > >> Nothing to do with formatting. The goal is to get the intellij green
> > tick
> > >> on files rather than red or orange. Trivial global things like finals,
> > 'may
> > >> produce nullpointer' and variable inits etc.
> > >>
> > >>
> > >> On 11/03/2016 18:53, Romain Manni-Bucau wrote:
> > >>
> > >> Hi Andy,
> > >>
> > >> what's the goal? Thought we finished with any cleanup and decided to
> not
> > >> do it anymore last year.
> > >>
> > >>
> > >> Romain Manni-Bucau
> > >> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > >> <http://rmannibucau.wordpress.com> | Github
> > >> <https://github.com/rmannibucau> | LinkedIn
> > >> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > >> <http://www.tomitribe.com>
> > >>
> > >> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> > >>
> > >>> I would like to run a project wide intellij driven cleanup. No fixes,
> > >>> just a big cleanup across the board.
> > >>> It'll be one big commit.
> > >>>
> > >>> Any objections?
> > >>>
> > >>> --
> > >>> Andy Gumbrecht
> > >>> https://twitter.com/AndyGeeDe
> > >>> http://www.tomitribe.com
> > >>>
> > >>>
> > >>
> > >> --
> > >> Andy Gumbrecht
> > >> https://twitter.com/AndyGeeDe
> > >> http://www.tomitribe.com
> > >>
> > >>
> >
> >
>
>
> --
> Raquel Pau
>
> *"Education is the most powerful weapon which you can use to change the
> world**"*
>
> Nelson Mandela
>
Re: Mass cleanup
Posted by Raquel Pau Fernández <ra...@gmail.com>.
Hi,
In case of using Sonar, walkmod (walkmod.com - an open source tool) could
help you to automatically fix some sonar violations. The Github url of the
sonar plugin is https://github.com/walkmod/walkmod-sonar-plugin
Raquel
2016-03-12 20:49 GMT+01:00 Mark Struberg <st...@yahoo.de>:
> yes, fear so as well.
> What _would_ help is to enable sonar for TomEE?
>
> https://analysis.apache.org/dashboard/index/12686
>
> And then go through the rules which make the most sense and clean that
> parts up?
>
> LieGrue,
> strub
>
>
> > Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau <rmannibucau@gmail.com
> >:
> >
> > Then -1 for code "guess" of Idea. A lot of false positives so it pollutes
> > code and when you read it then you wonder how it can happen where it
> can't
> > in reality.
> >
> > For final and variable inits I don't like commits with that cause it
> moves
> > the code in general and make comparisons between versions/revisions hard
> > (don't care much about inline "final" addition but care if you need to
> > change line numbers for that).
> >
> >
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > <http://www.tomitribe.com>
> >
> > 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> >
> >> Nothing to do with formatting. The goal is to get the intellij green
> tick
> >> on files rather than red or orange. Trivial global things like finals,
> 'may
> >> produce nullpointer' and variable inits etc.
> >>
> >>
> >> On 11/03/2016 18:53, Romain Manni-Bucau wrote:
> >>
> >> Hi Andy,
> >>
> >> what's the goal? Thought we finished with any cleanup and decided to not
> >> do it anymore last year.
> >>
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >> <http://rmannibucau.wordpress.com> | Github
> >> <https://github.com/rmannibucau> | LinkedIn
> >> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> >> <http://www.tomitribe.com>
> >>
> >> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> >>
> >>> I would like to run a project wide intellij driven cleanup. No fixes,
> >>> just a big cleanup across the board.
> >>> It'll be one big commit.
> >>>
> >>> Any objections?
> >>>
> >>> --
> >>> Andy Gumbrecht
> >>> https://twitter.com/AndyGeeDe
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>
> >> --
> >> Andy Gumbrecht
> >> https://twitter.com/AndyGeeDe
> >> http://www.tomitribe.com
> >>
> >>
>
>
--
Raquel Pau
*"Education is the most powerful weapon which you can use to change the
world**"*
Nelson Mandela
Re: Mass cleanup
Posted by Mark Struberg <st...@yahoo.de>.
yes, fear so as well.
What _would_ help is to enable sonar for TomEE?
https://analysis.apache.org/dashboard/index/12686
And then go through the rules which make the most sense and clean that parts up?
LieGrue,
strub
> Am 11.03.2016 um 19:44 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> Then -1 for code "guess" of Idea. A lot of false positives so it pollutes
> code and when you read it then you wonder how it can happen where it can't
> in reality.
>
> For final and variable inits I don't like commits with that cause it moves
> the code in general and make comparisons between versions/revisions hard
> (don't care much about inline "final" addition but care if you need to
> change line numbers for that).
>
>
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
>
>> Nothing to do with formatting. The goal is to get the intellij green tick
>> on files rather than red or orange. Trivial global things like finals, 'may
>> produce nullpointer' and variable inits etc.
>>
>>
>> On 11/03/2016 18:53, Romain Manni-Bucau wrote:
>>
>> Hi Andy,
>>
>> what's the goal? Thought we finished with any cleanup and decided to not
>> do it anymore last year.
>>
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> | LinkedIn
>> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
>> <http://www.tomitribe.com>
>>
>> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
>>
>>> I would like to run a project wide intellij driven cleanup. No fixes,
>>> just a big cleanup across the board.
>>> It'll be one big commit.
>>>
>>> Any objections?
>>>
>>> --
>>> Andy Gumbrecht
>>> https://twitter.com/AndyGeeDe
>>> http://www.tomitribe.com
>>>
>>>
>>
>> --
>> Andy Gumbrecht
>> https://twitter.com/AndyGeeDe
>> http://www.tomitribe.com
>>
>>
Re: Mass cleanup
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Then -1 for code "guess" of Idea. A lot of false positives so it pollutes
code and when you read it then you wonder how it can happen where it can't
in reality.
For final and variable inits I don't like commits with that cause it moves
the code in general and make comparisons between versions/revisions hard
(don't care much about inline "final" addition but care if you need to
change line numbers for that).
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>
2016-03-11 19:33 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> Nothing to do with formatting. The goal is to get the intellij green tick
> on files rather than red or orange. Trivial global things like finals, 'may
> produce nullpointer' and variable inits etc.
>
>
> On 11/03/2016 18:53, Romain Manni-Bucau wrote:
>
> Hi Andy,
>
> what's the goal? Thought we finished with any cleanup and decided to not
> do it anymore last year.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
>
>> I would like to run a project wide intellij driven cleanup. No fixes,
>> just a big cleanup across the board.
>> It'll be one big commit.
>>
>> Any objections?
>>
>> --
>> Andy Gumbrecht
>> https://twitter.com/AndyGeeDe
>> http://www.tomitribe.com
>>
>>
>
> --
> Andy Gumbrecht
> https://twitter.com/AndyGeeDe
> http://www.tomitribe.com
>
>
Re: Mass cleanup
Posted by Andy Gumbrecht <ag...@tomitribe.com>.
Nothing to do with formatting. The goal is to get the intellij green
tick on files rather than red or orange. Trivial global things like
finals, 'may produce nullpointer' and variable inits etc.
On 11/03/2016 18:53, Romain Manni-Bucau wrote:
> Hi Andy,
>
> what's the goal? Thought we finished with any cleanup and decided to
> not do it anymore last year.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com>
>
> 2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <agumbrecht@tomitribe.com
> <ma...@tomitribe.com>>:
>
> I would like to run a project wide intellij driven cleanup. No
> fixes, just a big cleanup across the board.
> It'll be one big commit.
>
> Any objections?
>
> --
> Andy Gumbrecht
> https://twitter.com/AndyGeeDe
> http://www.tomitribe.com
>
>
--
Andy Gumbrecht
https://twitter.com/AndyGeeDe
http://www.tomitribe.com
Re: Mass cleanup
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Andy,
what's the goal? Thought we finished with any cleanup and decided to not do
it anymore last year.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
<http://www.tomitribe.com>
2016-03-11 18:48 GMT+01:00 Andy Gumbrecht <ag...@tomitribe.com>:
> I would like to run a project wide intellij driven cleanup. No fixes, just
> a big cleanup across the board.
> It'll be one big commit.
>
> Any objections?
>
> --
> Andy Gumbrecht
> https://twitter.com/AndyGeeDe
> http://www.tomitribe.com
>
>
Re: Mass cleanup
Posted by jieryn <ji...@gmail.com>.
Just an interested party, but driving these changes through a person's
UI is generally not repeatable, even by that person.
Better to use a code formatter that can be pushed into the standard
development pipeline. For example:
http://code.revelc.net/formatter-maven-plugin/format-mojo.html
Which uses Eclipse's ECJ and a standard xml file to handle
configuration, and that xml can be committed to the source code too,
and then everyone can do it and it becomes the source of truth for
formatting.
On Fri, Mar 11, 2016 at 12:48 PM, Andy Gumbrecht
<ag...@tomitribe.com> wrote:
> I would like to run a project wide intellij driven cleanup. No fixes, just a
> big cleanup across the board.
> It'll be one big commit.
>
> Any objections?
>
> --
> Andy Gumbrecht
> https://twitter.com/AndyGeeDe
> http://www.tomitribe.com
>