You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/03/12 20:41:43 UTC
[GitHub] [trafficcontrol] ajschmidt commented on a change in pull request
#3392: Tr default cert
ajschmidt commented on a change in pull request #3392: Tr default cert
URL: https://github.com/apache/trafficcontrol/pull/3392#discussion_r264875091
##########
File path: traffic_router/connector/src/main/java/com/comcast/cdn/traffic_control/traffic_router/protocol/RouterNioEndpoint.java
##########
@@ -69,23 +68,11 @@ synchronized private void replaceSSLHosts(final Map<String, HandshakeData> sslHo
lastHostName = sslHostConfig.getHostName();
}
- if (firstAlias && ! "".equals(alias)) {
+ if (CertificateRegistry.DEFAULT_SSL_KEY.equals(alias)) {
// One of the configs must be set as the default
setDefaultSSLHostConfigName(sslHostConfig.getHostName());
- firstAlias = false;
}
}
-
- }
-
- synchronized public void reloadSSLHosts(final Map<String, HandshakeData> cr) {
- replaceSSLHosts(cr);
-
- for (final HandshakeData data : cr.values()) {
Review comment:
It was never necessary. All of those same steps happen in the `replaceSSLHosts` method and are for some reason repeated again. I just changed the `replaceSSLHosts` to be public and changed the callback to call it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services