[GitHub] [accumulo] ctubbsii commented on a change in pull request #1018: Fix #976 - Expand overly broad Exceptions in Accumulo-core

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1018: Fix #976 - Expand overly broad Exceptions in Accumulo-core
URL: https://github.com/apache/accumulo/pull/1018#discussion_r271505823
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
 ##########
 @@ -286,7 +286,7 @@ public void process(WatchedEvent event) {
                   else if (asyncLock != null)
                     failedToAcquireLock();
                 }
-              } catch (Throwable e) {
+              } catch (KeeperException | InterruptedException e) {
 
 Review comment:
   Could just do `(KeeperException | InterruptedException | RuntimeException e)`. I still think there's merit in no longer catching `Error` and thinking we have any clue how to handle that case (especially with merely logging it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services