You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "haridsv (via GitHub)" <gi...@apache.org> on 2024/08/29 13:24:35 UTC
[PR] PHOENIX-7343: Support ARRAY and JSON types as simple values in CDC [phoenix]
haridsv opened a new pull request, #1965:
URL: https://github.com/apache/phoenix/pull/1965
Added support for complex types ARRAY and JSON so that they are treated at simple values. As they are treated as simple values, changes with n the value will not be detected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7343: Support ARRAY and JSON types as simple values in CDC [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #1965:
URL: https://github.com/apache/phoenix/pull/1965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7343: Support ARRAY and JSON types as simple values in CDC [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #1965:
URL: https://github.com/apache/phoenix/pull/1965#issuecomment-2360013396
@haridsv i am about to merge the PR but just realized the PR has merge conflict, that most likely came from today's changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7343: Support ARRAY and JSON types as simple values in CDC [phoenix]
Posted by "haridsv (via GitHub)" <gi...@apache.org>.
haridsv commented on PR #1965:
URL: https://github.com/apache/phoenix/pull/1965#issuecomment-2360024854
Yes, looks like there is a new binary type added to the condition, I will resolve the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7343: Support ARRAY and JSON types as simple values in CDC [phoenix]
Posted by "haridsv (via GitHub)" <gi...@apache.org>.
haridsv commented on code in PR #1965:
URL: https://github.com/apache/phoenix/pull/1965#discussion_r1766179545
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -257,7 +252,7 @@ private Object getColumnValue(Cell cell, PDataType dataType) {
private Object getColumnValue(byte[] cellValue, int offset, int length, PDataType dataType) {
Object value;
- if (dataType.getSqlType() == Types.BINARY) {
+ if (CDCUtil.isBinaryType(dataType)) {
Review Comment:
This is just a utility method to abstract out the 3 types that we are considering as binary type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7343: Support ARRAY and JSON types as simple values in CDC [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #1965:
URL: https://github.com/apache/phoenix/pull/1965#discussion_r1765236247
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -257,7 +252,7 @@ private Object getColumnValue(Cell cell, PDataType dataType) {
private Object getColumnValue(byte[] cellValue, int offset, int length, PDataType dataType) {
Object value;
- if (dataType.getSqlType() == Types.BINARY) {
+ if (CDCUtil.isBinaryType(dataType)) {
Review Comment:
This is an improvement with this PR, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7343: Support ARRAY and JSON types as simple values in CDC [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #1965:
URL: https://github.com/apache/phoenix/pull/1965#discussion_r1766181500
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -257,7 +252,7 @@ private Object getColumnValue(Cell cell, PDataType dataType) {
private Object getColumnValue(byte[] cellValue, int offset, int length, PDataType dataType) {
Object value;
- if (dataType.getSqlType() == Types.BINARY) {
+ if (CDCUtil.isBinaryType(dataType)) {
Review Comment:
Oh i missed that it was Types.BINARY which anyways apply to them, i think i misunderstood earlier that we only had Binary datatype, and not VARBINARY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org