You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "hoslo (via GitHub)" <gi...@apache.org> on 2025/01/09 09:51:44 UTC

[PR] feat(core): Implement list with deleted and versions for oss [opendal]

hoslo opened a new pull request, #5527:
URL: https://github.com/apache/opendal/pull/5527

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part of #5496 
   
   # Rationale for this change
   
   Implement the oss in RFC we need.
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   Implement list with deleted for oss services
   Implement versions for oss services
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   Users can now list deleted files and user versions from oss services.
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking-changes` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(core): Implement list with deleted and versions for oss [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #5527:
URL: https://github.com/apache/opendal/pull/5527#issuecomment-2586481760

   Hi, @hoslo, I have added a new test case for oss. Would you like to resolve the conflicts and test it again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(core): Implement list with deleted and versions for oss [opendal]

Posted by "codspeed-hq[bot] (via GitHub)" <gi...@apache.org>.
codspeed-hq[bot] commented on PR #5527:
URL: https://github.com/apache/opendal/pull/5527#issuecomment-2579648985

   ## [CodSpeed Performance Report](https://codspeed.io/apache/opendal/branches/oss-list-with-deleted)
   
   ### Merging #5527 will **improve performances by 18.88%**
   
   <sub>Comparing <code>oss-list-with-deleted</code> (60036fc) with <code>main</code> (90c64a1)</sub>
   
   
   
   ### Summary
   
   `⚡ 4` improvements  
   `✅ 69` untouched benchmarks  
   
   
   
   ### Benchmarks breakdown
   
   |     | Benchmark | `main` | `oss-list-with-deleted` | Change |
   | --- | --------- | ----------------------- | ------------------- | ------ |
   | ⚡ | `` buffer 256 KiB * 32 chunk `` | 183.6 ns | 154.4 ns | +18.88% |
   | ⚡ | `` buffer 256 KiB * 4 chunk `` | 183.6 ns | 154.4 ns | +18.88% |
   | ⚡ | `` buffer 4.00 MiB * 32 chunk `` | 183.6 ns | 154.4 ns | +18.88% |
   | ⚡ | `` buffer 4.00 MiB * 4 chunk `` | 183.6 ns | 154.4 ns | +18.88% |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(core): Implement list with deleted and versions for oss [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5527:
URL: https://github.com/apache/opendal/pull/5527


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org