You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/02 09:40:03 UTC
[GitHub] [calcite] chunweilei commented on a change in pull request #1293:
[CALCITE-3165] Project#accept(RexShuttle shuttle) does not update rowType
chunweilei commented on a change in pull request #1293: [CALCITE-3165] Project#accept(RexShuttle shuttle) does not update rowType
URL: https://github.com/apache/calcite/pull/1293#discussion_r299394325
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Project.java
##########
@@ -145,6 +146,12 @@ public RelNode accept(RexShuttle shuttle) {
if (this.exps == exps) {
return this;
}
+ final RelDataType rowType =
+ RexUtil.createStructType(
+ getInput().getCluster().getTypeFactory(),
+ exps,
+ this.rowType.getFieldNames(),
+ SqlValidatorUtil.F_SUGGESTER);
return copy(traitSet, getInput(), exps, rowType);
Review comment:
Good catch, +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services