You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/01/09 18:23:08 UTC
[commons-bcel] branch master updated (2983851 -> c434d6a)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git.
from 2983851 Example should use a IllegalArgumentException.
new 867bcbd The default Maven goal should build the jar (package) instead of just verifying the build (verify).
new c434d6a Clean up unused exceptions in package private code (preserves binary compatibility).
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pom.xml | 2 +-
src/main/java/org/apache/bcel/util/ClassPath.java | 13 +++++++------
2 files changed, 8 insertions(+), 7 deletions(-)
[commons-bcel] 01/02: The default Maven goal should build the jar
(package) instead of just verifying the build (verify).
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit 867bcbd2882cb9faeb169d530e0c11ada583dae5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jan 9 13:21:32 2021 -0500
The default Maven goal should build the jar (package) instead of just
verifying the build (verify).
---
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 771b053..e535918 100644
--- a/pom.xml
+++ b/pom.xml
@@ -213,7 +213,7 @@
</scm>
<build>
- <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean package apache-rat:check japicmp:cmp checkstyle:check javadoc:javadoc</defaultGoal>
<plugins>
<plugin>
<groupId>org.apache.felix</groupId>
[commons-bcel] 02/02: Clean up unused exceptions in package private
code (preserves binary compatibility).
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit c434d6a6f8a92ce40fa0677332eba1c37ac85059
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jan 9 13:23:04 2021 -0500
Clean up unused exceptions in package private code (preserves binary
compatibility).
---
src/main/java/org/apache/bcel/util/ClassPath.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/bcel/util/ClassPath.java b/src/main/java/org/apache/bcel/util/ClassPath.java
index 2af6bf4..794e005 100644
--- a/src/main/java/org/apache/bcel/util/ClassPath.java
+++ b/src/main/java/org/apache/bcel/util/ClassPath.java
@@ -48,7 +48,7 @@ public class ClassPath implements Closeable {
private abstract static class AbstractPathEntry implements Closeable {
- abstract ClassFile getClassFile(String name, String suffix) throws IOException;
+ abstract ClassFile getClassFile(String name, String suffix);
abstract URL getResource(String name);
@@ -72,7 +72,7 @@ public class ClassPath implements Closeable {
}
@Override
- ClassFile getClassFile(final String name, final String suffix) throws IOException {
+ ClassFile getClassFile(final String name, final String suffix) {
final ZipEntry entry = zipFile.getEntry(toEntryName(name, suffix));
if (entry == null) {
@@ -184,7 +184,7 @@ public class ClassPath implements Closeable {
}
@Override
- ClassFile getClassFile(final String name, final String suffix) throws IOException {
+ ClassFile getClassFile(final String name, final String suffix) {
final File file = new File(dir + File.separatorChar + name.replace('.', File.separatorChar) + suffix);
return file.exists() ? new ClassFile() {
@@ -279,7 +279,7 @@ public class ClassPath implements Closeable {
}
@Override
- ClassFile getClassFile(final String name, final String suffix) throws IOException {
+ ClassFile getClassFile(final String name, final String suffix) {
final Path resolved = modulePath.resolve(packageToFolder(name) + suffix);
if (Files.exists(resolved)) {
return new ClassFile() {
@@ -375,7 +375,7 @@ public class ClassPath implements Closeable {
}
@Override
- ClassFile getClassFile(final String name, final String suffix) throws IOException {
+ ClassFile getClassFile(final String name, final String suffix) {
// don't use a for each loop to avoid creating an iterator for the GC to collect.
for (final JrtModule module : modules) {
final ClassFile classFile = module.getClassFile(name, suffix);
@@ -668,7 +668,7 @@ public class ClassPath implements Closeable {
throw new IOException("Couldn't find: " + name + suffix);
}
- private ClassFile getClassFileInternal(final String name, final String suffix) throws IOException {
+ private ClassFile getClassFileInternal(final String name, final String suffix) {
for (final AbstractPathEntry path : paths) {
final ClassFile cf = path.getClassFile(name, suffix);
@@ -698,6 +698,7 @@ public class ClassPath implements Closeable {
* @param suffix
* file name ends with suff, e.g. .java
* @return input stream for file on class path
+ * @throws IOException
*/
public InputStream getInputStream(final String name, final String suffix) throws IOException {
InputStream inputStream = null;