[jira] [Commented] (AIRFLOW-5549) Extend BigQueryGetDataOperator to handle pagination

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937797#comment-16937797 ] 

ASF GitHub Bot commented on AIRFLOW-5549:
-----------------------------------------

mohannadbanayosi commented on pull request #6180: [AIRFLOW-5549] Exteded BQ GetDataOperator to handle query params
URL: https://github.com/apache/airflow/pull/6180
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-5549) issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-5549
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Currently the BigQueryGetDataOperator returns a list of rows only and not the total number of rows available and the page token to navigate to the next page. It also does not handle pagination (to request the next set of rows). The operator will now return the total number of rows and the next page token as well as handling start_index and page_token parameters.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Extend BigQueryGetDataOperator to handle pagination
> ---------------------------------------------------
>
>                 Key: AIRFLOW-5549
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5549
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp
>    Affects Versions: 1.10.4
>            Reporter: Mohannad Albanayosy
>            Assignee: Mohannad Albanayosy
>            Priority: Minor
>
> h2. Problem
> Currently the _BigQueryGetDataOperator_ returns a list of rows only and not the total number of rows available and the page token to navigate to the next page. It also does not handle pagination (to request the next set of rows).
> h2. Proposed implementation
> Extend the operator to return the required meta data as well as handle pagination.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)