You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2026/08/10 15:03:23 UTC
[I] [Bug] Consume TPS and message-out metrics are missing when KV POP is enabled [rocketmq]
majialoong opened a new issue, #10899:
URL: https://github.com/apache/rocketmq/issues/10899
### Before Creating the Bug Report
- [x] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions).
- [x] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate.
- [x] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.
### Runtime platform environment
All
### RocketMQ version
develop
### JDK Version
All
### Describe the Bug
When KV POP is enabled, successful POP consumption does not update `BROKER_GET_NUMS`, `GROUP_GET_NUMS`, `GROUP_GET_SIZE`, `rocketmq_messages_out_total`, or `rocketmq_throughput_out_total`.
As a result, `mqadmin consumerProgress` reports an incorrect Consume TPS, and the related BrokerStats and OTel metrics are also inaccurate.
### Steps to Reproduce
Enable KV POP on the Broker using `popConsumerKVServiceInit=true` and `popConsumerKVServiceEnable=true`.
Send messages to a topic and continuously consume them. While messages are being consumed, run `mqadmin consumerProgress` and inspect the related BrokerStats or OTel metrics.
### What Did You Expect to See?
KV POP should update the same message-out statistics as traditional POP. Consume TPS and the related message count and size metrics should accurately reflect the actual consumption.
### What Did You See Instead?
Messages are consumed and acknowledged normally, but the Consume TPS reported by `mqadmin consumerProgress` remains 0. The related BrokerStats and OTel metrics are not updated.
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Consume TPS and message-out metrics are missing when KV POP is enabled [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10899:
URL: https://github.com/apache/rocketmq/issues/10899#issuecomment-5242155782
**Issue Evaluation**
Category: `type/bug` | Status: **Confirmed**
The reported issue has been verified against the current codebase on the `develop` branch.
**Root Cause:** When `popConsumerKVServiceEnable=true`, `PopMessageProcessor` branches to `PopConsumerService.popAsync()` (line ~380). This KV POP path handles message delivery and acknowledgment but never calls `BrokerStatsManager.incBrokerGetNums()`, `incGroupGetNums()`, or `incGroupGetSize()`. The only stats calls in `PopConsumerService` are for **PUT** operations (line ~752-756, `incBrokerPutNums`/`incTopicPutNums`/`incTopicPutSize`). In contrast, the regular POP path in `PopMessageProcessor` (line ~792-795) correctly updates all three GET metrics after successful message delivery.
**Impact:** `mqadmin consumerProgress` reports Consume TPS as 0; `BROKER_GET_NUMS`, `GROUP_GET_NUMS`, `GROUP_GET_SIZE`, and the corresponding OTel metrics (`rocketmq_messages_out_total`, `rocketmq_throughput_out_total`) are not updated for KV POP consumption.
**Severity:** Medium — data plane works correctly (messages are consumed and acked), but observability is broken.
**Suggested Fix:** Add `incBrokerGetNums`/`incGroupGetNums`/`incGroupGetSize` calls in the KV POP success path, either inside `PopConsumerService.popAsync()` after messages are found, or in `PopMessageProcessor` after the `popAsyncFuture` completes with `result.isFound()`.
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug] Consume TPS and message-out metrics are missing when KV POP is enabled [rocketmq]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #10899:
URL: https://github.com/apache/rocketmq/issues/10899#issuecomment-5267906204
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported issue has been verified against the current codebase.
**Root Cause:** In `PopMessageProcessor.java`, when `popConsumerKVServiceEnable=true` (line 380), the code takes an async path via `popConsumerService().popAsync()`. The result is processed in a `thenApply` callback that handles the response but does not call any stats methods (`incBrokerGetNums`, `incGroupGetNums`, etc.).
In contrast, the traditional POP path (line 792) correctly calls `incBrokerGetNums(topic, result.getMessageCount())`. The KV POP path is missing these metric updates entirely.
**Impact:** When KV POP is enabled:
- `mqadmin consumerProgress` reports Consume TPS as 0
- `BROKER_GET_NUMS`, `GROUP_GET_NUMS`, `GROUP_GET_SIZE` are not updated
- OTel metrics `rocketmq_messages_out_total` and `rocketmq_throughput_out_total` are inaccurate
**Severity:** Medium — monitoring and observability are broken for KV POP mode.
**Suggested Fix:** Add the same stats increment calls in the KV POP `thenApply` callback that exist in the traditional POP path (around line 792).
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org