You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by diegoceccarelli <gi...@git.apache.org> on 2017/12/28 16:38:42 UTC
[GitHub] lucene-solr pull request #295: SOLR-11800: Improve error message when parsin...
GitHub user diegoceccarelli opened a pull request:
https://github.com/apache/lucene-solr/pull/295
SOLR-11800: Improve error message when parsing RankQuery
When a user specifies something wrong for the parameter `rq` sometimes it is hard to understand where is the problem, this patch attempts to improve the error message returned in the response.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr SOLR-11800
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit 64928e43710eb86be0f7e23adbc8107da124efb8
Author: Diego Ceccarelli <dc...@...>
Date: 2017-12-28T16:22:55Z
SOLR-11800: Improve error message when parsing RankQuery
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #295: SOLR-11800: Improve error message when parsin...
Posted by diegoceccarelli <gi...@git.apache.org>.
Github user diegoceccarelli commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/295#discussion_r158969387
--- Diff: solr/core/src/java/org/apache/solr/search/QParser.java ---
@@ -360,6 +360,10 @@ public static QParser getParser(String qstr, String parserName, boolean allowLoc
}
QParserPlugin qplug = req.getCore().getQueryPlugin(parserName);
+ if (qplug == null){
+ // error: log ?
--- End diff --
I would log an error here, but `QParser` doesn't have a logger, should we add one?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org