You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/05/07 12:12:41 UTC

[GitHub] [qpid-proton] jiridanek opened a new pull request #311: NO-JIRA fix travis build?

jiridanek opened a new pull request #311:
URL: https://github.com/apache/qpid-proton/pull/311


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #311: NO-JIRA fix travis build?

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #311:
URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834548088


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#311](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82a894b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/08b301a97c834e002d41ee852bba1288fe83b936?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08b301a) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/311/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##             main     #311      +/-   ##
   ==========================================
   - Coverage   69.20%   69.17%   -0.04%     
   ==========================================
     Files         352      352              
     Lines       69564    69557       -7     
   ==========================================
   - Hits        48144    48114      -30     
   - Misses      21420    21443      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `84.57% <0.00%> (-1.37%)` | :arrow_down: |
   | [c/src/core/transport.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS90cmFuc3BvcnQuYw==) | `90.22% <0.00%> (-0.06%)` | :arrow_down: |
   | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.68% <0.00%> (-0.06%)` | :arrow_down: |
   | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.49% <0.00%> (+0.06%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [08b301a...82a894b](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek commented on pull request #311: NO-JIRA Workaround Travis CI package installation issues

Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #311:
URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834609012


   @gemmellr @astitcher looks like this worked. Should be merged quickly, before they break something else!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek merged pull request #311: NO-JIRA Workaround Travis CI package installation issues

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #311:
URL: https://github.com/apache/qpid-proton/pull/311


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #311: NO-JIRA fix travis build?

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #311:
URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834548088


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#311](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82a894b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/08b301a97c834e002d41ee852bba1288fe83b936?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08b301a) will **increase** coverage by `19.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/311/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #311       +/-   ##
   ===========================================
   + Coverage   69.20%   88.34%   +19.13%     
   ===========================================
     Files         352       47      -305     
     Lines       69564     2394    -67170     
   ===========================================
   - Hits        48144     2115    -46029     
   + Misses      21420      279    -21141     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cpp/examples/ssl.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2V4YW1wbGVzL3NzbC5jcHA=) | | |
   | [cpp/src/data.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kYXRhLmNwcA==) | | |
   | [cpp/src/object\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9vYmplY3RfdGVzdC5jcHA=) | | |
   | [cpp/include/proton/receiver.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3JlY2VpdmVyLmhwcA==) | | |
   | [c/examples/send-ssl.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9leGFtcGxlcy9zZW5kLXNzbC5j) | | |
   | [cpp/src/reconnect\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZWNvbm5lY3Rfb3B0aW9ucy5jcHA=) | | |
   | [cpp/include/proton/codec/unordered\_map.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL3Vub3JkZXJlZF9tYXAuaHBw) | | |
   | [cpp/src/contexts.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb250ZXh0cy5ocHA=) | | |
   | [c/src/messenger/subscription.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvbWVzc2VuZ2VyL3N1YnNjcmlwdGlvbi5j) | | |
   | [build/c/src/extra/url.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVpbGQvYy9zcmMvZXh0cmEvdXJsLmM=) | | |
   | ... and [295 more](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [08b301a...82a894b](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter commented on pull request #311: NO-JIRA fix travis build?

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #311:
URL: https://github.com/apache/qpid-proton/pull/311#issuecomment-834548088


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#311](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82a894b) into [main](https://codecov.io/gh/apache/qpid-proton/commit/08b301a97c834e002d41ee852bba1288fe83b936?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08b301a) will **increase** coverage by `14.98%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/311/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff             @@
   ##             main     #311       +/-   ##
   ===========================================
   + Coverage   69.20%   84.19%   +14.98%     
   ===========================================
     Files         352       46      -306     
     Lines       69564     2341    -67223     
   ===========================================
   - Hits        48144     1971    -46173     
   + Misses      21420      370    -21050     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [ruby/lib/core/message.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29yZS9tZXNzYWdlLnJi) | `56.47% <0.00%> (-32.36%)` | :arrow_down: |
   | [ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi) | `59.37% <0.00%> (-28.13%)` | :arrow_down: |
   | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `76.52% <0.00%> (-19.57%)` | :arrow_down: |
   | [ruby/lib/codec/mapping.rb](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cnVieS9saWIvY29kZWMvbWFwcGluZy5yYg==) | `88.17% <0.00%> (-1.08%)` | :arrow_down: |
   | [cpp/src/data.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9kYXRhLmNwcA==) | | |
   | [c/src/core/util.h](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS91dGlsLmg=) | | |
   | [cpp/src/proton\_bits.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9wcm90b25fYml0cy5jcHA=) | | |
   | [cpp/include/proton/type\_id.hpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3R5cGVfaWQuaHBw) | | |
   | [build/c/src/core/autodetect.c](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVpbGQvYy9zcmMvY29yZS9hdXRvZGV0ZWN0LmM=) | | |
   | [cpp/src/returned.cpp](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9yZXR1cm5lZC5jcHA=) | | |
   | ... and [300 more](https://codecov.io/gh/apache/qpid-proton/pull/311/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [08b301a...82a894b](https://codecov.io/gh/apache/qpid-proton/pull/311?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org