You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/26 11:49:45 UTC
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support
szaszm opened a new pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142
squashed:
commit baa3f502d8fdc6a395983295c8f4187c088765d5
Author: Marton Szasz <sz...@apache.org>
Date: Sun Jul 25 14:07:11 2021 +0200
patch sol2 to not fail in C++20 mode
on mac xcode/AppleClang, due to const char*/const char8_t*
incompatibility and the fact that u8"string" literals are now
const char8*.
error: invalid conversion from 'const char8_t*' to 'const char*'
(and friends)
commit 8d6476be877d14e64db25bbdc71adc30b5fc9dd6
Author: Marton Szasz <sz...@apache.org>
Date: Wed Jul 21 07:00:26 2021 +0200
back to C++20
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676580488
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>, basic_string_view>,
#endif
Review comment:
makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676556838
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>, basic_string_view>,
#endif
Review comment:
I'd rather not change it now, in the context of this PR. Maybe on the next upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676561438
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>, basic_string_view>,
#endif
Review comment:
I am OK with doing it in another PR, I am also OK with not making the change if this is a rarely touched dependency (it seems to be), although I feel that having a separate patch file helps with upgrades/tracking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support
Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676577714
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>, basic_string_view>,
#endif
Review comment:
I agree that it would make the changes more visible, although I tried my best by adding comments where I patched the source.
Changing this to ExternalProject would be less than ideal, because the header would not be available before the first build.
Because of this I would go for FetchContent, but due to its different syntax, I would most likely need to manually invoke the patch command at the right times instead of letting cmake take care of it. This is somewhat unknown territory and I would need to do more research, that's why I prefer not to do it now.
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>, basic_string_view>,
#endif
Review comment:
I agree that it would make the changes more visible, although I tried my best by adding comments where I patched the source.
Changing this to ExternalProject would be less than ideal, because the header would not be available before the first build.
Because of this, I would go for FetchContent, but due to its different syntax, I would most likely need to manually invoke the patch command at the right times instead of letting cmake take care of it. This is somewhat unknown territory and I would need to do more research, that's why I prefer not to do it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1142: MINIFICPP-1425 Proceed to partial C++20 support
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1142#discussion_r676534550
##########
File path: thirdparty/sol2-2.20.0/sol.hpp
##########
@@ -1719,7 +1719,8 @@ namespace sol {
#else
is_specialization_of<meta::unqualified_t<T>, basic_string_view>,
#endif
Review comment:
as with pybind11, could we fetch the sources configuration time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org