[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #687: GUACAMOLE-1508: Add support for nesting .jar files within extensions.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #687:
URL: https://github.com/apache/guacamole-client/pull/687#discussion_r789318956



##########
File path: guacamole/src/main/java/org/apache/guacamole/extension/Extension.java
##########
@@ -355,12 +356,18 @@
      * @param file
      *     The file to load as an extension.
      *
+     * @param temporaryFiles
+     *     A modifiable List that should be populated with all temporary files
+     *     created for this extension. These files should be deleted on
+     *     application shutdown in reverse order.
+     *
      * @throws GuacamoleException
      *     If the provided file is not a .jar file, does not contain the
      *     guac-manifest.json, or if guac-manifest.json is invalid and cannot
      *     be parsed.
      */
-    public Extension(final ClassLoader parent, final File file) throws GuacamoleException {
+    public Extension(final ClassLoader parent, final File file,
+            final List<File> temporaryFiles) throws GuacamoleException {

Review comment:
       > Should there be a backward-compatible convenience method?
   
   Nope! The classes touched here are strictly the internals of the webapp, not part of guacamole-ext or any other library.
   
   > Is this going to break older versions of extensions in whatever version of Guacamole (1.5.0?) gets this functionality?
   
   Nope! The previous functionality was:
   
   * `.class` files are loaded directly from the extension `.jar` file
   
   while the new functionality is:
   
   * `.class` files are loaded directly from the extension `.jar` file
   * `.class` files are additionally loaded directly from any `.jar` files within the archive root of the extension `.jar` file
   
   So what we have here is a superset of what we had before, with modifications to only internal components.
   
   The only way that an extension might encounter problems is if it already includes one or more `.jar` files in its root and relies on Guacamole _not_ loading them ... which would be pretty odd IMHO.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org