You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "wuchong (via GitHub)" <gi...@apache.org> on 2023/03/23 15:48:50 UTC
[GitHub] [flink] wuchong opened a new pull request, #22255: Cleanup usage of deprecated TableEnvironment#registerTable
wuchong opened a new pull request, #22255:
URL: https://github.com/apache/flink/pull/22255
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Replace the usage of deprecated `TableEnvironment#registerTable()` with `TableEnvironment#createTemporaryView()`
## Brief change log
- Replace the usage of deprecated `registerTable()` with `createTemporaryView()`
- Quotes the registered UUID table name in `TableTestBase` to fix the failed tests
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #22255:
URL: https://github.com/apache/flink/pull/22255#issuecomment-1482194877
@wuchong hi, jark. Another question, do we have a timeline (e.g. 1.18) to remove these deprecate methods, otherwise it is still possible for implementors to call these methods. (In fact, currently there are too many deprecated interfaces or methods in flink, we can take a step at the table layer)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong merged PR #22255:
URL: https://github.com/apache/flink/pull/22255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #22255:
URL: https://github.com/apache/flink/pull/22255#issuecomment-1483086948
> @chucheng92 , yes, I missed updating `SemiAntiJoinStreamITCase`. But I will leave `StreamTableEnvironmentImpl` as it is. Because simply replacing the `registerTable` with `createTemporaryView` will break the API compatibility (path identifier vs arbitrary name string). The usage of `registerTable` can be removed when we drop the deprecated methods in `StreamTableEnvironment`.
thanks for explanations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chucheng92 commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "chucheng92 (via GitHub)" <gi...@apache.org>.
chucheng92 commented on PR #22255:
URL: https://github.com/apache/flink/pull/22255#issuecomment-1483100671
> @chucheng92 , yes, I missed updating `SemiAntiJoinStreamITCase`. But I will leave `StreamTableEnvironmentImpl` as it is. Because simply replacing the `registerTable` with `createTemporaryView` will break the API compatibility (path identifier vs arbitrary name string). The usage of `registerTable` can be removed when we drop the deprecated methods in `StreamTableEnvironment`.
can i understand that the current replacement is only for the test class and a few internal class, and not execute replacement for the exposed API until we prepare to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on code in PR #22255:
URL: https://github.com/apache/flink/pull/22255#discussion_r1147767963
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -1185,7 +1185,7 @@ abstract class TableTestUtil(
name)
val operation = new RichTableSourceQueryOperation(identifier, tableSource, statistic)
val table = testingTableEnv.createTable(operation)
- testingTableEnv.registerTable(name, table)
+ testingTableEnv.createTemporaryView(name, table)
Review Comment:
Good catch. I will update the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on PR #22255:
URL: https://github.com/apache/flink/pull/22255#issuecomment-1483032285
@chucheng92 , yes, I missed updating `SemiAntiJoinStreamITCase`. But I will leave `StreamTableEnvironmentImpl` as it is. Because simply replacing the `registerTable` with `createTemporaryView` will break the API compatibility (path identifier vs arbitrary name string). The usage of `registerTable` can be removed when we drop the deprecated methods in `StreamTableEnvironment`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on PR #22255:
URL: https://github.com/apache/flink/pull/22255#issuecomment-1486172353
@chucheng92 , yes, as I mentioned in the JIRA issue, this effort is to make it easier for us to remove the deprecated interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22255: Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22255:
URL: https://github.com/apache/flink/pull/22255#issuecomment-1481451190
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90419da0b888b031850c289c21519054348857a9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90419da0b888b031850c289c21519054348857a9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90419da0b888b031850c289c21519054348857a9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #22255:
URL: https://github.com/apache/flink/pull/22255#discussion_r1147259317
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -1185,7 +1185,7 @@ abstract class TableTestUtil(
name)
val operation = new RichTableSourceQueryOperation(identifier, tableSource, statistic)
val table = testingTableEnv.createTable(operation)
- testingTableEnv.registerTable(name, table)
+ testingTableEnv.createTemporaryView(name, table)
Review Comment:
There is a TODO comment above mentioning `registerTable`. Shouldn't it be updated as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #22255:
URL: https://github.com/apache/flink/pull/22255#issuecomment-1482441472
+1 for this cleanup in general.
Also wonder about `SemiAntiJoinStreamITCase` and `StreamTableEnvironmentImpl` mentioned by @chucheng92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org