You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "techdocsmith (via GitHub)" <gi...@apache.org> on 2023/01/25 20:33:35 UTC
[GitHub] [druid] techdocsmith commented on a diff in pull request #13695: Fix value of lookup sync period in docs
techdocsmith commented on code in PR #13695:
URL: https://github.com/apache/druid/pull/13695#discussion_r1087137555
##########
docs/configuration/index.md:
##########
@@ -980,7 +980,7 @@ http://<COORDINATOR_IP>:<PORT>/druid/coordinator/v1/config/history?count=<n>
```
##### Lookups Dynamic Configuration
-These configuration options control the behavior of the Lookup dynamic configuration described in the [lookups page](../querying/lookups.md)
+These configuration options control the lookup management done by the coordinator. Configurations that affect propagation of lookups can be found in [dynamic configuration for lookups](../querying/lookups.md#dynamic-configuration).
Review Comment:
```suggestion
These configuration options control Coordinator lookup management. See [dynamic configuration for lookups](../querying/lookups.md#dynamic-configuration) configurations that affect lookup propagation.
```
##########
docs/configuration/index.md:
##########
@@ -989,7 +989,7 @@ These configuration options control the behavior of the Lookup dynamic configura
|`druid.manager.lookups.deleteAllTimeout`|How long to wait for all `DELETE` requests to finish before considering the delete attempt a failure|PT10S|
|`druid.manager.lookups.updateAllTimeout`|How long to wait for all `POST` requests to finish before considering the attempt a failure|PT60S|
|`druid.manager.lookups.threadPoolSize`|How many processes can be managed concurrently (concurrent POST and DELETE requests). Requests this limit will wait in a queue until a slot becomes available.|10|
-|`druid.manager.lookups.period`|How many milliseconds between checks for configuration changes|30_000|
+|`druid.manager.lookups.period`|How many milliseconds between checks for configuration changes|120000 (2 mins)|
Review Comment:
```suggestion
|`druid.manager.lookups.period`|Number of milliseconds between checks for configuration changes|120000 (2 minutes)|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org