You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/12/03 23:49:14 UTC

[GitHub] ConcurrencyPractitioner commented on a change in pull request #3108: Exception Handling for Null Pointer Exception in BrokerService

ConcurrencyPractitioner commented on a change in pull request #3108: Exception Handling for Null Pointer Exception in BrokerService
URL: https://github.com/apache/pulsar/pull/3108#discussion_r238483572
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -429,7 +429,11 @@ public void unloadNamespaceBundlesGracefully() {
             // make broker-node unavailable from the cluster
             if (pulsar.getLoadManager() != null) {
                 try {
-                    pulsar.getLoadManager().get().disableBroker();
+                    if (pulsar.getLoadManager() == null || pulsar.getLoadManager().get() == null) {
 
 Review comment:
   No problem with that. It simplifies things.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services