You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/21 03:30:27 UTC
[GitHub] [dolphinscheduler] wuliupo opened a new pull request #7515: fix: replace node-sass with dart-sass
wuliupo opened a new pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515
LibSass and Node Sass are deprecated.
https://www.npmjs.com/package/node-sass
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
songjianet commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999426991
- After the change, whether to clear the browser's cache of the current page to view the page style?
- Is the style of all pages displayed correctly after the change?
- Can the `build` command be executed correctly after the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet edited a comment on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
songjianet edited a comment on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999540865
Please rebase the latest code to test the effect on the page to check whether the page style is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999540238
> ## The below e2e Test / Test (pull_request)
> it seems another test issue, not included by this commit. When I run checkout master and run `cd ./e2e && mvn -B clean test -X`, it has the same error,
>
> > "org.apache.maven.surefire.shade.org.apache.commons.lang3.SystemUtils.JAVA_SPECIFICATION_VERSION_AS_ENUM" is null
Can you update the code from upstream?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuliupo edited a comment on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
wuliupo edited a comment on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999512070
## The below e2e Test / Test (pull_request)
it seems another test issue, not included by this commit.
When I run checkout master and run `cd ./e2e && mvn -B clean test -X`, it has the same error,
> "org.apache.maven.surefire.shade.org.apache.commons.lang3.SystemUtils.JAVA_SPECIFICATION_VERSION_AS_ENUM" is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
songjianet commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999540865
Please rebase the latest code to test the effect on the page to check whether the page style is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999579690
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7515?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7515](https://codecov.io/gh/apache/dolphinscheduler/pull/7515?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (44913ef) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/9f56123a26096e9e423a447e659180b9153de07d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f56123) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dolphinscheduler/pull/7515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## dev #7515 +/- ##
============================================
- Coverage 41.29% 41.25% -0.04%
+ Complexity 3674 3671 -3
============================================
Files 641 641
Lines 26469 26469
Branches 2961 2961
============================================
- Hits 10930 10921 -9
- Misses 14514 14521 +7
- Partials 1025 1027 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/7515?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...lphinscheduler/common/task/AbstractParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svQWJzdHJhY3RQYXJhbWV0ZXJzLmphdmE=) | `51.61% <0.00%> (-8.07%)` | :arrow_down: |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/7515/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.70% <0.00%> (-2.82%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7515?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/7515?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9f56123...44913ef](https://codecov.io/gh/apache/dolphinscheduler/pull/7515?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999557115
You should open the pull request to `dev` branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuliupo commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
wuliupo commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-1000006372
> HttpError: Invalid request.
>
> Only 65535 characters are allowed; 112965 were supplied.
it seems environment error. @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #7515: fix: replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-998749005
Hi @wuliupo , please change the pr title such as [Bug-issueId][UI] pr theme, thxs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuliupo closed pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
wuliupo closed pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] mergeable[bot] removed a comment on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
mergeable[bot] removed a comment on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999557349
#### :x: Error Occurred while executing an Action
If you believe this is an unexpected error, please report it on our issue tracker: https://github.com/mergeability/mergeable/issues/new
##### Error Details
--------------------
HttpError: Invalid request.
Only 65535 characters are allowed; 112964 were supplied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] mergeable[bot] commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
mergeable[bot] commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999557349
#### :x: Error Occurred while executing an Action
If you believe this is an unexpected error, please report it on our issue tracker: https://github.com/mergeability/mergeable/issues/new
##### Error Details
--------------------
HttpError: Invalid request.
Only 65535 characters are allowed; 112964 were supplied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet edited a comment on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
songjianet edited a comment on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999540865
Please rebase the latest code to test the effect on the page to check whether the page style is correct. You can add me on WeChat 18802464247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999583763
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7515&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7515&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuliupo commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
wuliupo commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999509739
> After the change, whether to clear the browser's cache of the current page to view the page style?
-- yes
Is the style of all pages displayed correctly after the change?
-- yes
Can the build command be executed correctly after the change?
-- yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999424814
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7515&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7515&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999424814
Kudos, SonarCloud Quality Gate passed! 
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=7515&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7515&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=7515&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuliupo commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
wuliupo commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999512070
## The above e2e Test / Test (pull_request)
it seems another test issue, not included by this commit.
When I run checkout master and run `cd ./e2e && mvn -B clean test -X`, it has the same error,
> "org.apache.maven.surefire.shade.org.apache.commons.lang3.SystemUtils.JAVA_SPECIFICATION_VERSION_AS_ENUM" is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] mergeable[bot] commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
mergeable[bot] commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-999557519
#### :x: Error Occurred while executing an Action
If you believe this is an unexpected error, please report it on our issue tracker: https://github.com/mergeability/mergeable/issues/new
##### Error Details
--------------------
HttpError: Invalid request.
Only 65535 characters are allowed; 112965 were supplied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] wuliupo commented on pull request #7515: [6696/1880][UI] replace node-sass with dart-sass
Posted by GitBox <gi...@apache.org>.
wuliupo commented on pull request #7515:
URL: https://github.com/apache/dolphinscheduler/pull/7515#issuecomment-1009559448
Due to the refactor of next version base on Vue3, this changes will be unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org