You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by do...@apache.org on 2021/01/06 17:37:42 UTC
[geode] branch support/1.13 updated: GEODE-8789: Prevent region
name from being incorrectly logged twice
This is an automated email from the ASF dual-hosted git repository.
donalevans pushed a commit to branch support/1.13
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/support/1.13 by this push:
new ec21170 GEODE-8789: Prevent region name from being incorrectly logged twice
ec21170 is described below
commit ec21170c5a1104b40e980ea0597716f862c8d464
Author: Donal Evans <do...@vmware.com>
AuthorDate: Mon Dec 14 14:29:43 2020 -0800
GEODE-8789: Prevent region name from being incorrectly logged twice
- Do not format the String containing the reason for the exception to
contain the region name
Authored-by: Donal Evans <do...@vmware.com>
(cherry picked from commit c723c046a82e33a50c5a138753b0466515b3230c)
---
.../org/apache/geode/internal/cache/tier/sockets/BaseCommand.java | 6 +++---
.../geode/internal/cache/tier/sockets/command/CreateRegion.java | 4 +---
.../apache/geode/internal/cache/tier/sockets/command/Destroy.java | 3 +--
.../apache/geode/internal/cache/tier/sockets/command/Destroy65.java | 3 +--
.../geode/internal/cache/tier/sockets/command/DestroyRegion.java | 2 +-
.../org/apache/geode/internal/cache/tier/sockets/command/Get70.java | 2 +-
.../geode/internal/cache/tier/sockets/command/Invalidate.java | 3 +--
.../apache/geode/internal/cache/tier/sockets/command/KeySet.java | 3 +--
.../org/apache/geode/internal/cache/tier/sockets/command/Put.java | 3 +--
.../apache/geode/internal/cache/tier/sockets/command/Request.java | 3 +--
.../org/apache/geode/internal/cache/tier/sockets/command/Size.java | 3 +--
11 files changed, 13 insertions(+), 22 deletions(-)
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
index f2c5292..c933d6a 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
@@ -618,10 +618,10 @@ public abstract class BaseCommand implements Command {
errorMsg.send(serverConnection);
}
- protected static void writeRegionDestroyedEx(Message msg, String regionName, String title,
+ protected static void writeRegionDestroyedEx(Message msg, String regionName, String reason,
ServerConnection serverConnection) throws IOException {
- String reason = serverConnection.getName() + ": Region named " + regionName + title;
- RegionDestroyedException ex = new RegionDestroyedException(reason, regionName);
+ String exceptionMessage = serverConnection.getName() + ": Region named " + regionName + reason;
+ RegionDestroyedException ex = new RegionDestroyedException(exceptionMessage, regionName);
if (serverConnection.getTransientFlag(REQUIRES_CHUNKED_RESPONSE)) {
writeChunkedException(msg, ex, serverConnection);
} else {
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java
index 0bedd47..4e6241d 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegion.java
@@ -87,9 +87,7 @@ public class CreateRegion extends BaseCommand {
Region parentRegion = serverConnection.getCache().getRegion(parentRegionName);
if (parentRegion == null) {
- String reason =
- String.format("%s was not found during subregion creation request",
- parentRegionName);
+ String reason = " was not found during subregion creation request";
writeRegionDestroyedEx(clientMessage, parentRegionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java
index d356a5c..b0ecfaa 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy.java
@@ -119,8 +119,7 @@ public class Destroy extends BaseCommand {
LocalRegion region = (LocalRegion) serverConnection.getCache().getRegion(regionName);
if (region == null) {
- String reason = String.format("%s was not found during destroy request",
- regionName);
+ String reason = " was not found during destroy request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java
index c093b6a..9e49712 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65.java
@@ -210,8 +210,7 @@ public class Destroy65 extends BaseCommand {
final LocalRegion region = (LocalRegion) serverConnection.getCache().getRegion(regionName);
if (region == null) {
- String reason = String.format("%s was not found during destroy request",
- regionName);
+ String reason = " was not found during destroy request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java
index 4d73278..642ef2e 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegion.java
@@ -110,7 +110,7 @@ public class DestroyRegion extends BaseCommand {
LocalRegion region = (LocalRegion) serverConnection.getCache().getRegion(regionName);
if (region == null) {
String reason =
- "Region was not found during destroy region request";
+ " was not found during destroy region request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java
index 155e4cc..895dd22 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Get70.java
@@ -125,7 +125,7 @@ public class Get70 extends BaseCommand {
Region region = serverConnection.getCache().getRegion(regionName);
if (region == null) {
- String reason = String.format("%s was not found during get request", regionName);
+ String reason = " was not found during get request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java
index 69abb92..3aecc9f 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Invalidate.java
@@ -113,8 +113,7 @@ public class Invalidate extends BaseCommand {
}
LocalRegion region = (LocalRegion) serverConnection.getCache().getRegion(regionName);
if (region == null) {
- String reason = String.format("%s was not found during %s request",
- regionName, "invalidate");
+ String reason = " was not found during invalidate request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java
index c8e9487..2385461 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/KeySet.java
@@ -86,8 +86,7 @@ public class KeySet extends BaseCommand {
LocalRegion region = (LocalRegion) serverConnection.getCache().getRegion(regionName);
if (region == null) {
- String reason = String.format("%s was not found during key set request",
- regionName);
+ String reason = " was not found during key set request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java
index 281831f..90ec9a4 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Put.java
@@ -119,8 +119,7 @@ public class Put extends BaseCommand {
LocalRegion region = (LocalRegion) serverConnection.getCache().getRegion(regionName);
if (region == null) {
- String reason =
- ": Region was not found during put request";
+ String reason = " was not found during put request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java
index b6c8f9c..d21d50a 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Request.java
@@ -116,8 +116,7 @@ public class Request extends BaseCommand {
} else {
Region region = serverConnection.getCache().getRegion(regionName);
if (region == null) {
- String reason = String.format("%s was not found during get request",
- regionName);
+ String reason = " was not found during get request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
} else {
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java
index b8268d4..1bb15d8 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Size.java
@@ -80,8 +80,7 @@ public class Size extends BaseCommand {
LocalRegion region = (LocalRegion) crHelper.getRegion(regionName);
if (region == null) {
- String reason = String.format("%s was not found during %s request",
- regionName, "size");
+ String reason = " was not found during size request";
writeRegionDestroyedEx(clientMessage, regionName, reason, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;